Pinned verification commands keep the CI check that proves them - #190
Merged
Conversation
czpython
force-pushed
the
agent/ENG-825
branch
2 times, most recently
from
August 6, 2026 18:58
88e3d9a to
33dc2ef
Compare
Building the effective profile from the operator's pinned commands hardcoded ci_check to None, discarding what the profiler detected. The evaluator runs any command that names no check, so a repo pinning its verification ran every one in the sandbox and could never read its own CI. Pinning chooses which commands gate a PR; it no longer decides what proves them.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Building the effective profile from the operator's pinned commands hardcoded
ci_checktoNoneon every one, discarding what the profiler detected. The evaluator runs any command that names no check — "A configured command with no CI check name runs locally. Never infer that another check covers it." So a repo pinning its verification in.druks/ship/config.ymlran every command in the sandbox on every evaluation and could never read its own CI, however often it was re-profiled.VerificationProfile.with_ci_checkspairs each pinned command with the check detected for that same command. Pinning chooses which commands gate a PR; it no longer decides what proves them.Acceptance criteria
ci_checkin the stored effective profile.test_pinned_command_keeps_the_check_detected_for_itpins("pytest", "make e2e")against a profile that detectedpytestunderBackend / tests, and asserts the stored entries.ci_check: null.make e2eentry, plustest_pinned_verification_replaces_the_detected_oneandtest_skips_the_agent_and_reapplies_the_pin, which pass unchanged.test_persists_baseline_and_effective, unchanged.Closes ENG-825.
🤖 Generated with Claude Code