docker-install-build-deps: trust the tap before tapping it - #172
Merged
Merged
Conversation
Current Homebrew evaluates a new tap's formulae at tap time and refuses to load them from an untrusted tap, failing the tap itself — so the trust call after it never ran, and every image build died at 'Cannot tap d3mlabs/d3mlabs: invalid syntax in tap!'. brew trust records trust by name before the tap exists, so it goes first. Co-authored-by: Cursor <cursoragent@cursor.com>
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Current Homebrew evaluates a new tap's formulae at tap time and refuses to load them from an untrusted tap, failing the tap itself (
Cannot tap d3mlabs/d3mlabs: invalid syntax in tap!) — so thebrew trustcall placed after the tap never ran, and every container image build died indocker-install-build-deps.sh.brew trustrecords trust by tap name before the tap exists, so it moves ahead ofbrew tap. Verified in a freshhomebrew/brew:latestcontainer: trust-then-tap taps cleanly and resolves formulae; tap-without-trust reproduces the failure.Companion tap-side fixes already landed in d3mlabs/homebrew-d3mlabs (clang-format@18.1.8 arm64-Linux wheel, powershell@7.4.0 top-level URL) — the new tap-time check also evaluates every formula for every platform and one URL-less platform poisons the whole tap.
Made with Cursor