Conversation
The GUI-area catch-up: dappco.re/go v0.10.4 → v0.11.0, config v0.3.0 → v0.18.0, webview v0.9.0 → v0.11.0 (freshly tagged go/v0.11.0 — the repo's module moved under go/ but the subdir tag series had never been cut, so v0.10.0 resolved to a docs-only root; go-webview also bumped to core v0.11.0 with 697 tests green before tagging), plus the wails v3 series jump alpha.96 → alpha2.117. The entire wails jump cost ONE fix: MacWebviewPreferences. AllowsBackForwardNavigationGestures moved from leaanthony/u.Bool to wails' internal optional.Bool — the field's Set method is the public construction path (the interface abstraction confined the churn to the adapter, as designed). Gates: go build + vet clean, 2681 tests green across 26 packages. Co-Authored-By: Virgil <virgil@lethean.io>
…line The GOWORK=off gate (what CI runs) caught the call sites the workspace build masked: gowebview.New/NewCDPClient now return core.Result (unwrapped at the adapter boundary), core.PathWalk returns core.Result (directorySize keeps its partial-sum semantics), and Fs.Exists/IsDir report existence as Result.OK (manifest discovery migrated per the core v0.11.0 idiom). Submodules re-pinned so workspace mode builds the same line the tags resolve: external/go → v0.11.0, external/webview → dev (the core.Result API the go/v0.11.0 tag ships), external/io → dev (its Result migration is unreleased — the proxy's v0.14.0 differs from the repo tag, worth a fresh io release), external/log → go/v0.13.0. Gates BOTH modes: GOWORK=off build+vet+2681 tests green; workspace build+vet+2681 tests green. Co-Authored-By: Virgil <virgil@lethean.io>
|
Caution Review failedThe pull request is closed. ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: ⛔ Files ignored due to path filters (3)
📒 Files selected for processing (9)
📝 WalkthroughWalkthroughGo dependencies and external submodule references were updated. Filesystem checks now use result statuses, while webview construction, PDF export, and macOS window preferences use revised APIs. ChangesGo dependency and integration updates
Warning Billing warning: we have not been able to collect payment for this subscription for more than 72 hours. Please update the payment method or pay any pending invoices in Billing to avoid service interruption. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The GUI-area version catch-up: dappco.re/go v0.11.0, config v0.18.0, webview v0.11.0 (freshly tagged), wails v3 alpha.96 → alpha2.117 (one adapter fix — the optional.Bool move), plus the core.Result API migration the GOWORK=off gate surfaced (gowebview constructors, core.PathWalk, Fs.Exists/IsDir) and submodule re-pins so workspace mode matches the tagged line.
Gates both modes: GOWORK=off and workspace — build + vet + 2681 tests green each.
🤖 Generated with Claude Code
Co-Authored-By: Virgil virgil@lethean.io
Summary by CodeRabbit
Bug Fixes
Chores