chore(typescript): bump to v7 and replace astro check with tsc --noEmit#96
Conversation
astro check / @astrojs/check depends on TypeScript's old Language Service API, which TypeScript 7 (native port) removed, so it crashes (getTsconfig: Cannot read properties of undefined 'fileExists'). astro build itself uses Astro's own Go/WASM compiler and is unaffected. Swap the CI type-check from 'astro check' to 'tsc --noEmit' (TS7's native tsc type-checks .ts files correctly). .astro component templates are no longer type-checked until @astrojs/check ships TS7 support.
|
Warning Review limit reached
Next review available in: 43 minutes Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: ⛔ Files ignored due to path filters (1)
📒 Files selected for processing (1)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Supersedes the closed renovate PR #95. Bumps TypeScript to v7 and makes CI buildable.
Why
astro checkhad to goastro check/@astrojs/checkdrives the Astro language server, which depends on TypeScript's Language Service API. TypeScript 7 (the native port) drops that JS-based API surface, so the language server crashes:See withastro/roadmap#1321 — full Astro integration can't happen until a new API stabilizes.
@astrojs/check(0.9.9) is already latest with no TS7-compatible release.The fix
astro builditself is unaffected — Astro's own Go/WASM compiler doesn't use the TS compiler API. Only the type-check step broke. So:package.jsonci→bun x tsc --noEmit && bun run build^6.0.3→^7.0.0(+bun.lockregenerated)tsc --noEmituses TS7's nativetscand type-checks all.ts/.tsxfiles cleanly (verified locally: exit 0).Limitation
.astrocomponent templates are no longer type-checked in CI (that's exactly whatastro checkdid, and it's the part that broke)..tscode is still fully checked. Re-enable.astrotemplate checking once@astrojs/checkships TS7 support.