Skip to content

chore(typescript): bump to v7 and replace astro check with tsc --noEmit#96

Merged
dacrab merged 1 commit into
mainfrom
fix/ts7-build
Jul 12, 2026
Merged

chore(typescript): bump to v7 and replace astro check with tsc --noEmit#96
dacrab merged 1 commit into
mainfrom
fix/ts7-build

Conversation

@dacrab

@dacrab dacrab commented Jul 12, 2026

Copy link
Copy Markdown
Owner

Supersedes the closed renovate PR #95. Bumps TypeScript to v7 and makes CI buildable.

Why astro check had to go

astro check / @astrojs/check drives the Astro language server, which depends on TypeScript's Language Service API. TypeScript 7 (the native port) drops that JS-based API surface, so the language server crashes:

Cannot read properties of undefined (reading 'fileExists')
  at AstroCheck.getTsconfig (@astrojs/language-server/dist/check.js:162)

See withastro/roadmap#1321 — full Astro integration can't happen until a new API stabilizes. @astrojs/check (0.9.9) is already latest with no TS7-compatible release.

The fix

astro build itself is unaffected — Astro's own Go/WASM compiler doesn't use the TS compiler API. Only the type-check step broke. So:

  • package.json cibun x tsc --noEmit && bun run build
  • TypeScript bumped ^6.0.3^7.0.0 (+ bun.lock regenerated)

tsc --noEmit uses TS7's native tsc and type-checks all .ts/.tsx files cleanly (verified locally: exit 0).

Limitation

.astro component templates are no longer type-checked in CI (that's exactly what astro check did, and it's the part that broke). .ts code is still fully checked. Re-enable .astro template checking once @astrojs/check ships TS7 support.

astro check / @astrojs/check depends on TypeScript's old Language
Service API, which TypeScript 7 (native port) removed, so it
crashes (getTsconfig: Cannot read properties of undefined
'fileExists'). astro build itself uses Astro's own Go/WASM
compiler and is unaffected.

Swap the CI type-check from 'astro check' to 'tsc --noEmit'
(TS7's native tsc type-checks .ts files correctly). .astro
component templates are no longer type-checked until @astrojs/check
ships TS7 support.
@coderabbitai

coderabbitai Bot commented Jul 12, 2026

Copy link
Copy Markdown

Warning

Review limit reached

@dacrab, you've reached your PR review limit, so we couldn't start this review.

Next review available in: 43 minutes

Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available.
You're only billed for reviews past your plan's rate limits ($0.25/file).

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 3dbb672c-b054-4123-97fc-2c29bedd9ef3

📥 Commits

Reviewing files that changed from the base of the PR and between fc7dbf5 and 2b6aff7.

⛔ Files ignored due to path filters (1)
  • bun.lock is excluded by !**/*.lock
📒 Files selected for processing (1)
  • package.json
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix/ts7-build

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@dacrab
dacrab merged commit 4187b33 into main Jul 12, 2026
6 checks passed
@dacrab
dacrab deleted the fix/ts7-build branch July 12, 2026 08:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant