[pull] master from dotansimha:master - #491
Merged
Merged
Conversation
…ileTs (#4683) (#10992) With `strict: true` (checkpoint 9ff658e), @graphql-codegen/testing had 5 type errors: - TS7016: `common-tags` has no types -> add `@types/common-tags` devDependency. - TS2345: `createSourceFile(..., options.target)` gets `undefined` when the caller's options omit `target` -> fall back to the `languageVersion` the compiler host passes to `getSourceFile`. - TS2345: `getLineAndCharacterOfPosition(diagnostic.start)` gets `number | undefined` -> only take the line/column branch when `start` is set; otherwise report the message alone. The pnpm-lock.yaml regen also re-resolves unrelated optional peers (supports-color) and the patchedDependencies format. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01S6RAG7X9ATb7X3MT4DpkFK eddeee888:oss:issue-fix Co-authored-by: Claude <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot] (v2.0.0-alpha.4)
Can you help keep this open source service alive? 💖 Please sponsor : )