[pull] master from dotansimha:master - #497
Merged
Merged
Conversation
…rationKind 'interface' (#10998) With `declarationKind: 'interface'`, typescript-operations emits a multi-field @OneOf input as `export interface FooInput { ... } | { ... }`, which is invalid TypeScript. The test asserts the expected type alias and currently fails. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01TsaydotU8AFHMT1P4MEfra eddeee888:oss:issue-verify Co-authored-by: Claude <noreply@anthropic.com>
…h declarationKind interface (#10996) (#11001) * fix: generate @OneOf inputs as type alias with declarationKind interface in typescript-operations (#10996) typescript-operations now uses the same declaration-kind rule as the typescript plugin for @OneOf inputs: multi-field inputs are unions and are always emitted as a `type` alias, while single-field inputs keep `declarationKind.input`. The rule lives in the new `getOneOfInputDeclarationKind` helper exported from visitor-plugin-common. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01TsaydotU8AFHMT1P4MEfra eddeee888:oss:issue-fix * refactor: take object param in getOneOfInputDeclarationKind Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01TsaydotU8AFHMT1P4MEfra --------- Co-authored-by: Claude <noreply@anthropic.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot] (v2.0.0-alpha.4)
Can you help keep this open source service alive? 💖 Please sponsor : )