fix(commits): scroll changed-files list in graph commit detail (DAN-79) - #137
Merged
Merged
Conversation
Make .cd-files fill the upper react-resizable-panels slot (height 100%, min-height 0, overflow-y auto) so a multi-file commit can scroll every path without clipping. Mirror the same fill on .cd-diff / .cd-diff-scroll and mark the split handle as horiz so the row-resize hit area matches other vertical splits. Co-authored-by: Daniels <danielss-dev@users.noreply.github.com>
danielss-dev
marked this pull request as ready for review
September 24, 2026 13:10
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Linear
DAN-79 — All Commits graph commit detail: changed-files list cannot scroll.
Problem
The right-hand commit detail panel lists changed files in the upper vertical split (
.cd-filesinside areact-resizable-panelsPanel). That host wasflex-shrink: 0with noheightfill and nooverflow-y, so a commit that touched more files than fit clipped instead of scrolling. Files below the visible rows were unreachable; the header and diff stayed on screen.This is the same
react-resizable-panelstrap indocs/learnings.md: Panel children aredisplay: block, so they needheight: 100%(not leftover flex shrink) plusmin-height: 0andoverflow-y: auto.Fix
Smallest CSS/layout change; no second file-list UI.
.cd-files:height: 100%,min-height: 0,overflow-y: auto; dropflex-shrink: 0.cd-diff/.cd-diff-scroll: fill the lower panel with the same scroll-host pattern as Local Changes (.lc-diff-scroll) so the diff still scrolls independentlyPanelResizeHandleclassrs-handle horizso the row-resize hit area matches other vertical splitsFile-row selection, active styling, header actions, empty/loading states, and Pierre text/image diffs are unchanged.
Tests
No existing suite covers commit-detail chrome, so this PR does not add a layout CSS test. Manual check:
Proof
pnpm --filter ./ui exec tsc --noEmit— passpnpm --filter ./ui test— 99 files / 568 tests pass?view=commits, padded to 49 paths so the list exceeds the upper pane):.cd-filesisoverflow-y: auto,clientHeight190 vsscrollHeight1290,scrollTop1100 after jumping to the last path. Clicking that path sets.cd-file.activeand swaps the diff. Dragging.rs-handle.horiz(9px) grew the file pane 190 → 270px; the list stayed scrollable. Header still showed Checkout / Cherry-pick / Revert.The Linear issue already has the before screenshot (list squeezed, later paths unreachable). After:
Top of the overflowing list (header + split + diff still present):
Commit detail: changed-files list fills the upper pane and overflows
Scrolled to the last path; selecting it updates the diff:
Commit detail: scrolled file list with last path selected
Selecting the original file again restores the text diff:
Commit detail: reselecting the first file restores the Pierre diff
Media is not committed on the branch.
Out of scope
Virtualizing huge file lists, redesigning commit-detail IA, pending/local Changes file lists.
To show artifacts inline, enable in settings.