DAOS-19243 control: update go.mod and protobuf shims#18551
Conversation
Signed-off-by: Tom Nabarro <thomas.nabarro@hpe.com>
Signed-off-by: Tom Nabarro <thomas.nabarro@hpe.com>
Signed-off-by: Tom Nabarro <thomas.nabarro@hpe.com>
Features: control Signed-off-by: Tom Nabarro <thomas.nabarro@hpe.com>
…treplace-rank-erase Features: control Signed-off-by: Tom Nabarro <thomas.nabarro@hpe.com>
Features: control Signed-off-by: Tom Nabarro <thomas.nabarro@hpe.com>
Signed-off-by: Tom Nabarro <thomas.nabarro@hpe.com>
Signed-off-by: Tom Nabarro <thomas.nabarro@hpe.com>
…treplace-rank-erase Signed-off-by: Tom Nabarro <thomas.nabarro@hpe.com>
Signed-off-by: Tom Nabarro <thomas.nabarro@hpe.com>
|
Ticket title is 'Keep go.mod and protobuf go generated file contents up-to-date' |
|
Test stage Build on EL 9 completed with status FAILURE. https://jenkins-3.daos.hpc.amslabs.hpecorp.net//job/daos-stack/job/daos/view/change-requests/job/PR-18551/1/execution/node/269/log |
|
Test stage Build on EL 8 completed with status FAILURE. https://jenkins-3.daos.hpc.amslabs.hpecorp.net//job/daos-stack/job/daos/view/change-requests/job/PR-18551/1/execution/node/277/log |
|
Test stage Build on Leap 15 completed with status FAILURE. https://jenkins-3.daos.hpc.amslabs.hpecorp.net//job/daos-stack/job/daos/view/change-requests/job/PR-18551/1/execution/node/341/log |
|
Test stage Build on EL 9 completed with status FAILURE. https://jenkins-3.daos.hpc.amslabs.hpecorp.net//job/daos-stack/job/daos/view/change-requests/job/PR-18551/2/execution/node/247/log |
|
Test stage Build on EL 8 completed with status FAILURE. https://jenkins-3.daos.hpc.amslabs.hpecorp.net//job/daos-stack/job/daos/view/change-requests/job/PR-18551/2/execution/node/295/log |
|
Test stage Build on Leap 15 completed with status FAILURE. https://jenkins-3.daos.hpc.amslabs.hpecorp.net//job/daos-stack/job/daos/view/change-requests/job/PR-18551/2/execution/node/341/log |
kjacque
left a comment
kjacque
left a comment
There was a problem hiding this comment.
Looks like you may need to rebase against master now that the parent branch has landed.
| // Scons uses this file to extract the minimum version. | ||
| go 1.21 | ||
| toolchain go1.24.0 | ||
| go 1.24.0 |
There was a problem hiding this comment.
Generally we've avoided bumping the Go requirement since OSes may package (or not) outdated Go versions. The toolchain option allows any Go version > 1.21 to download the appropriate version of the Go compiler.
Any reason the existing toolchain didn't work anymore?
There was a problem hiding this comment.
this seemed to be updated automatically when I ran one of the go mod commands, happy to leave it as is
There was a problem hiding this comment.
don't we need the update for some of the vendor change?
There was a problem hiding this comment.
Maybe the toolchain directive needs an update to the specific dot-version, but we should leave the go version alone. The toolchain stuff is intended to make the GHA containers work to compile DAOS--they basically have to use their distro versions of go, but all of them are at 1.21 or greater.
3 participants
Steps for the author:
After all prior steps are complete: