Repository navigation
V51: a store that fits on a screen - #113
Merged
Merged
Conversation
No behaviour change: the 906 existing unit tests and 97 Chromium e2e tests pass unchanged. - lab-store.ts 1050 -> 530 lines; the onmessage if/else chain becomes a typed dispatch table (store/responses.ts), one entry per response kind - state, V47 fence and threshold artifact moved to store/ - v35..v40 test files renamed after what they pin - numbersOf / missingRatio / sharesOverEdges merged into quality/distribution.ts (quantile functions kept apart: 0 vs NaN on []) - responses.test.ts pins each state-only handler; it also restores the function-coverage floor the branch-to-function move had dipped - PLAN/CHANGELOG: V51 delivered, version 1.51.0 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01ELAjHYDyxa5zbbdcke1bMA
dapiced
marked this pull request as ready for review
October 9, 2026 10:13
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Refactor with no intended behaviour change. The 906 existing unit tests and 97 Chromium e2e tests pass unchanged before and after.
lab-store.ts, 1 050 linesonmessage: a 250-lineif / else ifchainstore/responses.ts: a dispatch table typed as a mapped type overWorkerResponse['kind']store/state.ts,store/fence.ts,store/artifacts.tsv35…v40honest-evaluation,imbalance-ensemble,knn-and-helpers,french-numbers,column-recipe,quality-scorenumbersOf/missingRatio/ shares duplicated indrift.tsandreference.tsquality/distribution.tsDispatch table
elseused to treat any unlisted kind aserrorwithout saying so.Not done
send, so slicing them would move code without separating anything.v35andv36: renamed, not split, to keep the change mechanical.Coverage gate (V49) fired, and the fix was a test, not a lower floor
store/responses.test.ts: 17 cases that pin which fields each state-only response writes. That is also the check a moved body needs.Test plan
lint,typecheck,format:check,buildnpm run test:coverage: 923 passed (906 unchanged + 17 new), all floors met🤖 Generated with Claude Code
https://claude.ai/code/session_01ELAjHYDyxa5zbbdcke1bMA
Generated by Claude Code