Repository navigation
V52.2: vite-plugin-pwa 2, service worker output unchanged - #116
Merged
Merged
Conversation
- vite-plugin-pwa 1.3.0 -> 2.0.0 (release notes: Node 20.19 floor, assets-generator 2 peer; neither affects this project) - same build compared on 1.3.0 and 2.0.0: 98 precache entries and 5675.73 KiB in both, same URLs, sw.js identical modulo revision hashes, same workbox runtime file, byte-identical web manifest - offline e2e and update-prompt unit tests pass unchanged - PLAN/CHANGELOG: V52.2 delivered Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01ELAjHYDyxa5zbbdcke1bMA
dapiced
marked this pull request as ready for review
October 9, 2026 11:54
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Second of V52's three major upgrades.
Release notes for 2.0.0. They list two consumer-facing changes:
@vite-pwa/assets-generator2 is now accepted as a peer. LabML does not use it.Measured, not assumed. A broken service worker only shows up later, in visitors' browsers. So I built the same commit with 1.3.0 and with 2.0.0 and compared what each build produces:
sw.jsworkbox-2ff6bd68.jsworkbox-2ff6bd68.jsmanifest.webmanifestNo PWA option changes. README and site docs do not mention the plugin version, so they are unchanged.
PLAN.mdhas a V52.2 row, andCHANGELOG.mdis regenerated.Test plan
e2e/offline.spec.ts: the whole lab works offline after the first visit (Chromium)e2e/smoke.spec.ts,e2e/routing.spec.tssrc/appunit tests, including the update prompt (ReloadPrompt)lint,typecheck,format:check,build,npm auditgates🤖 Generated with Claude Code
https://claude.ai/code/session_01ELAjHYDyxa5zbbdcke1bMA
Generated by Claude Code