Rewrite GitHub blob image URLs in README to raw.githubusercontent.com - #9178
Closed
Yihun-Alemayehu wants to merge 1 commit into
Closed
Rewrite GitHub blob image URLs in README to raw.githubusercontent.com#9178Yihun-Alemayehu wants to merge 1 commit into
Yihun-Alemayehu wants to merge 1 commit into
Conversation
Fixes dart-lang#9156. Added rewriteGithubImagesInMarkdown helper and test.
Collaborator
|
Closing this as the underlying issue has been fixed with the image proxy work we have done earlier this year. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR addresses issue #9156
by rewriting GitHub blob image URLs in package README files to use raw.githubusercontent.com, ensuring that images render correctly on
pub.dev.Changes:
known_templates.dartto convert GitHub blob links to raw URLs.known_templates_test.dartwith a new test to verify that image URLs are rewritten correctly.Test Plan:
Fixes: #9156