fix: default BP_AUTOCALIBRATE to true (restore v5 behaviour) - #54
Merged
Conversation
v5 shipped with autocalibration ON by default. The v6 rewrite flipped it to false without a documented rationale. Restore true: - The algorithm is conservative (only adjusts when accumulated bias exceeds MAX_Y/2 over ~10 frames); for accurate pointers (mouse/touch) the random up/down noise cancels and the threshold is never reached — it is effectively a no-op. - Eye-tracker users (common on Windows/Tobii) need continuous calibration; having it off by default means a clinician must know to find and toggle it. - Matches v5, where MacKay's team chose true. Signed-off-by: will wade <willwade@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Restores
BP_AUTOCALIBRATEtotrue(on by default), matching v5. The v6 rewrite had flipped it tofalsewithout a documented rationale.Why on by default:
MAX_Y/2over ~10 frames; for mouse/touch, random noise cancels and the threshold is never reached — it is effectively a no-op.true; the flip was undocumented.Changes:
Parameters.cppdefault valuefalse → true;settings_manifest.json"default": false → true.