-
Notifications
You must be signed in to change notification settings - Fork 59
feat(swift-sdk)!: freeze schemas only after App Store publication #4818
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
20 commits
Select commit
Hold shift + click to select a range
04ffc31
feat(swift-sdk)!: freeze persistence schemas after App Store publication
llbartekll 1598336
fix(swift-sdk): fold upstream V5 key limits into working V2
llbartekll 6eb0ee3
fix(swift-sdk): strengthen schema release validation
llbartekll 10e1062
fix(swift-sdk): isolate release generation and retain source history
llbartekll fe0da99
fix(swift-sdk): validate source tags during freeze dry runs
llbartekll 6faa054
chore(swift-sdk): resolve release-freeze merge conflicts
llbartekll 7de890a
fix(swift-sdk): bridge legacy unversioned stores into V2
llbartekll e1bf24d
fix(swift-sdk): limit legacy detection and locking to bridge stores
llbartekll 2fe5826
fix(swift-sdk): recover migrations without scratch copies
llbartekll 9597c0f
fix(swift-sdk): reclaim migration backups after a successful reopen
llbartekll 27b943a
fix(swift-sdk): verify the migrated SQLite journal mode
llbartekll 852d825
fix(swift-sdk): open and migrate stores on a dedicated queue
llbartekll 8894142
fix(swift-sdk): handle unreadable release API responses
llbartekll a800920
fix(swift-sdk): check migration storage and clarify recovery failures
llbartekll bf50e1a
fix(swift-sdk): reclaim abandoned migration attempts under lock
llbartekll 77f8c29
fix(swift-sdk): order freeze pull requests by latest attempt
llbartekll 41642ca
fix(swift-sdk): validate stored value dependencies before freezing
llbartekll f882160
fix(swift-sdk): reconcile merged releases before closed pull requests
llbartekll 209dff2
fix(swift-sdk): discard completed migration snapshots during wallet d…
llbartekll 1645f9c
fix(ci): support spaced paths on the Swift SDK runner
llbartekll File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,62 @@ | ||
| name: Freeze SwiftData App Store release | ||
|
|
||
| on: | ||
| workflow_dispatch: | ||
| inputs: | ||
| release_id: | ||
| description: App Store version ID recorded by the iOS publication monitor | ||
| required: true | ||
| type: string | ||
| data_commit: | ||
| description: Full commit on dashwallet-ios/schema-release-data containing the publication proof | ||
| required: true | ||
| type: string | ||
| dry_run: | ||
| description: Validate and generate without committing, pushing or opening a PR | ||
| default: false | ||
| type: boolean | ||
|
|
||
| permissions: | ||
| contents: read | ||
|
|
||
| # Different releases may share a schema and therefore an automation branch. | ||
| concurrency: | ||
| group: swift-sdk-appstore-schema-freeze | ||
| cancel-in-progress: false | ||
|
|
||
| jobs: | ||
| freeze: | ||
| if: github.repository == 'dashpay/platform' | ||
| runs-on: ubuntu-24.04 | ||
| timeout-minutes: 20 | ||
| steps: | ||
| - name: Checkout reviewed worker | ||
| uses: actions/checkout@v4 | ||
| with: | ||
| ref: v4.2-dev | ||
| path: platform | ||
| # Include immutable swift-schema-source/* tags and their history. | ||
| fetch-depth: 0 | ||
| persist-credentials: false | ||
| - name: Checkout publication records from the fixed iOS repository | ||
| uses: actions/checkout@v4 | ||
| with: | ||
| repository: dashpay/dashwallet-ios | ||
| ref: schema-release-data | ||
| path: release-data | ||
| fetch-depth: 0 | ||
| token: ${{ secrets.SCHEMA_RELEASE_TOKEN }} | ||
| persist-credentials: false | ||
| - name: Validate publication and prepare draft snapshot PR | ||
| env: | ||
| SCHEMA_RELEASE_TOKEN: ${{ secrets.SCHEMA_RELEASE_TOKEN }} | ||
| RELEASE_ID: ${{ inputs.release_id }} | ||
| DATA_COMMIT: ${{ inputs.data_commit }} | ||
| DRY_RUN: ${{ inputs.dry_run }} | ||
| working-directory: platform | ||
| shell: bash | ||
| run: | | ||
| set -euo pipefail | ||
| args=(--release-id "$RELEASE_ID" --data-commit "$DATA_COMMIT" --data-repo ../release-data) | ||
| if [[ "$DRY_RUN" == true ]]; then args+=(--dry-run); fi | ||
| python3 -I packages/swift-sdk/scripts/freeze_appstore_release.py "${args[@]}" |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.