fix(dpp): refuse a document type schema that is not an object as an invalid contract structure again

[QuantumExplorer]

Issue being fixed or feature implemented

Since #4864 merged, two drive-abci tests are red on v4.2-dev:

FAIL drive-abci execution::validation::state_transition::state_transitions::data_contract_create::state::v0::tests::transform_into_action_v0::should_return_invalid_result_if_data_contract_is_not_valid
FAIL drive-abci execution::validation::state_transition::state_transitions::data_contract_create::state::v0::tests::validate_state_v0::should_return_invalid_result_when_transform_into_action_failed_latest
assertion failed: `[BasicError(ValueError(ValueError { value_error: "structure error: value is not a map" }))]` does not match `[ConsensusError::BasicError(BasicError::ContractError(DataContractError::InvalidContractStructure(message)))]`

Both inject null as a document type schema and expect the contract to be refused as an InvalidContractStructure. #4864 added parse_can_be_deleted_by_moderators_for_keyword, which reads the canBeDeletedByModeratorsFor window with get_optional_integer directly on the schema Value. That helper converts the value to a map first, so on a schema that is not an object it fails with the raw platform-value error. The generation-3 parser reads every doctype-level keyword before its "document schema must be an object" check, so that raw error replaced the structure refusal. Every sibling reader in that block (indexOnly, canBeDeletedByModerators, immutable, action fees) already tolerates a non-object schema.

No base-branch run executed the Rust workspace tests after the merge (skipped, cancelled, or tripped the dirty-runner [patch] guard), so #4868 was the first PR to show it.

What was done?

• parse_can_be_deleted_by_moderators_for_keyword returns None for a schema that is not an object and reads the window through inner_optional_integer_value on the map otherwise, like its siblings.
• A dpp test pins that a null, string or array schema is refused as an InvalidContractStructure on both the validated and the stored path. It fails on the base branch with the exact error above.

No consensus change: a contract whose document type schema is not an object was refused before and is refused now; only the error it is refused with is restored.

How Has This Been Tested?

Locally:

• cargo test -p dpp --lib -- try_from_schema: 245 passed (including the 17 moderators_delete_tests, one new).
• The new test run against the base branch's common/mod.rs: fails with ValueError("structure error: value is not a map").
• cargo test -p drive-abci --lib -- data_contract_create::state::v0::tests: 7 passed (the two red tests included).
• cargo clippy -p dpp --all-targets -- -D warnings clean; cargo fmt --all --check clean.

Breaking Changes

None.

Checklist:

• I have performed a self-review of my own code
• I have commented my code, particularly in hard-to-understand areas
• I have added or updated relevant unit/integration/functional/e2e tests
• I have added "!" to the title and described breaking changes in the corresponding section if my code contains any
• I have made corresponding changes to the documentation if needed

For repository code-owners and collaborators only

• I have assigned this pull request to a milestone

🤖 Generated with Claude Code

[coderabbitai]

Warning

Review limit reached

Next included review available in 31 minutes.

Check out review usage here.

View limit details

Limit details: You’ve used the included review currently available.

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

Learn how review limits work.

Review configuration:

⚙️ Run configuration

Configuration used: Repository: dashpay/platform/.coderabbit.yaml

Review profile: CHILL

Plan: Advanced

Run ID: 2f4c746d-8c3b-4f17-a153-9d9f98df61e7

📥 Commits

Reviewing files that changed from the base of the PR and between b5a93f5 and ca0c611.

📒 Files selected for processing (2)

• packages/rs-dpp/src/data_contract/document_type/class_methods/try_from_schema/common/mod.rs
• packages/rs-dpp/src/data_contract/document_type/class_methods/try_from_schema/v3/moderators_delete_tests.rs

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}

[github-actions]

PR Hygiene

State: waiting-bots · commit ca0c6117de21711ac6386fa32bf9e65deabc4d8d

• coderabbitai has not reported for the current head
• thepastaclaw has not reported for the current head

Self-review is an author attestation that you have read the diff:
/self-reviewed — covers everything pushed so far; post it again after a new push.
/skip-bots — proceed without the bots that have not reported; anyone with write access may, and the report says who did.

This check passes when the policy is satisfied; the repository decides whether merging requires it.

[thepastaclaw]

⚠️ DEGRADED — Queued for automated review — 3rd in line, estimated start in ~1.3 h (commit ca0c611)
Estimated review time once started: ~55 min (two-phase automated review; median of recent runs).
The primary review models are currently out of quota; this review will run on stand-in models and be marked as degraded.

• Request priority review — click to move this review to the front of the queue.

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 86.69%. Comparing base (54ed7a0) to head (ca0c611).
⚠️ Report is 5 commits behind head on v4.2-dev.

Additional details and impacted files

@@             Coverage Diff              @@
##           v4.2-dev    #4870      +/-   ##
============================================
+ Coverage     86.42%   86.69%   +0.26%     
============================================
  Files          3122     3122              
  Lines        411564   411724     +160     
============================================
+ Hits         355694   356934    +1240     
+ Misses        55870    54790    -1080     

Components	Coverage Δ
dpp	86.06% <100.00%> (+0.55%)	⬆️
drive	86.01% <ø> (+0.23%)	⬆️
drive-abci	90.07% <100.00%> (+0.10%)	⬆️
sdk	∅ <ø> (∅)
dapi-client	∅ <ø> (∅)
platform-version	∅ <ø> (∅)
platform-value	92.97% <ø> (ø)
platform-wallet	∅ <ø> (∅)
drive-proof-verifier	33.70% <ø> (+0.08%)	⬆️

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.