Skip to content

refactor(dpp): share one is_transient helper for lookup sources and encryptedFor #4949

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
QuantumExplorer merged 1 commit into from
Sep 23, 2026
Merged

refactor(dpp): share one is_transient helper for lookup sources and encryptedFor #4949

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 1 addition & 13 deletions packages/rs-dpp/src/data_contract/document_type/property/reference_lookup.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@

use crate::data_contract::document_type::accessors::DocumentTypeV0Getters;
use crate::data_contract::document_type::accessors::DocumentTypeV2Getters;
use crate::data_contract::document_type::property::DocumentPropertyType;
use crate::data_contract::document_type::property::{is_transient, DocumentPropertyType};
use crate::data_contract::document_type::DocumentTypeRef;
use crate::data_contract::errors::DataContractError;
use crate::document::property_names::{
Expand Down Expand Up @@ -408,18 +408,6 @@ fn owner_can_change(document_type: DocumentTypeRef) -> bool {
|| document_type.trade_mode() != TradeMode::None
}

/// Whether the property at `path` of `document_type`, or an object around it,
/// is transient: either way its value is never stored. `transient_fields()`
/// holds the paths as declared, so a leaf of a transient object is found only
/// through the object's path, a prefix of its own.
fn is_transient(document_type: DocumentTypeRef, path: &str) -> bool {
let transient_fields = document_type.transient_fields();
path.match_indices('.')
.map(|(end, _)| &path[..end])
.chain(std::iter::once(path))
.any(|prefix| transient_fields.contains(prefix))
}

/// The kind of value an index property of `document_type` holds: a system
/// property's fixed type, or the schema property's. `None` when the name is
/// neither.
Expand Down
Loading