feat(platform)!: masternode votes cost 80% less (PV14)

packages/rs-drive-abci/tests/strategy_tests/test_cases/voting_tests.rs

@@ -1748,6 +1748,38 @@ mod tests {
     #[stack_size(STACK_SIZE)]
     #[test]
     async fn run_chain_with_voting_after_won_by_identity_with_specialized_funds_distribution() {
+        // A vote costs 2_000_000 from protocol version 14.
+        // We did 5 votes in this epoch, and from protocol version 14 each contested document
+        // contributes 0.1 DASH (10_000_000_000) to the vote resolution fund instead of 0.2
+        // DASH, so the two contenders funded 20_000_000_000, of which 19 votes cost 38_000_000
+        // and 19_962_000_000 was left over when the vote finished.
+        // So we basically have 19_962_000_000 + 10_000_000
+        run_chain_with_voting_after_won_by_identity_with_specialized_funds_distribution_at_protocol_version(
+            PlatformVersion::latest().protocol_version,
+            19_972_000_000,
+        )
+        .await;
+    }
+
+    /// PROTOCOL_VERSION_13: a vote costs 10_000_000 and each contested document contributes
+    /// 0.2 DASH, so the two contenders funded 40_000_000_000, of which 19 votes cost
+    /// 190_000_000 and 39_810_000_000 was left over; with the 5 votes of the epoch that is
+    /// 39_810_000_000 + 50_000_000.
+    #[stack_size(STACK_SIZE)]
+    #[test]
+    async fn run_chain_with_voting_after_won_by_identity_with_specialized_funds_distribution_protocol_version_13(
+    ) {
+        run_chain_with_voting_after_won_by_identity_with_specialized_funds_distribution_at_protocol_version(
+            13,
+            39_860_000_000,
+        )
+        .await;
+    }
+
+    async fn run_chain_with_voting_after_won_by_identity_with_specialized_funds_distribution_at_protocol_version(
+        protocol_version: dpp::version::ProtocolVersion,
+        expected_processing_fees: u64,
+    ) {
         // In this test we try to insert two state transitions with the same unique index
         // We use the DPNS contract, and we insert two documents both with the same "name"
         // This is a common scenario we should see quite often
@@ -1765,9 +1797,21 @@ mod tests {
         };
         let mut platform = TestPlatformBuilder::new()
             .with_config(config.clone())
+            .with_initial_protocol_version(protocol_version)
             .build_with_mock_rpc();
 
-        let platform_version = PlatformVersion::latest();
+        let platform_version = PlatformVersion::get(protocol_version)
+            .expect("expected platform version for the requested protocol_version");
+        // An older protocol version is held by the proposers the first run sets up, whose
+        // versions the continued run carries on; the latest needs no holding
+        let upgrading_info =
+            (protocol_version != PlatformVersion::latest().protocol_version).then(|| {
+                UpgradingInfo {
+                    current_protocol_version: protocol_version,
+                    proposed_protocol_versions_with_weight: vec![(protocol_version, 1)],
+                    upgrade_three_quarters_life: 0.2,
+                }
+            });
 
         let mut rng = StdRng::seed_from_u64(567);
 
@@ -1890,7 +1934,7 @@ mod tests {
             extra_normal_mns: 0,
             validator_quorum_count: 24,
             chain_lock_quorum_count: 24,
-            upgrading_info: None,
+            upgrading_info,
             proposer_strategy: Default::default(),
             rotate_quorums: false,
             failure_testing: None,
@@ -2145,14 +2189,7 @@ mod tests {
             )
             .expect("expected to get processing fees made in epoch");
 
-        // A vote costs 10_000_000
-        // We did 5 votes in this epoch,
-        // From protocol version 14 each contested document contributes 0.1 DASH
-        // (10_000_000_000) to the vote resolution fund instead of 0.2 DASH, so the two
-        // contenders funded 20_000_000_000, of which 19 votes cost 190_000_000 and
-        // 19_810_000_000 was left over when the vote finished.
-        // So we basically have 19_810_000_000 + 50_000_000
-        assert_eq!(processing_fees, 19_860_000_000);
+        assert_eq!(processing_fees, expected_processing_fees);
     }
 
     #[stack_size(STACK_SIZE)]

packages/rs-platform-version/src/version/fee/vote_resolution_fund_fees/v2.rs

@@ -4,5 +4,7 @@ use crate::version::fee::vote_resolution_fund_fees::VoteResolutionFundFees;
 /// Introduced in protocol version 14 (4.2).
 pub const VOTE_RESOLUTION_FUND_FEES_VERSION2: VoteResolutionFundFees = VoteResolutionFundFees {
     contested_document_vote_resolution_fund_required_amount: 10_000_000_000, // 0.1 DASH
+    // A fifth of the 0.0001 DASH before: a contest's fund covers five times the votes
+    contested_document_single_vote_cost: 2_000_000, // 0.00002 DASH
     ..VOTE_RESOLUTION_FUND_FEES_VERSION1
 };

packages/rs-platform-version/src/version/v14.rs

@@ -1092,7 +1092,7 @@ pub const PLATFORM_V14: PlatformVersion = PlatformVersion {
     // The TTL ephemeral-bytes rate (270 credits/byte to processing) rides
     // the shared storage table; it is dead below v14 (the `ttl` grammar
     // does not parse), so no table fork is needed.
-    fee_version: FEE_VERSION3, // changed: contested document contribution reduced to 0.1 DASH; registration surcharge for once-per-identity token distributions
+    fee_version: FEE_VERSION3, // changed: contested document contribution reduced to 0.1 DASH; masternode vote cost reduced to 0.00002 DASH; registration surcharge for once-per-identity token distributions
     system_limits: SYSTEM_LIMITS_V4, // changed: daily withdrawal limit becomes 15% of the total credits a day ago + time-range overlap-factor cap (24) + time-range TTL cap (1 week) and per-write drop cap (32) + GroveDB proof envelope floor (V1); max_contract_moderators, max_contract_suspension_until, max_contract_moderation_reason_length, max_contract_warnings_per_identity, max_contract_moderation_reason_documents and contract_document_restore_window_ms (a week)
     consensus: ConsensusVersions {
         tenderdash_consensus_version: 1,
@@ -1116,12 +1116,24 @@ mod tests {
                 20_000_000_000,
                 "protocol {protocol_version} must preserve the 0.2 DASH contribution"
             );
+            assert_eq!(
+                version
+                    .fee_version
+                    .vote_resolution_fund_fees
+                    .contested_document_single_vote_cost,
+                10_000_000,
+                "protocol {protocol_version} must preserve the 0.0001 DASH vote"
+            );
         }
 
         let mut expected_fees = PLATFORM_V13.fee_version.clone();
         expected_fees
             .vote_resolution_fund_fees
             .contested_document_vote_resolution_fund_required_amount = 10_000_000_000;
+        // A masternode vote costs a fifth of what it did: 0.00002 DASH from the contest's fund
+        expected_fees
+            .vote_resolution_fund_fees
+            .contested_document_single_vote_cost = 2_000_000;
         // The once-per-identity token distribution exists from protocol version 14 on, and a
         // token that uses it pays the surcharge of the other distribution kinds.
         assert_eq!(