refactor(dpp): remove the empty moderation charter validation step

[QuantumExplorer]

Issue being fixed or feature implemented

Once #4957 (maxBytes) and #4962 (propertyConstraints) moved the last proposal rules into the moderation charters contract's schema, the charter-specific validation step was left with nothing to check:

• SubmittedCharter::validate dispatched on dpp.validation.data_contract.validate_moderation_charter to a v0 that always returned an empty, valid result.
• validate_submitted_charter read the proposal's properties, then called that empty step.
• Error 11001 (ModerationCharterRewardSplitNotOneHundredError) is never produced: the reward split is held to 100 by the contract's rewardSplitIsWhole rule (10422).

Nothing outside rs-dpp's own tests called validate_submitted_charter or SubmittedCharter::validate. Drive ABCI reads a seated charter with ElectedCharter::from_document_properties and the moderators share straight from the stored proposal.

What was done?

• Removed SubmittedCharter::validate, its moderation_charter/v0 module and validate_submitted_charter from rs-dpp.
• Removed the validate_moderation_charter field from DataContractValidationVersions and from DPP_VALIDATION_VERSIONS_V1, V2, V3 (all None) and V5 (Some(0)).
• Error 11001 stays. BasicError is bincode-encoded positionally and two variants follow it (DocumentPropertyMaxBytesExceededError at 198, DocumentPropertyConstraintViolatedError at 199), so removing it would shift their wire discriminants. Its doc comment now says no check produces it.
• Updated the docs that named the removed function: the module doc, protocol version 14 items 37 and 39 in v14.rs, and docs/protocol/moderation-charters.md.
• Removed first_basic_error from the charter tests; nothing had called it since the reward split and description checks moved to the schema.

Before:

let proposal = validate_submitted_charter(document.properties(), platform_version)?
    .into_data()?;

After (the same result, since the validation step checked nothing):

let proposal = SubmittedCharter::from_document_properties(document.properties())
    .into_data()?;

How Has This Been Tested?

• cargo test -p dpp --features moderation-charters-contract,validation --lib -- moderation_charter: 24 passed. The tests that only exercised the empty step (should_accept_a_valid_proposal, which duplicated the round trip, and should_refuse_to_validate_below_protocol_version_14) are removed; should_accept_a_proposal_without_reasons became should_read_a_proposal_without_reasons.
• cargo clippy -p dpp -p platform-version --all-features --all-targets -- -D warnings: clean.
• No other crate names the removed items (git grep across the repository).

Breaking Changes

None for consensus: the removed step validated nothing, and nothing on a block-execution path called it. validate_submitted_charter and SubmittedCharter::validate leave rs-dpp's public API; neither shipped in a release, and no SDK used them.

In-place changes to shipped generations

DPP_VALIDATION_VERSIONS_V1, V2 and V3 lose the validate_moderation_charter: None entry. No code read that field at those versions (the only reader, SubmittedCharter::validate, was PV14 only and is removed), so the edit cannot change consensus there. V5 is protocol version 14, which is unreleased.

Checklist:

• I have performed a self-review of my own code
• I have commented my code, particularly in hard-to-understand areas
• I have added or updated relevant unit/integration/functional/e2e tests
• I have added "!" to the title and described breaking changes in the corresponding section if my code contains any
• I have made corresponding changes to the documentation if needed
• If I added or changed GroveDB structure, I described it in the area's structure.rs, regenerated grovedb-structure.json, and checked the structure viewer link posted on this pull request

For repository code-owners and collaborators only

• I have assigned this pull request to a milestone

🤖 Generated with Claude Code

PR Hygiene · 6f1ef28

• Bots — coderabbitai not yet · thepastaclaw not yet — /skip-bots proceeds without the ones not yet reported
• Self-review — post /self-reviewed once the bots are done
• Within your 5 open PRs
• Build running
• Approvals — you own every area touched; none needed

When every box is checked the PR Hygiene check passes and this can merge.

[coderabbitai]

Warning

Review limit reached

Next included review available in 11 minutes.

Check out review usage here.

View limit details

Limit details: You’ve used the included review currently available.

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

Learn how review limits work.

Review configuration:

⚙️ Run configuration

Configuration used: Repository: dashpay/platform/.coderabbit.yaml

Review profile: CHILL

Plan: Advanced

Run ID: 3522fde4-2220-4404-a87e-12274083e132

📥 Commits

Reviewing files that changed from the base of the PR and between 68aa586 and 6f1ef28.

📒 Files selected for processing (12)

• docs/protocol/moderation-charters.md
• packages/rs-dpp/src/errors/consensus/basic/moderation_charter/moderation_charter_reward_split_not_one_hundred_error.rs
• packages/rs-dpp/src/moderation_charter/mod.rs
• packages/rs-dpp/src/moderation_charter/tests.rs
• packages/rs-dpp/src/moderation_charter/v0/mod.rs
• packages/rs-dpp/src/system_data_contracts.rs
• packages/rs-platform-version/src/version/dpp_versions/dpp_validation_versions/mod.rs
• packages/rs-platform-version/src/version/dpp_versions/dpp_validation_versions/v1.rs
• packages/rs-platform-version/src/version/dpp_versions/dpp_validation_versions/v2.rs
• packages/rs-platform-version/src/version/dpp_versions/dpp_validation_versions/v3.rs
• packages/rs-platform-version/src/version/dpp_versions/dpp_validation_versions/v5.rs
• packages/rs-platform-version/src/version/v14.rs

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}

[thepastaclaw]

🕓 Queued for automated review — 5th in line, estimated start in ~1.7 h (commit 6f1ef28)
Estimated review time once started: ~40 min (two-phase automated review; median of recent runs).

• Request priority review — click to move this review to the front of the queue.