Skip to content

ci: tolerate optional S3 cache export outages on v5.0-dev - #5186

Open
ktechmidas wants to merge 1 commit into
v6.0-devfrom
ci/v50-optional-cache-rollout-20260929
Open

ktechmidas wants to merge 1 commit into
v6.0-devfrom
ci/v50-optional-cache-rollout-20260929

Conversation

@ktechmidas

@ktechmidas ktechmidas commented Sep 29, 2026 •

Copy link
Copy Markdown
Collaborator

HOLD — superseded by the concurrent v5 rollout #5185

infraclaw identified that both files in this cache-only PR are already byte-identical parts of #5185 at d8b1d0419024dac33429aab7c9626c34ce35e9ce. Do not merge this duplicate PR. This overlap was my coordination mistake; #5185 is the v5 source-rollout path.

The already-running NPM validation run36551436777/job109350411407 is being left untouched. After it reaches a terminal result, the existing maintenance follow-up will record that result and close only this duplicate PR without merging or deleting its branch. No contributor PR, worker or CI run is being interrupted.


Issue being fixed or feature implemented

Backport the merged CI-only optional S3 cache-export repair #5165 to v5.0-dev. An unavailable optimization must not invalidate a successful build or image publication.

What was done?

  • Exact two-file backport from merge 5f4ab6c2f98cf3c01f35a5ffa81f61957a4cd50f onto target ad7874352c2a191ca25b6b87be12c487696758f5.
  • Tolerate only Docker layer-cache export failures (ignore-error=true). Imports, architecture prefixes and explicit shared-writer opt-in remain unchanged.
  • Keep compilation, application tests and registry publication failures fatal. No runner recipe, routing, credentials, access policy or application source changes.
  • Separate infrastructure branch: no contributor PR was pushed, rebased, retargeted or rerun, and no live worker was changed.

How Has This Been Tested?

  • Three executable Node-backed cache-action regression tests pass on this exact head.
  • The same tests against the unmodified target action reproduce two expected failures.
  • YAML/Python syntax and git diff --check pass; every non-.github root-tree object equals the exact target.
  • CI and independent reviews remain required; local tests are not a claim of target adoption or real runner execution.

Author recovery guidance (after merge only)

If your exact failed step is optional S3 cache export, update your own PR from v5.0-dev after this repair lands and let the new head start CI. Re-running an unchanged old head does not adopt this action repair. This does not fix Android/sudo setup faults or application/test failures; those remain separate.

Breaking Changes

None. Existing image eligibility and legacy runner capacity are preserved.

Checklist

  • I have performed a self-review of my own code
  • I have commented non-obvious behavior
  • I have added relevant CI unit regressions
  • Independent reviews and protected merge gates complete

Authored and operated by infraclaw under latte's scoped CI authorization. Protected transport account attribution is not its owner's personal review or approval. No bypass or self-approval is requested.

PR Hygiene · 843052c

  • Bots — coderabbitai skipped after the window · thepastaclaw ✓
  • Self-review — post /self-reviewed
  • Within your 5 open PRs
  • Build green
  • Approvals — you own every area touched; none needed

When every box is checked the PR Hygiene check passes and this can merge.

Exact two-file backport of reviewed Platform #5165 (5f4ab6c). Preserve imports, build/publication failures, shared-writer opt-in, runner recipes and all application tests.
@coderabbitai

coderabbitai Bot commented Sep 29, 2026

Copy link
Copy Markdown
Contributor

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository: dashpay/platform/.coderabbit.yaml

Review profile: CHILL

Plan: Advanced

Run ID: 433dd3fe-c9ef-49e9-a731-2902c84f02ec

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@github-actions github-actions Bot added this to the v5.0.0 milestone Sep 29, 2026
@github-actions github-actions Bot added the waiting-bots Waiting for the review bots to report on this head label Sep 29, 2026
@thepastaclaw

thepastaclaw commented Sep 29, 2026 •

Copy link
Copy Markdown
Collaborator

✅ Final review complete — no blockers (commit 843052c) · triage: low

@thepastaclaw thepastaclaw left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Final validation — Phase 1 + Phase 2

Verified the complete diff at head 843052c: both changed files match the upstream repair, and ignore-error=true is confined to S3 cache exports without changing imports, architecture prefixes, shared-writer opt-in, or build and registry-publication failure handling. All 36 CI-script tests, including the three new cache regressions, and git diff --check passed; no actionable defects were found, though these checks do not demonstrate live S3-outage behavior. This code approval does not override the PR description's explicit hold and instruction not to merge this duplicate PR.

Review provenance

Source: reviewer 1: glm-5.3-flash (agent: phase1-reviewer, role: architecture-layering); reviewer 2: gpt-6-astra (agent: phase2-reviewer, role: general); reviewer 3: gpt-6-astra (agent: phase2-reviewer, role: architecture-layering); final verifier: gpt-6-astra (agent: astra-verifier, role: final-verifier)

  • Triage: low by gpt-6-astra (effort low) — The diff is a small, contained CI behavior change that tolerates optional S3 cache export failures with targeted regression tests, without changing application logic or any critical surface.
  • Phase 1 reviewers: glm-5.3-flash — architecture-layering (completed, effort high); agent phase1-reviewer
  • Phase 1 model: glm-5.3-flash — zai quota: 5h 80% left, weekly 86% left; passed over gemini-3.8-flash-high (antigravity below 15% reserve: weekly 13% left, 5h 100% left)
  • Fresh verifier: gpt-6-astra — final-verifier; agent astra-verifier
  • Phase 2 reviewers: gpt-6-astra — general (completed, effort medium); agent phase2-reviewer, gpt-6-astra — architecture-layering (completed, effort medium); agent phase2-reviewer

@github-actions

Copy link
Copy Markdown
Contributor

@coderabbitai review

No review for 843052c2 yet, so PR Hygiene is asking once. If nothing arrives, the requirement is dropped for this commit and the pull request is labelled bot-review-skipped.

@github-actions github-actions Bot added waiting-self-review Waiting for the author to post /self-reviewed bot-review-skipped A required review bot did not report; it was skipped by the window or by a person. and removed waiting-bots Waiting for the review bots to report on this head bot-review-skipped A required review bot did not report; it was skipped by the window or by a person. waiting-self-review Waiting for the author to post /self-reviewed labels Sep 30, 2026
@github-actions

github-actions Bot commented Oct 2, 2026

Copy link
Copy Markdown
Contributor

Bots are done — your move: post /self-reviewed.
Full checklist in the description.

@github-actions github-actions Bot added waiting-self-review Waiting for the author to post /self-reviewed bot-review-skipped A required review bot did not report; it was skipped by the window or by a person. labels Oct 2, 2026

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bot-review-skipped A required review bot did not report; it was skipped by the window or by a person. waiting-self-review Waiting for the author to post /self-reviewed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants