ci: tolerate optional S3 cache export outages on v5.0-dev - #5186
ktechmidas wants to merge 1 commit into
Conversation
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Repository: dashpay/platform/.coderabbit.yaml Review profile: CHILL Plan: Advanced Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
✅ Final review complete — no blockers (commit 843052c) · triage: low |
thepastaclaw
left a comment
There was a problem hiding this comment.
Final validation — Phase 1 + Phase 2
Verified the complete diff at head 843052c: both changed files match the upstream repair, and ignore-error=true is confined to S3 cache exports without changing imports, architecture prefixes, shared-writer opt-in, or build and registry-publication failure handling. All 36 CI-script tests, including the three new cache regressions, and git diff --check passed; no actionable defects were found, though these checks do not demonstrate live S3-outage behavior. This code approval does not override the PR description's explicit hold and instruction not to merge this duplicate PR.
Review provenance
Source: reviewer 1: glm-5.3-flash (agent: phase1-reviewer, role: architecture-layering); reviewer 2: gpt-6-astra (agent: phase2-reviewer, role: general); reviewer 3: gpt-6-astra (agent: phase2-reviewer, role: architecture-layering); final verifier: gpt-6-astra (agent: astra-verifier, role: final-verifier)
- Triage:
lowbygpt-6-astra(effort low) — The diff is a small, contained CI behavior change that tolerates optional S3 cache export failures with targeted regression tests, without changing application logic or any critical surface. - Phase 1 reviewers:
glm-5.3-flash— architecture-layering (completed, effort high); agentphase1-reviewer - Phase 1 model:
glm-5.3-flash— zai quota: 5h 80% left, weekly 86% left; passed overgemini-3.8-flash-high(antigravity below 15% reserve: weekly 13% left, 5h 100% left) - Fresh verifier:
gpt-6-astra— final-verifier; agentastra-verifier - Phase 2 reviewers:
gpt-6-astra— general (completed, effort medium); agentphase2-reviewer,gpt-6-astra— architecture-layering (completed, effort medium); agentphase2-reviewer
|
@coderabbitai review No review for |
|
Bots are done — your move: post |
HOLD — superseded by the concurrent v5 rollout #5185
infraclaw identified that both files in this cache-only PR are already byte-identical parts of #5185 at
d8b1d0419024dac33429aab7c9626c34ce35e9ce. Do not merge this duplicate PR. This overlap was my coordination mistake; #5185 is the v5 source-rollout path.The already-running NPM validation run36551436777/job109350411407 is being left untouched. After it reaches a terminal result, the existing maintenance follow-up will record that result and close only this duplicate PR without merging or deleting its branch. No contributor PR, worker or CI run is being interrupted.
Issue being fixed or feature implemented
Backport the merged CI-only optional S3 cache-export repair #5165 to
v5.0-dev. An unavailable optimization must not invalidate a successful build or image publication.What was done?
5f4ab6c2f98cf3c01f35a5ffa81f61957a4cd50fonto targetad7874352c2a191ca25b6b87be12c487696758f5.ignore-error=true). Imports, architecture prefixes and explicit shared-writer opt-in remain unchanged.How Has This Been Tested?
git diff --checkpass; every non-.githubroot-tree object equals the exact target.Author recovery guidance (after merge only)
If your exact failed step is optional S3 cache export, update your own PR from
v5.0-devafter this repair lands and let the new head start CI. Re-running an unchanged old head does not adopt this action repair. This does not fix Android/sudo setup faults or application/test failures; those remain separate.Breaking Changes
None. Existing image eligibility and legacy runner capacity are preserved.
Checklist
Authored and operated by infraclaw under latte's scoped CI authorization. Protected transport account attribution is not its owner's personal review or approval. No bypass or self-approval is requested.
PR Hygiene ·
843052c/self-reviewedWhen every box is checked the
PR Hygienecheck passes and this can merge.