Skip to content

chore!: forward-merge v4.3-dev into v5.0-dev - #5190

Closed
ktechmidas wants to merge 33 commits into
v5.0-devfrom
merge/v4.3-into-v5.0-internal-20260929
Closed

ktechmidas wants to merge 33 commits into
v5.0-devfrom
merge/v4.3-into-v5.0-internal-20260929

Conversation

@ktechmidas

@ktechmidas ktechmidas commented Sep 29, 2026 •

Copy link
Copy Markdown
Collaborator

Issue being fixed or feature implemented

Forward-merge v4.3-dev into v5.0-dev as requested by latte. Prepared by infraclaw using latte's explicitly requested PAT/internal-branch route, not a fork PR, so existing same-repository CI admission applies.

What was done?

  • Created only the dedicated internal snapshot branch merge/v4.3-into-v5.0-internal-20260929 at exact source 67340ad82406cb36147234bc46f6c572c78ecef9.
  • Target snapshot: ad7874352c2a191ca25b6b87be12c487696758f5. Server-side comparison reports 33 source-only and 137 target-only commits.
  • This is full application/dependency/CI history, not a CI-only cherry-pick. No new application edits or synthetic source commit were made.
  • Shared development branches and contributors' PR branches were not pushed, rebased, force-pushed or retargeted. No protections or fork trust were changed.

Depends on #5189. Do not merge this second leg first. This opening snapshot is the CURRENT v4.3 head, not a claim that the incoming v4.2 fixes are already present. After the first PR merges, refresh this dedicated internal branch from the resulting v4.3 head and rerun attributable CI before landing.

The CI-only backport #5185 remains open for now; do not land competing repairs blindly. Compare exact resulting CI content and close superseded work only after verified integration.

How Has This Been Tested?

  • Verified the source/target snapshots and the internal ref against GitHub.
  • Ref content is byte-identical to the selected source commit; no full test pass is claimed.
  • Target mergeability, conflicts and fresh PR-attributable CI must be checked on GitHub. Being internal permits trusted jobs but is not itself proof they ran or passed.
  • Preserve target-specific application changes when resolving conflicts. No blanket ours/theirs resolution or test suppression.

Breaking Changes

Potential breaking changes are inherited from the full source history and require normal release/application review. Creating this PR does not authorize automatic merging of application history. Runner image deployment and capacity remain separate operational gates.

Checklist:

  • I have performed a self-review of the branch/publication scope
  • Application/dependency changes and any merge conflicts reviewed
  • Fresh target-specific CI completed
  • Required independent reviews complete

PR Hygiene · 67340ad

  • Bots — coderabbitai not yet · thepastaclaw not yet — /skip-bots proceeds without the ones not yet reported
  • Self-review — post /self-reviewed once the bots are done
  • Within your 5 open PRs
  • Build failed
  • Approvals
    • files with no dedicated owner (.github/workflows/pr-review-policy.yml, packages/rs-platform-version/src/version/mod.rs, packages/rs-platform-version/src/version/protocol_version.rs and 2 more) — QuantumExplorer or shumkov
    • rs-platform-wallet-ffi (packages/rs-platform-wallet-ffi/src/error.rs, packages/rs-platform-wallet-ffi/src/invitation.rs) — HashEngineering or ZocoLini or llbartekll or romchornyi
    • rs-platform-wallet (packages/rs-platform-wallet/src/error.rs, packages/rs-platform-wallet/src/wallet/identity/crypto/invitation.rs, packages/rs-platform-wallet/src/wallet/identity/crypto/mod.rs and 28 more) — HashEngineering or ZocoLini or llbartekll or romchornyi
    • rust-sdk (packages/rs-sdk/src/platform/transition/put_identity.rs) — lklimek or shumkov
    • swift-sdk (packages/swift-sdk/Sources/SwiftDashSDK/PlatformWallet/ManagedPlatformWallet.swift, packages/swift-sdk/SwiftTests/SwiftDashSDKTests/InvitationPreviewTests.swift) — llbartekll or romchornyi

When every box is checked the PR Hygiene check passes and this can merge.

shumkov and others added 30 commits September 16, 2026 09:54
Co-authored-by: Claude Opus 5 (1M context) <noreply@anthropic.com>
Co-authored-by: Claude Opus 5 (1M context) <noreply@anthropic.com>
Co-authored-by: Claude Opus 5 (1M context) <noreply@anthropic.com>
)

Co-authored-by: Claude Opus 5 (1M context) <noreply@anthropic.com>
Co-authored-by: Claude Opus 5 (1M context) <noreply@anthropic.com>
Co-authored-by: Claude Opus 5 (1M context) <noreply@anthropic.com>
…4796)

Co-authored-by: Claude Opus 5 (1M context) <noreply@anthropic.com>
…tion (#4805)

Co-authored-by: Claude Opus 5 (1M context) <noreply@anthropic.com>
Co-authored-by: Claude Opus 5 (1M context) <noreply@anthropic.com>
Co-authored-by: Claude Opus 5 (1M context) <noreply@anthropic.com>
Co-authored-by: Claude Opus 5 (1M context) <noreply@anthropic.com>
…4892)

Co-authored-by: Claude Opus 5 (1M context) <noreply@anthropic.com>
Co-authored-by: Claude Opus 5 (1M context) <noreply@anthropic.com>
Co-authored-by: Claude Opus 5 (1M context) <noreply@anthropic.com>
…perations (#4764)

Co-authored-by: Codex GPT-6 <noreply@openai.com>
Co-authored-by: Claude Opus 5 (1M context) <noreply@anthropic.com>
…otent claim (#4997)

Co-authored-by: Roman <51091564+jeanpierreroma@users.noreply.github.com>
Co-authored-by: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
Co-authored-by: QuantumExplorer <quantum@dash.org>
@github-actions github-actions Bot added this to the v5.0.0 milestone Sep 29, 2026
@coderabbitai

coderabbitai Bot commented Sep 29, 2026

Copy link
Copy Markdown
Contributor

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository: dashpay/platform/.coderabbit.yaml

Review profile: CHILL

Plan: Advanced

Run ID: 62d338f9-eacc-479a-af43-bb418bf7e931

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@github-actions github-actions Bot added the waiting-bots Waiting for the review bots to report on this head label Sep 29, 2026
@thepastaclaw

thepastaclaw commented Sep 29, 2026 •

Copy link
Copy Markdown
Collaborator

🕓 Queued for automated review — 12th in line, estimated start in ~1.6 h (commit 67340ad)
Estimated review time once started: ~1.1 h (two-phase automated review; median of recent runs).

  • Request priority review — click to move this review to the front of the queue.

@ktechmidas ktechmidas closed this Sep 29, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

waiting-bots Waiting for the review bots to report on this head

Projects

None yet

Development

Successfully merging this pull request may close these issues.

8 participants