ci: re-pin PR Hygiene so it can verify access granted by the organisation - #1034
Merged
Merged
Conversation
…tion One listing of collaborators does not name the people who reach a repository through the organisation rather than as collaborators of it, and reading their absence as no write access marked six platform pull requests a configuration error. Anyone the listing omits is asked about directly now. dashpay/stale_prs_are_bad#35 landed as 6636e320352dfafaa8187eb73b2d51c9975f2a48. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
Contributor
|
Caution Review failedThe pull request is closed. ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Advanced Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthroughThe pull request changes the pinned commit for the reusable pull request review workflow in the policy job. ChangesReview policy workflow
Estimated code review effort: 1 (Trivial) | ~2 minutes Change: Bug fix ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## dev #1034 +/- ##
==========================================
- Coverage 77.15% 77.14% -0.02%
==========================================
Files 329 329
Lines 83862 83862
==========================================
- Hits 64706 64692 -14
- Misses 19156 19170 +14
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Re-pins the shared review workflow onto dashpay/stale_prs_are_bad#35.
Writes were enabled on
dashpay/platformfor the first time and six of twelve pull requests were immediately markedconfiguration-error— "An assigned owner/reviewer lacks verified write access". The people named are administrators.One listing of collaborators only names the people a token can see, and a repository-scoped Actions token does not enumerate those who reach a repository through the organisation rather than as collaborators of it. Four of the eight owners in platform's policy are in that position, including the one in
fallback.owners— so essentially every pull request was affected, not six.Anyone the listing omits is now asked about directly, once per run, and remembered. The listing still answers for everyone it names, so the request-volume saving it was introduced for is unaffected.
An answer that never arrived is no longer reported as no access — those are different things, and only one of them is about the person.
This repository is affected too.
lklimekon dash-evo-tool andQuantumExploreron rust-dashcore both reach their repository through the organisation, so the same thing would have happened on the day writes were turned on here. grovedb and tenderdash happen to name only direct collaborators, which is why tenderdash has been writing since 13 September without hitting it.🤖 Generated with Claude Code
Summary by CodeRabbit