Skip to content

COPY from csv support delimeter \r\n #6140

Closed
Closed
COPY from csv support delimeter \r\n#6140

Description

@Xuanwo
Xuanwo
opened on Jun 22, 2022

CsvSource will accept the input delimiter directly. This behavior could make user copied wrong data when input delimiter is \n but files is \r\n.

To make users' lives easier, we can handle them by:

let record_delimiter = if record_delimiter == b'\n' || record_delimiter == b'\r' {
    Terminator::CRLF
} else {
    Terminator::Any(record_delimiter)
};

So that users will not panic when they copied the wrong data with \n.

Activity

  1. bohutang
    added
    A-query
    on Jun 22, 2022
  2. Xuanwo
    added this to Xuanwo's Workon Sep 15, 2022
  3. Xuanwo
    moved this to 📋 Backlog in Xuanwo's Workon Sep 15, 2022

  4. Xuanwo commented on Sep 15, 2022

    @Xuanwo
    Xuanwo
    on Sep 15, 2022
    CollaboratorAuthor

    Cc @youngsofun, this issue seems out of date. Do we have already implement this yet?

  5. Xuanwo
    moved this from 📋 Backlog to 🪤 In Waiting in Xuanwo's Workon Sep 15, 2022

  6. Xuanwo commented on Sep 20, 2022

    @Xuanwo
    Xuanwo
    on Sep 20, 2022
    CollaboratorAuthor

    Fixed by #7613

  7. Xuanwo
    closed this as completedon Sep 20, 2022
  8. Xuanwo
    moved this from 🪤 In Waiting to 📦 Done in Xuanwo's Workon Sep 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions