Repository navigation
[agentbricks] Don't treat a failed app lookup as a missing app - #725
Merged
elainewang-db merged 1 commit intoOct 13, 2026
Merged
elainewang-db merged 1 commit into
elainewang-db merged 1 commit into
Conversation
elainewang-db
force-pushed
the
agentbricks-standalone-auth-fixes
branch
from
October 13, 2026 17:03
a267f35 to
7aa7bd1
Compare
shivam5
approved these changes
Oct 13, 2026
shivam5
left a comment
shivam5
left a comment
Contributor
There was a problem hiding this comment.
On error, can we also return the action that needs to be done.
i.e., agentbricks login?
Approving to unblock
Co-authored-by: Isaac <no-reply@databricks.com>
elainewang-db
force-pushed
the
agentbricks-standalone-auth-fixes
branch
from
October 13, 2026 17:53
7aa7bd1 to
b58d2d5
Compare
elainewang-db
changed the title
elainewang-db
enabled auto-merge (squash)
October 13, 2026 17:58
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
deployno longer mistakes a failed app lookup for a missing app.AppsClient.existsused to treat any non-zerodatabricks apps getas "the app doesn't exist", so a bad token or a network error could steerdeployinto an app create. Now it returns False only on an explicit "does not exist"; any other failure raisesCould not check whether deployment '<name>' exists., with the CLI's error plus the next step as the hint: runagentbricks login --profile <profile>if the profile isn't signed in, otherwise check the network and the profile's host.The two
exists()callers are both deploy paths (app ensure, and picking the default name);deployments delete/start/stop/logsdon't use it.E2E testing
Against staging
e2-dogfood; no workspace resources created.-p bad deploy(invalid PAT, custom-server project) → fails in 1.5s withCould not check whether deployment 'agent-bricks-…' exists.and the CLI'sInvalid access tokenerror; no app create attempteddatabricks apps getstderr containsdoes not exist;AppsClient.existsreturns FalseThe added login/network line in the hint is covered by the unit test, not re-run live.
Unit tests (all extras): 1774 passed, 12 skipped. CI lint (
ruff format --check,ruff check,ty check) clean.This pull request and its description were written by Isaac.