Repository navigation
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
agentbricks tracing getcurrently prints an MLflow warning before the CLI error, breaking the JSON error stream. Suppressing that warning through the fluent API also hides permission and service failures as missing traces.Read through the public
MlflowClient.get_trace(display=False)API, which preserves exceptions. Only typed not-found errors receive the short missing-trace message; invalid IDs, permission errors, and service failures retain their details and error codes in structured CLI output. Carry the selected experiment's UC destination into retrieval, preserve the warehouse context, and leave already-qualified trace IDs unchanged.Fixes ML-69250.
Validation:
The earlier read-only DEFAULT checks predate this review follow-up; no new live requests were made. Public CI has been retriggered for the new head. The six memory-backed parallel-history ordering failures seen in earlier framework CI also reproduce on main.
Combined follow-up validation
Test-only source
7b6e3ac407a42acc0b86874b9e36ccb8639d0167combines the twelve bug-bash PRs and these review follow-ups. The Agent Bricks unit suite passed 2,194 tests, 24 skipped in 60.46s; combined Ruff and formatting checks pass. The README conflict was resolved by retaining the guide split and placing the new auth guidance in Authentication. This combined branch is for testing and must not be merged into main. Historical live runs predate the review fixes; no fresh live acceptance is claimed.Current public CI: 53 green, 1 red. The framework job fails only the same six memory-backed parallel-history ordering cases already reproduced on main. No skips were applied.