Repository navigation
[agentbricks] Keep the recorded deployment name in dev's deploy step - #833
Open
elainewang-db wants to merge 1 commit into
Open
elainewang-db wants to merge 1 commit into
elainewang-db wants to merge 1 commit into
Conversation
`agentbricks dev`'s next steps suggested `agentbricks deploy <directory>`. `deploy NAME` records NAME in agent.toml, so following it renamed the deployment away from the one `init` set up (and `init`'s own next step is a bare `agentbricks deploy`). When agent.toml records a deployment_name, suggest `agentbricks deploy` and say which app it deploys to; otherwise keep naming it after the directory. Co-authored-by: Isaac <no-reply@databricks.com>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
agentbricks dev's "Agent is running" panel now suggestsagentbricks deploy(deploying asagent-bricks-<recorded name>) when agent.toml records a[agent].deployment_name. Projects without one still getagentbricks deploy <directory>.Why
The panel always built the step from the project directory's name (
presentation/dev.py).deploy NAMErecords NAME in agent.toml, so following the suggestion renamed the deployment away from the oneinitrecorded. Found while manually testing 0.8.0:init --name lg-ewrel0802108 lg-agentfollowed bydevsuggestedagentbricks deploy lg-agent.init's own next step is already a bareagentbricks deploy.Changes
DevPreviewcarries the project'sdeployment_name;devpasses it toannounce_local_url.Testing
dev_test.pycases: a recorded name gives a bareagentbricks deployrow plus the app name (agentbricks and custom servers); an unnamed project keepsagentbricks deploy <dir>.dev_service_test.pychecks the preview field.ruff check,ruff format --checkandty checkare clean.This pull request and its description were written by Isaac.