Repository navigation
[agentbricks] Refuse :langgraph actors in SessionStores add/fork - #836
Closed
pshekhar2308 wants to merge 2 commits into
Closed
pshekhar2308 wants to merge 2 commits into
pshekhar2308 wants to merge 2 commits into
Conversation
…d memory memory_store() returns DatabricksMemoryStore, a LangGraph BaseStore over the managed memory API, so LangGraph and LangMem code that takes store= gets cross-conversation memory with no Postgres connection to run. The user comes from each run's config (thread_config), so one store serves every user of an app; entries are kept under the storage actor "<actor>:langgraph", and the session and memory helpers refuse actors with that suffix. Values are kept in a small JSON envelope, with optional client-side TTL and a per-user sweep. Includes unit tests over a wire-level fake of the memory API, a gated live suite, a README section, and a migration page from DatabricksStore. Co-authored-by: Isaac <no-reply@databricks.com>
thread_config, memory_tools and the session helpers reject actors ending in ':langgraph' so automatic memory pipelines never see the LangGraph store's storage actor, but the typed session SDK still let callers create a session under that id directly. A session for <actor>:langgraph makes it discoverable to pipelines, which can rewrite the store's JSON envelopes. Apply check_actor in _add_session and _fork_session so the SDK enforces the same rule, and cover both paths with unit tests. Generated with [Devin](https://devin.ai) Co-Authored-By: Devin <158243242+devin-ai-integration[bot]@users.noreply.github.com>
Author
|
Opened against the wrong base — closing and reopening on the intended fork. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
SessionStoresadd/forkagainst:langgraphactor IDs, which are reserved by the LangGraph store adapter and would corrupt managed-memory sessions if passed through directly.session_store_test.py.Test plan
add/forkrejection of:langgraphactorsGenerated with Devin