checks: accept supported CIMC 4.2(3e) on APIC 6.1(5) - #411
Conversation
Honor the APIC 6.1(5) release-note support exception for M5/M6 controllers while preserving the CSCwo74485 ordering gate and catalog failures for other versions. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
monrog2
left a comment
There was a problem hiding this comment.
Blocking review finding: the release-note compatibility override is incomplete and still rejects supported APIC-L4/M4 CIMC versions. GitHub does not permit authors to formally request changes on their own pull requests.
| release_note_supported = ( | ||
| tversion.simple_version == "6.1(5)" | ||
| and model in ("apicl3", "apicm3", "apicl4", "apicm4") | ||
| and current_cimc == "4.2(3e)" |
There was a problem hiding this comment.
Blocking: This exact-match exception implements the APIC 6.1(5) release-note table incompletely. For APIC-L4/M4, the same release notes also support CIMC 4.3(2.230207) and 4.3(2.240009). Both remain below the catalog recommendation 4.3(4.252002), so this condition stays false and the check incorrectly returns FAIL_UF for supported upgrades. Please use a model-specific allowlist covering all release-note-supported versions below the catalog recommendation, retain the preceding CSCwo74485 ordering gate, update the documentation, and add PASS tests for both omitted M6 versions plus an unlisted-version failure test.
- Add resource_group for sequential execution across jobs - Split single integration test into 6 version-specific jobs: - 5.2(4d) -> 5.2(8f): 5.x internal upgrades - 5.2(4d) -> 6.0(2h): 5.x to 6.0.x upgrades - 5.2(6e) -> 6.0(5a): 5.x to 6.0.x upgrades - 5.2(8d) -> 6.1(1f): 5.x to 6.1.x upgrades - 5.3(2d) -> 6.1(4h): 5.x to 6.1.x upgrades - 6.0(2a) -> 6.1(4h): 6.x internal upgrades - Add --cversion and --tversion flags to runner.py invocation - Add timeout (45m) and retry on runner failure - Use YAML template to reduce duplication This enables testing version-dependent check logic across multiple upgrade paths while protecting scale fabrics via resource_group sequential execution.
Scrubbed integration summaryPipeline tested commit
A live APIC 6.1(5e) run exercised the new logic:
This confirms the release-note compatibility path supplements the catalog without bypassing unrelated catalog failures. CSCwo74485 precedence was also preserved. The original APIC-L4/M4 |
Summary
Why
The APIC image catalog can recommend a newer CIMC release than the versions explicitly supported by the APIC release notes. The check treated the catalog recommendation as a hard minimum and incorrectly returned
FAIL - UPGRADE FAILUREfor the supported 4.2(3e) / 6.1(5e) combination reported in #338.Validation
git diff --checkpassedFixes #338