Conversation
There was a problem hiding this comment.
Copilot review overview
🟡 Changes recommended
Several unresolved issues prevent CI tests from running correctly and risk unintended dry-run or database behavior.
Get a fresh assessment by requesting another Copilot review.
Review effort: Balanced
Findings: 2
Open (9)
Compile-only sanity check rejects dummy connection credentials · New DSE internal keyspaces are not protected from cleanup · New Composite action exposes nonexistent build-cli output · New Integration tests skipped because action runs in plan-only mode · New Appending language to all skips Python and C# setup · New Dry run modifies repositories before confirmation · New Repeated missing keyspaces are created more than once · New Generated commands still use obsolete dh test and dh review forms · New Concurrent UDT drops ignore type dependencies · New
What changed in this PR
Overhauls the CLI namespace and command hierarchy while adding client integration testing, database maintenance commands, shared configuration, and CI support.
Changes:
- Migrates
com.dtsx.docstocom.dtsx.dhand groups documentation commands underdh docs. - Adds client-suite execution and database bootstrap/cleanup workflows.
- Adds architecture tests, shared utilities, CI actions, and environment configuration.
| File | Description |
|---|---|
src/test/java/com/dtsx/dh/architecture/PackageBoundaryTest.java |
Adds package-boundary tests. |
src/main/java/com/dtsx/docs/HelperCli.java |
Removes old CLI entry point. |
src/main/java/com/dtsx/docs/core/runner/tests/snapshots/sources/SnapshotSource.java |
Removes old snapshot source. |
src/main/java/com/dtsx/docs/core/runner/tests/snapshots/sources/output/OutputMatchesSource.java |
Removes old output matcher. |
src/main/java/com/dtsx/docs/core/runner/tests/snapshots/sources/output/OutputCaptureSource.java |
Removes old output capture source. |
src/main/java/com/dtsx/docs/core/runner/RunException.java |
Removes superseded exception. |
src/main/java/com/dtsx/docs/core/planner/PlanException.java |
Removes superseded exception. |
src/main/java/com/dtsx/docs/core/planner/meta/snapshot/meta/TableNamesSourceMeta.java |
Removes old metadata record. |
src/main/java/com/dtsx/docs/core/planner/meta/compiles/CompilesTestMeta.java |
Removes old compile metadata. |
src/main/java/com/dtsx/docs/config/ConnectionInfo.java |
Removes old connection model. |
src/main/java/com/dtsx/docs/config/args/BaseScriptRunnerArgs.java |
Removes old script arguments. |
src/main/java/com/dtsx/dh/lib/LoadingSpinner.java |
Migrates spinner namespace. |
src/main/java/com/dtsx/dh/lib/KeyspaceOps.java |
Adds shared keyspace operations. |
src/main/java/com/dtsx/dh/lib/JacksonUtils.java |
Migrates JSON utilities and exceptions. |
src/main/java/com/dtsx/dh/lib/ExecutorUtils.java |
Migrates executor utilities. |
src/main/java/com/dtsx/dh/lib/DurationUtils.java |
Adds duration formatting. |
src/main/java/com/dtsx/dh/lib/DataAPIUtils.java |
Adds database-admin access. |
src/main/java/com/dtsx/dh/lib/Constants.java |
Migrates constants. |
src/main/java/com/dtsx/dh/lib/ColorUtils.java |
Migrates color utilities. |
src/main/java/com/dtsx/dh/lib/CliLogger.java |
Updates logging, terminal detection, and run logs. |
src/main/java/com/dtsx/dh/HelperCli.java |
Adds reorganized CLI entry point and dotenv loading. |
src/main/java/com/dtsx/dh/core/docs/runner/tests/VerifyMode.java |
Migrates verification modes. |
src/main/java/com/dtsx/dh/core/docs/runner/tests/TestRunner.java |
Migrates documentation test runner. |
src/main/java/com/dtsx/dh/core/docs/runner/tests/strategies/test/TestStrategy.java |
Migrates base test strategy. |
src/main/java/com/dtsx/dh/core/docs/runner/tests/strategies/test/SnapshotTestStrategy.java |
Migrates snapshot strategy. |
src/main/java/com/dtsx/dh/core/docs/runner/tests/strategies/test/CompilesTestStrategy.java |
Migrates compilation strategy. |
src/main/java/com/dtsx/dh/core/docs/runner/tests/strategies/execution/SharedExecutionStrategy.java |
Migrates shared execution. |
src/main/java/com/dtsx/dh/core/docs/runner/tests/strategies/execution/SequentialExecutionStrategy.java |
Migrates sequential execution. |
src/main/java/com/dtsx/dh/core/docs/runner/tests/strategies/execution/IsolatedExecutionStrategy.java |
Migrates isolated execution. |
src/main/java/com/dtsx/dh/core/docs/runner/tests/strategies/execution/ExecutionStrategy.java |
Migrates execution interface. |
src/main/java/com/dtsx/dh/core/docs/runner/tests/snapshots/verifier/SnapshotVerifier.java |
Moves reducer selection to drivers. |
src/main/java/com/dtsx/dh/core/docs/runner/tests/snapshots/verifier/Snapshot.java |
Migrates snapshot model. |
src/main/java/com/dtsx/dh/core/docs/runner/tests/snapshots/verifier/scrubbers/UUIDScrubber.java |
Migrates UUID scrubber. |
src/main/java/com/dtsx/dh/core/docs/runner/tests/snapshots/verifier/scrubbers/ObjectIdScrubber.java |
Migrates object-ID scrubber. |
src/main/java/com/dtsx/dh/core/docs/runner/tests/snapshots/verifier/ExampleResultNamer.java |
Migrates snapshot naming. |
src/main/java/com/dtsx/dh/core/docs/runner/tests/snapshots/sources/SnapshotSourceUtils.java |
Migrates snapshot helpers. |
src/main/java/com/dtsx/dh/core/docs/runner/tests/snapshots/sources/SnapshotSource.java |
Recreates snapshot source abstraction. |
src/main/java/com/dtsx/dh/core/docs/runner/tests/snapshots/sources/schema/names/UdtNamesSource.java |
Migrates UDT-name source. |
src/main/java/com/dtsx/dh/core/docs/runner/tests/snapshots/sources/schema/names/TableNamesSource.java |
Migrates table-name source. |
src/main/java/com/dtsx/dh/core/docs/runner/tests/snapshots/sources/schema/names/TableIndexNamesSource.java |
Migrates index-name source. |
src/main/java/com/dtsx/dh/core/docs/runner/tests/snapshots/sources/schema/names/NamesSource.java |
Migrates schema-name base source. |
src/main/java/com/dtsx/dh/core/docs/runner/tests/snapshots/sources/schema/names/CollectionNamesSource.java |
Migrates collection-name source. |
src/main/java/com/dtsx/dh/core/docs/runner/tests/snapshots/sources/schema/definitions/UdtDefinitionsSource.java |
Migrates UDT definitions. |
src/main/java/com/dtsx/dh/core/docs/runner/tests/snapshots/sources/schema/definitions/TableIndexDefinitionsSource.java |
Migrates index definitions. |
src/main/java/com/dtsx/dh/core/docs/runner/tests/snapshots/sources/schema/definitions/TableDefinitionSource.java |
Migrates table definitions. |
src/main/java/com/dtsx/dh/core/docs/runner/tests/snapshots/sources/schema/definitions/SchemaObjectDefinitionSource.java |
Migrates schema definition base. |
src/main/java/com/dtsx/dh/core/docs/runner/tests/snapshots/sources/schema/definitions/CollectionDefinitionSource.java |
Migrates collection definitions. |
src/main/java/com/dtsx/dh/core/docs/runner/tests/snapshots/sources/records/RowsSource.java |
Migrates row snapshots. |
src/main/java/com/dtsx/dh/core/docs/runner/tests/snapshots/sources/records/RecordSource.java |
Migrates record source abstraction. |
src/main/java/com/dtsx/dh/core/docs/runner/tests/snapshots/sources/records/DocumentsSource.java |
Migrates document snapshots. |
src/main/java/com/dtsx/dh/core/docs/runner/tests/snapshots/sources/output/OutputMatchesSource.java |
Recreates output matching source. |
src/main/java/com/dtsx/dh/core/docs/runner/tests/snapshots/sources/output/OutputJsonifySource.java |
Migrates JSON output source. |
src/main/java/com/dtsx/dh/core/docs/runner/tests/snapshots/sources/output/OutputCaptureSource.java |
Recreates output capture source. |
src/main/java/com/dtsx/dh/core/docs/runner/tests/snapshots/reducers/SnapshotsReducer.java |
Migrates reducer interface. |
src/main/java/com/dtsx/dh/core/docs/runner/tests/snapshots/reducers/SnapshotReductionException.java |
Migrates reduction exception. |
src/main/java/com/dtsx/dh/core/docs/runner/tests/snapshots/reducers/DefaultSnapshotsReducer.java |
Migrates default reducer. |
src/main/java/com/dtsx/dh/core/docs/runner/tests/snapshots/reducers/CSharpSnapshotsReducer.java |
Migrates C# reducer. |
src/main/java/com/dtsx/dh/core/docs/runner/tests/results/TestRootResults.java |
Migrates root results. |
src/main/java/com/dtsx/dh/core/docs/runner/tests/results/TestResults.java |
Migrates aggregate results. |
src/main/java/com/dtsx/dh/core/docs/runner/tests/results/TestOutcome.java |
Migrates test outcomes. |
src/main/java/com/dtsx/dh/core/docs/runner/tests/reporter/TestReporters.java |
Migrates reporter factory. |
src/main/java/com/dtsx/dh/core/docs/runner/tests/reporter/TestReporter.java |
Migrates reporter base. |
src/main/java/com/dtsx/dh/core/docs/runner/tests/reporter/OnlyFailuresReporter.java |
Migrates failure reporter. |
src/main/java/com/dtsx/dh/core/docs/runner/tests/reporter/AllTestsReporter.java |
Migrates full reporter. |
src/main/java/com/dtsx/dh/core/docs/runner/tests/DuplicatesFinder.java |
Migrates duplicate detection. |
src/main/java/com/dtsx/dh/core/docs/runner/scripts/ScriptRunner.java |
Migrates script runner. |
src/main/java/com/dtsx/dh/core/docs/runner/scripts/reporter/ScriptReporter.java |
Migrates script reporter base. |
src/main/java/com/dtsx/dh/core/docs/runner/scripts/reporter/PlainScriptReporter.java |
Migrates plain reporting. |
src/main/java/com/dtsx/dh/core/docs/runner/scripts/reporter/DetailedScriptReporter.java |
Migrates detailed reporting. |
src/main/java/com/dtsx/dh/core/docs/runner/PlaceholderVars.java |
Migrates placeholder variables and exceptions. |
src/main/java/com/dtsx/dh/core/docs/runner/Placeholders.java |
Migrates placeholder model. |
src/main/java/com/dtsx/dh/core/docs/runner/PlaceholderResolver.java |
Migrates placeholder resolution. |
src/main/java/com/dtsx/dh/core/docs/runner/ExecutionEnvironments.java |
Migrates environment collection. |
src/main/java/com/dtsx/dh/core/docs/runner/ExecutionEnvironment.java |
Migrates execution environment handling. |
src/main/java/com/dtsx/dh/core/docs/runner/drivers/impls/TypeScriptDriver.java |
Updates TypeScript driver dependencies. |
src/main/java/com/dtsx/dh/core/docs/runner/drivers/impls/PythonDriver.java |
Migrates Python driver. |
src/main/java/com/dtsx/dh/core/docs/runner/drivers/impls/JavaDriver.java |
Migrates Java driver. |
src/main/java/com/dtsx/dh/core/docs/runner/drivers/impls/GoDriver.java |
Migrates Go driver. |
src/main/java/com/dtsx/dh/core/docs/runner/drivers/impls/CSharpDriver.java |
Assigns C# snapshot reducer. |
src/main/java/com/dtsx/dh/core/docs/runner/drivers/impls/BashDriver.java |
Migrates Bash driver. |
src/main/java/com/dtsx/dh/core/docs/runner/drivers/ClientDriver.java |
Adds driver-specific reducers. |
src/main/java/com/dtsx/dh/core/docs/planner/TestRoot.java |
Migrates planned test roots. |
src/main/java/com/dtsx/dh/core/docs/planner/TestPlan.java |
Migrates test plans. |
src/main/java/com/dtsx/dh/core/docs/planner/meta/snapshot/SnapshotTestMetaRep.java |
Migrates snapshot representation. |
src/main/java/com/dtsx/dh/core/docs/planner/meta/snapshot/SnapshotTestMeta.java |
Migrates snapshot metadata. |
src/main/java/com/dtsx/dh/core/docs/planner/meta/snapshot/SnapshotsShareConfig.java |
Migrates sharing configuration. |
src/main/java/com/dtsx/dh/core/docs/planner/meta/snapshot/SnapshotSourcesParser.java |
Migrates source parsing. |
src/main/java/com/dtsx/dh/core/docs/planner/meta/snapshot/meta/WithNameAndKeyspace.java |
Migrates metadata interface. |
src/main/java/com/dtsx/dh/core/docs/planner/meta/snapshot/meta/WithKeyspace.java |
Migrates keyspace metadata. |
src/main/java/com/dtsx/dh/core/docs/planner/meta/snapshot/meta/UdtDefinitionSourceMeta.java |
Migrates UDT source metadata. |
src/main/java/com/dtsx/dh/core/docs/planner/meta/snapshot/meta/TableNamesSourceMeta.java |
Recreates table-name metadata. |
src/main/java/com/dtsx/dh/core/docs/planner/meta/snapshot/meta/TableIndexDefinitionSourceMeta.java |
Migrates index metadata. |
src/main/java/com/dtsx/dh/core/docs/planner/meta/snapshot/meta/RecordSourceMeta.java |
Migrates record metadata. |
src/main/java/com/dtsx/dh/core/docs/planner/meta/snapshot/meta/OutputMatchesSourceMeta.java |
Migrates matcher metadata. |
src/main/java/com/dtsx/dh/core/docs/planner/meta/snapshot/meta/OutputJsonifySourceMeta.java |
Migrates JSON output metadata. |
src/main/java/com/dtsx/dh/core/docs/planner/meta/snapshot/ExecutionMode.java |
Migrates execution modes. |
src/main/java/com/dtsx/dh/core/docs/planner/meta/PerLanguageToggle.java |
Migrates language toggles. |
src/main/java/com/dtsx/dh/core/docs/planner/meta/MetaYmlParser.java |
Migrates metadata parsing. |
src/main/java/com/dtsx/dh/core/docs/planner/meta/compiles/CompilesTestMetaRep.java |
Migrates compile representation. |
src/main/java/com/dtsx/dh/core/docs/planner/meta/compiles/CompilesTestMeta.java |
Recreates compile metadata. |
src/main/java/com/dtsx/dh/core/docs/planner/meta/BaseMetaYml.java |
Migrates base metadata. |
src/main/java/com/dtsx/dh/core/docs/planner/fixtures/NoopFixture.java |
Migrates no-op fixtures. |
src/main/java/com/dtsx/dh/core/docs/planner/fixtures/JSFixtureImpl.java |
Migrates JavaScript fixtures. |
src/main/java/com/dtsx/dh/core/docs/planner/fixtures/JSFixture.java |
Migrates fixture abstraction. |
src/main/java/com/dtsx/dh/core/docs/planner/fixtures/FixtureMetadata.java |
Migrates fixture metadata. |
src/main/java/com/dtsx/dh/core/docs/planner/fixtures/BaseFixturePool.java |
Migrates fixture pooling. |
src/main/java/com/dtsx/dh/core/common/RepoCheckout.java |
Adds shallow repository checkout. |
src/main/java/com/dtsx/dh/core/common/CliException.java |
Adds shared CLI exception. |
src/main/java/com/dtsx/dh/core/common/ClientLanguage.java |
Centralizes language factories. |
src/main/java/com/dtsx/dh/core/clients/SuiteCredentials.java |
Adds client-suite credential resolution. |
src/main/java/com/dtsx/dh/core/clients/results/Outcome.java |
Adds client outcomes. |
src/main/java/com/dtsx/dh/core/clients/results/ClientResult.java |
Adds client result records. |
src/main/java/com/dtsx/dh/core/clients/impls/GoSuite.java |
Adds Go integration suite. |
src/main/java/com/dtsx/dh/core/clients/impls/CSharpSuite.java |
Adds C# integration suite. |
src/main/java/com/dtsx/dh/core/clients/ClientToggles.java |
Adds shared suite toggles. |
src/main/java/com/dtsx/dh/core/clients/ClientSuite.java |
Defines client-suite contract. |
src/main/java/com/dtsx/dh/core/clients/ClientsPlan.java |
Builds resolved client plans. |
src/main/java/com/dtsx/dh/core/clients/ClientArtifactSpec.java |
Parses repository specifications. |
src/main/java/com/dtsx/dh/config/SystemKeyspaces.java |
Defines protected keyspaces. |
src/main/java/com/dtsx/dh/config/ctx/BaseScriptRunnerCtx.java |
Refactors connected script context. |
src/main/java/com/dtsx/dh/config/ctx/BaseCtx.java |
Updates common context and temp path. |
src/main/java/com/dtsx/dh/config/ctx/BaseConnectedCtx.java |
Adds shared connected context. |
src/main/java/com/dtsx/dh/config/ArgUtils.java |
Migrates argument utilities. |
src/main/java/com/dtsx/dh/config/args/mixins/YesMixin.java |
Adds execution confirmation. |
src/main/java/com/dtsx/dh/config/args/mixins/ExamplesFolderMixin.java |
Migrates example-folder options. |
src/main/java/com/dtsx/dh/config/args/mixins/DriversMixin.java |
Adds shared language selection. |
src/main/java/com/dtsx/dh/config/args/mixins/BailMixin.java |
Adds shared bail option. |
src/main/java/com/dtsx/dh/config/args/BaseScriptRunnerArgs.java |
Recreates script-runner arguments. |
src/main/java/com/dtsx/dh/config/args/BaseConnectedArgs.java |
Adds shared connection arguments. |
src/main/java/com/dtsx/dh/config/args/BaseArgs.java |
Migrates common options. |
src/main/java/com/dtsx/dh/commands/startgate/StartgateMode.java |
Migrates startgate modes. |
src/main/java/com/dtsx/dh/commands/startgate/StartgateCtx.java |
Migrates startgate context. |
src/main/java/com/dtsx/dh/commands/startgate/StartgateCmd.java |
Migrates startgate command. |
src/main/java/com/dtsx/dh/commands/startgate/StartgateArgs.java |
Migrates startgate arguments. |
src/main/java/com/dtsx/dh/commands/logs/LogsCtx.java |
Migrates logs context. |
src/main/java/com/dtsx/dh/commands/logs/LogsCmd.java |
Migrates logs command. |
src/main/java/com/dtsx/dh/commands/logs/LogsArgs.java |
Migrates logs arguments. |
src/main/java/com/dtsx/dh/commands/docs/test/DocsTestCtx.java |
Refactors documentation-test context. |
src/main/java/com/dtsx/dh/commands/docs/test/DocsTestCmd.java |
Moves test command under docs. |
src/main/java/com/dtsx/dh/commands/docs/test/DocsTestArgs.java |
Uses shared driver selection. |
src/main/java/com/dtsx/dh/commands/docs/run/RunCtx.java |
Migrates run context. |
src/main/java/com/dtsx/dh/commands/docs/run/RunCmd.java |
Moves run command under docs. |
src/main/java/com/dtsx/dh/commands/docs/run/RunArgs.java |
Migrates run arguments. |
src/main/java/com/dtsx/dh/commands/docs/review/ReviewCtx.java |
Migrates review context. |
src/main/java/com/dtsx/dh/commands/docs/review/ReviewCmd.java |
Migrates review command. |
src/main/java/com/dtsx/dh/commands/docs/review/ReviewArgs.java |
Migrates review arguments. |
src/main/java/com/dtsx/dh/commands/docs/gen/table_errors/TableErrorsCtx.java |
Migrates generator context. |
src/main/java/com/dtsx/dh/commands/docs/gen/table_errors/TableErrorsCmd.java |
Updates generator command text. |
src/main/java/com/dtsx/dh/commands/docs/gen/table_errors/TableErrorsArgs.java |
Migrates generator arguments. |
src/main/java/com/dtsx/dh/commands/docs/gen/GenCmd.java |
Renames docgen to docs gen. |
src/main/java/com/dtsx/dh/commands/docs/DocsCmd.java |
Adds documentation command group. |
src/main/java/com/dtsx/dh/commands/db/DbCmd.java |
Adds database command group. |
src/main/java/com/dtsx/dh/commands/db/clean/CleanCtx.java |
Adds cleanup context. |
src/main/java/com/dtsx/dh/commands/db/clean/CleanCmd.java |
Adds database cleanup command. |
src/main/java/com/dtsx/dh/commands/db/clean/CleanArgs.java |
Adds cleanup arguments. |
src/main/java/com/dtsx/dh/commands/db/bootstrap/BootstrapCtx.java |
Adds bootstrap context. |
src/main/java/com/dtsx/dh/commands/db/bootstrap/BootstrapCmd.java |
Adds keyspace bootstrap command. |
src/main/java/com/dtsx/dh/commands/db/bootstrap/BootstrapArgs.java |
Adds bootstrap arguments. |
src/main/java/com/dtsx/dh/commands/completions/CompgenCmd.java |
Migrates completion generation. |
src/main/java/com/dtsx/dh/commands/clients/test/ClientsTestCmd.java |
Adds client-suite command flow. |
src/main/java/com/dtsx/dh/commands/clients/test/ClientsTestArgs.java |
Adds client-suite options. |
src/main/java/com/dtsx/dh/commands/clients/ClientsCmd.java |
Adds client command group. |
src/main/java/com/dtsx/dh/commands/BaseCmd.java |
Centralizes test-failure exit code. |
scripts/utils/docker-hcd/docker-compose.yml |
Raises HCD memory limit. |
scripts/utils/docker-dse/docker-compose.yml |
Raises DSE memory limit. |
build.gradle.kts |
Updates application namespace and test dependencies. |
.gitignore |
Updates temporary and dotenv exclusions. |
.github/actions/test-execution/action.yml |
Splits setup from docs execution. |
.github/actions/test-compilation/action.yml |
Uses reorganized docs actions. |
.github/actions/test-clients/action.yml |
Adds client integration action. |
.github/actions/_use-dh/action.yml |
Adds shared CLI execution action. |
.github/actions/_setup-docs-env/action.yml |
Extracts docs environment setup. |
.github/actions/_setup-clients-env/action.yml |
Adds client toolchain setup. |
.env.docs.example |
Updates docs-scoped environment example. |
.env.common.example |
Adds common environment example. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
| setup-languages: ${{ inputs.clients }} | ||
| args: | | ||
| test -m compile_only ${{ inputs.clients }} ${{ inputs.args }} | ||
| docs test -m compile_only ${{ inputs.clients }} ${{ inputs.args }} |
Comment on lines
+12
to
+18
| private static final Set<String> EXCLUDED = Set.of( | ||
| "data_endpoint_auth" | ||
| ); | ||
|
|
||
| public static boolean isSystemKeyspace(String keyspace) { | ||
| return keyspace.equals("system") || keyspace.startsWith("system_") || EXCLUDED.contains(keyspace); | ||
| } |
Comment on lines
+12
to
+16
| outputs: | ||
| dh-cli-path: | ||
| description: 'Path to the built dh jar file' | ||
| value: ${{ steps.build-cli.outputs.dh-cli-path }} | ||
| failed_tests: |
| with: | ||
| allow-failures: ${{ inputs.allow-failures }} | ||
| args: | | ||
| clients test ${{ inputs.clients }} ${{ inputs.args }} |
| docs-repo-token: ${{ inputs.docs-repo-token }} | ||
| examples-path: ${{ inputs.examples-path }} | ||
| allow-failures: ${{ inputs.allow-failures }} | ||
| setup-languages: ${{ inputs.clients }},typescript # always need typescript for execution tests |
Comment on lines
+24
to
+31
| ClientsRunner.prepareRepos(ctx); | ||
|
|
||
| val plan = ClientsPlan.build(ctx); | ||
| ClientsReporter.printPlan(ctx, plan); | ||
|
|
||
| if (!ctx.yes()) { | ||
| ClientsReporter.printDryRunNotice(); | ||
| return 0; |
|
|
||
| CliLogger.println(false); | ||
|
|
||
| for (val ks : ctx.keyspaces()) { |
Comment on lines
+11
to
+16
| @Command( | ||
| name = "docs", | ||
| description = "Commands for testing/generating documentation examples", | ||
| mixinStandardHelpOptions = true, | ||
| subcommands = { | ||
| DocsTestCmd.class, |
| contents.tables().forEach((name) -> collectionsAndTables.add(() -> db.dropTable(name))); | ||
| runConcurrently(collectionsAndTables); | ||
|
|
||
| runConcurrently(contents.udts().stream().<Runnable>map((name) -> () -> db.dropType(name)).toList()); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


No description provided.