Repository navigation
feat: add execTerminal capability validation - #649
Merged
Merged
Conversation
savme
marked this pull request as ready for review
November 12, 2026 19:00
ecv
approved these changes
Nov 12, 2026
ecv
left a comment
Contributor
There was a problem hiding this comment.
Approve.
The merge gate in the body is met. infra#9267 declares execTerminal on general-purpose, landed in staging on merge and is in infra tag v0.84.352 for production. Kata keeps interactive shells, and unikernel refuses -t instead of opening a shell with no prompt. Production also moves only on a compute pin bump, which gates it a second time. All checks pass at 8bd35ca.
- Admission refuses only
spec.terminal: trueon a class withoutexecTerminal, and exec without a terminal stays admitted. Tests cover all three cases. - datumctl matches only a
Forbiddencause onspec.terminalbefore adding "Run the command without -t". Other terminal errors and other refused fields pass through unchanged, and tests cover both. canShowShellnow needsexecTerminal, which matches the portal opening only terminal sessions.
Follow-ups:
- Before the production pin bump, confirm existing production project planes carry the updated
general-purposeclass, not only new ones. Otherwise kata shells there are refused.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refuses shell sessions that ask for a terminal on classes that don't declare
execTerminal, and hides the portal's shell button there. Unikernel exec runs with no PTY, so-itand the portal shell would open a shell with no prompt, echo or signals. Sessions without a terminal keep working.spec.terminal: truerequires the class to declareexecTerminalcanShowShellchecksexecTerminalinstead ofexec, since the portal only opens terminal sessionsMerge only after #648 is released and general-purpose declares
execTerminalin every environment. Otherwise kata loses interactive shells.Part of datum-cloud/unikraft-provider#247