Repository navigation
fix(compute): always report the backends stage in deploy output - #656
Open
polylane[bot] wants to merge 1 commit into
Open
polylane[bot] wants to merge 1 commit into
polylane[bot] wants to merge 1 commit into
Conversation
…y member Co-authored-by: polylane[bot] <277585245+polylane[bot]@users.noreply.github.com>
scotwells
approved these changes
Nov 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On a redeploy of a workload whose URL is already live,
datumctl compute deployfinished without printing its backends line, so the Datum website's rollout gate failed even though the deploy was healthy. The deploy output now always reports the backends stage for a workload that has a backend service, so the gate reads the line the tool documents. The tool's own output documentation lists the backends line as part of a successful publish, but the code printed it only once a backend was healthy. A live URL can briefly report no healthy member right after an instance is replaced, which dropped the line.Production impact at
0948d3f: Deploy CLI prints one extra progress line; no serving path changesFix walkthrough
Watch the fix explained (1:32). Recorded for commit
0948d3f539e61bdcfc83a49cf1b3a38fd2cb417e.Full analysis
flowchart TD A["Prior deploy left the URL live: edge programmed, certificate issued"] --> B["New push: datumctl compute deploy runs the replacement rollout"] B --> C["Watch prints Rollout complete"] C --> D["url.Wait polls one time"] D --> E{"Info.Live: URL + edge programmed + certificate"} E -->|true| F["Fix acts here: print the backends stage whenever a NetworkService backs the URL"] F --> G["Output: Backends n healthy, Edge programmed, Certificate issued"] G --> H["Workflow grep for Backends .*healthy matches and the gate passes"]Detection evidence
Affected:
int_17ad4b457001o98datdn4tkmOut of scope
Production impact
This change only affects stdout of the
datumctl compute deployplugin, distributed as theghcr.io/datum-cloud/computeimage; it does not touch the live-ness decision, the objects the tool writes, or any workload status. I checked the compute repository's only deploy edge (theghcr.io/datum-cloud/computeimage repository) and found no serving resource whose behavior changes.Checked and not affected (1)
datum-cloud/computeObservability
datumctl compute deploystdout: theBackends <n> healthy across <cities>row now always appears for a workload that has a NetworkService, and the healthy count is the platform's own value.Polylane assessed this pull request at
0948d3f.Causal chain
2 files changed (+46/-2)
internal/cmd/compute/url/publish.go: modified, +19/-2internal/cmd/compute/url/publish_test.go: modified, +27/-0Generated by Polylane. You can ask follow-ups by mentioning @polylane in a comment. If you close this pull request without merging, add a comment that says why. Polylane reads it to make its next fixes better.