Skip to content

fix(ui): Bump React Router in both UIs and add the vuln scan - #660

Merged
ecv merged 2 commits into
datum-cloud:mainfrom
yahyafakhroji:fix/dependency-vulnerabilities
Nov 19, 2026
Merged

ecv merged 2 commits into
datum-cloud:mainfrom
yahyafakhroji:fix/dependency-vulnerabilities

Conversation

@yahyafakhroji

Copy link
Copy Markdown
Contributor

Problem
The provider UI pinned React Router 7.18.2 and the consumer UI pinned 8.3.1, both inside the advisories published on 18 Nov. Both UIs run only in the browser, so the server-side bugs can't reach them, but audits still flag the pins. No CI job scanned compute's npm lockfiles or Go modules.

Solution
The provider moves to 7.18.5 and the consumer to 8.5.1, the oldest releases with every fix. A new workflow runs the shared datum-cloud/actions vuln-scan on pull requests, pushes to main and every Monday. The one Go module hit, GO-2026-6778 in docker/distribution, lives in a registry client package that compute never compiles, so govulncheck will not flag it.

Both UIs typecheck and build, and the consumer tests pass.

The provider UI pinned 7.18.2 and the consumer UI pinned 8.3.1. Both
versions fall inside the React Router advisories published on 18 Nov.
Both UIs run only in the browser, so the server-side bugs can't reach
them, but audits still flag the pins. The provider moves to 7.18.5 and
the consumer to 8.5.1.
Nothing in compute checked its npm lockfiles or Go modules against
advisory databases, so pinned vulnerable versions went unnoticed until
someone looked. Call the shared datum-cloud/actions vuln-scan workflow
on pull requests, pushes to main and every Monday.
@yahyafakhroji
yahyafakhroji requested a review from a team as a code owner November 18, 2026 23:17

@ecv ecv left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approve.

React Router moves within its minor in both UIs (consumer 8.3.1 to 8.5.1, provider 7.18.2 to 7.18.5), both UI builds pass, and the new scan passes. The red set-month check is the project iteration job, unrelated.

@ecv
ecv merged commit e2d6d6d into datum-cloud:main Nov 19, 2026
10 of 11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants