Repository navigation
fix(ui): Bump React Router in both UIs and add the vuln scan - #660
Merged
ecv merged 2 commits intoNov 19, 2026
Merged
Conversation
The provider UI pinned 7.18.2 and the consumer UI pinned 8.3.1. Both versions fall inside the React Router advisories published on 18 Nov. Both UIs run only in the browser, so the server-side bugs can't reach them, but audits still flag the pins. The provider moves to 7.18.5 and the consumer to 8.5.1.
Nothing in compute checked its npm lockfiles or Go modules against advisory databases, so pinned vulnerable versions went unnoticed until someone looked. Call the shared datum-cloud/actions vuln-scan workflow on pull requests, pushes to main and every Monday.
scotwells
approved these changes
Nov 18, 2026
ecv
approved these changes
Nov 18, 2026
ecv
left a comment
Contributor
There was a problem hiding this comment.
Approve.
React Router moves within its minor in both UIs (consumer 8.3.1 to 8.5.1, provider 7.18.2 to 7.18.5), both UI builds pass, and the new scan passes. The red set-month check is the project iteration job, unrelated.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The provider UI pinned React Router 7.18.2 and the consumer UI pinned 8.3.1, both inside the advisories published on 18 Nov. Both UIs run only in the browser, so the server-side bugs can't reach them, but audits still flag the pins. No CI job scanned compute's npm lockfiles or Go modules.
Solution
The provider moves to 7.18.5 and the consumer to 8.5.1, the oldest releases with every fix. A new workflow runs the shared datum-cloud/actions vuln-scan on pull requests, pushes to main and every Monday. The one Go module hit, GO-2026-6778 in docker/distribution, lives in a registry client package that compute never compiles, so govulncheck will not flag it.
Both UIs typecheck and build, and the consumer tests pass.