Repository navigation
ci: Ignore the picomatch ReDoS advisory until Dec 1 - #1888
Merged
Merged
Conversation
The audit gate is red on GHSA-fc5q-39xc-vjpf, a ReDoS in picomatch up to 4.0.7 with no patched release. It fires only when an attacker supplies the glob pattern, and nothing in datum.net passes user input to picomatch as a pattern: every copy comes from build tooling. Plain npm audit has no ignore list, so the gate moves to the script auth-ui already uses, extended with expiring ignores. Key changes: - scripts/npm-audit.sh fails on high and critical advisories, as --audit-level=high did, minus ignored GHSA ids - GHSA-id=YYYY-MM-DD lapses on that date, or as soon as the registry has a release past the advisory's <=x.y.z range - ignore GHSA-fc5q-39xc-vjpf until 2026-12-01, with the condition it rests on and the upstream fix PRs next to the entry - scripts/npm-audit.test.sh runs the gate against a stubbed npm: the ignore holds before expiry, lapses on and after it and on a patched release, and a different high advisory still fails; CI runs it first
ecv
marked this pull request as ready for review
November 17, 2026 20:07
yahyafakhroji
approved these changes
Nov 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The audit gate is red on every datum.net PR because of a picomatch ReDoS advisory with no patched release (GHSA-fc5q-39xc-vjpf).
The bug needs an attacker-supplied glob pattern, and datum.net takes every pattern from its own build tooling. It now uses the same expiring ignore list as auth-ui and still fails only on high and critical advisories.
The ignore lapses by itself on 2026-12-01, or sooner once picomatch publishes a release past 4.0.7, and the gate then turns red again.
Important
The ignore holds only while no code passes user-supplied strings to picomatch, micromatch or globby as patterns. Upstream fixes: micromatch/picomatch#254, micromatch/picomatch#246, micromatch/picomatch#194
Test plan
Related to #1887