Skip to content

ci: Ignore the picomatch ReDoS advisory until Dec 1 - #1888

Merged
felixwidjaja merged 1 commit into
mainfrom
ci/picomatch-audit-exception
Nov 18, 2026
Merged

felixwidjaja merged 1 commit into
mainfrom
ci/picomatch-audit-exception

Conversation

@ecv

@ecv ecv commented Nov 17, 2026

Copy link
Copy Markdown
Contributor

Summary

The audit gate is red on every datum.net PR because of a picomatch ReDoS advisory with no patched release (GHSA-fc5q-39xc-vjpf).

The bug needs an attacker-supplied glob pattern, and datum.net takes every pattern from its own build tooling. It now uses the same expiring ignore list as auth-ui and still fails only on high and critical advisories.

The ignore lapses by itself on 2026-12-01, or sooner once picomatch publishes a release past 4.0.7, and the gate then turns red again.

Important

The ignore holds only while no code passes user-supplied strings to picomatch, micromatch or globby as patterns. Upstream fixes: micromatch/picomatch#254, micromatch/picomatch#246, micromatch/picomatch#194

Test plan

  • Gate tests pass on a stubbed npm: the ignore holds before the expiry, lapses on and after it and when a patched release appears, and a different high advisory still fails (14 of 18 cases fail on the old gate)
  • Against the real lockfile, the gate passes today and fails with the date set to 2026-12-01
  • the Code Quality job goes green on this PR

Related to #1887

The audit gate is red on GHSA-fc5q-39xc-vjpf, a ReDoS in picomatch up to
4.0.7 with no patched release. It fires only when an attacker supplies the
glob pattern, and nothing in datum.net passes user input to picomatch as a
pattern: every copy comes from build tooling.

Plain npm audit has no ignore list, so the gate moves to the script
auth-ui already uses, extended with expiring ignores.

Key changes:
- scripts/npm-audit.sh fails on high and critical advisories, as
  --audit-level=high did, minus ignored GHSA ids
- GHSA-id=YYYY-MM-DD lapses on that date, or as soon as the registry has a
  release past the advisory's <=x.y.z range
- ignore GHSA-fc5q-39xc-vjpf until 2026-12-01, with the condition it rests
  on and the upstream fix PRs next to the entry
- scripts/npm-audit.test.sh runs the gate against a stubbed npm: the
  ignore holds before expiry, lapses on and after it and on a patched
  release, and a different high advisory still fails; CI runs it first
@ecv
ecv marked this pull request as ready for review November 17, 2026 20:07
@felixwidjaja
felixwidjaja merged commit 41ea263 into main Nov 18, 2026
8 checks passed
@felixwidjaja
felixwidjaja deleted the ci/picomatch-audit-exception branch November 18, 2026 07:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants