Repository navigation
feat(iam): Let organization editors manage service entitlements - #330
Merged
Merged
Conversation
Organization editors can't enable a service such as Compute. Enabling one
creates a ServiceEntitlement in the project, and the request is refused:
serviceentitlements.services.miloapis.com is forbidden: User cannot
create resource "serviceentitlements" in API group
"services.miloapis.com" at the cluster scope
Owners got this grant in 85fb285, but Editor was left out, even though it
already administers Compute, networking and billing. An editor who joins an
organization to deploy a workload has to ask an owner to switch Compute on
first.
Inherit `services.miloapis.com-entitlement-admin` on Editor, matching
Owner. This also lets editors update and delete entitlements, the same as
owners can today.
scotwells
approved these changes
Nov 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Organization editors can't enable a service such as Compute. Enabling a service creates a
ServiceEntitlementin the project, and the Editor role has no permission to create one, so the request fails with a 403. We hit this in production: a customer added a teammate as an Editor so they could deploy a workload, and every attempt to enable Compute was refused until staff enabled it for them.Owners were given this permission in 85fb285. Editor was left out, even though it already has admin on Compute, networking and billing. This change gives Editor the same
services.miloapis.com-entitlement-adminrole.What changes for editors:
datumctl. Enabling a service starts billing for it. Editors already have full billing admin.Test plan
kustomize build config/assignable-organization-rolesrenders, with and without theassistant-accessoverlay that staging and production apply. That overlay appends to the end of the role lists, so adding an entry in the middle doesn't affect it.Active.Notes for reviewers
Merging ships to staging only. Production picks this up on the next release tag.