Skip to content

feat(iam): Let organization editors manage service entitlements - #330

Merged
mattdjenkinson merged 1 commit into
mainfrom
feat/editor-service-entitlements
Nov 16, 2026
Merged

mattdjenkinson merged 1 commit into
mainfrom
feat/editor-service-entitlements

Conversation

@mattdjenkinson

@mattdjenkinson mattdjenkinson commented Nov 16, 2026 •

Copy link
Copy Markdown
Contributor

Summary

Organization editors can't enable a service such as Compute. Enabling a service creates a ServiceEntitlement in the project, and the Editor role has no permission to create one, so the request fails with a 403. We hit this in production: a customer added a teammate as an Editor so they could deploy a workload, and every attempt to enable Compute was refused until staff enabled it for them.

Owners were given this permission in 85fb285. Editor was left out, even though it already has admin on Compute, networking and billing. This change gives Editor the same services.miloapis.com-entitlement-admin role.

What changes for editors:

  • They can enable services in projects in their organization, from the portal or datumctl. Enabling a service starts billing for it. Editors already have full billing admin.
  • They can also update and delete service entitlements, the same as owners. Deleting one turns the service off for that project.
  • Viewers are unchanged.

Test plan

  • kustomize build config/assignable-organization-roles renders, with and without the assistant-access overlay that staging and production apply. That overlay appends to the end of the role lists, so adding an entry in the middle doesn't affect it.
  • After this merges to staging: an organization Editor enables Compute in a project, and the entitlement goes Active.
  • In staging: an organization Viewer is still refused.

Notes for reviewers

Merging ships to staging only. Production picks this up on the next release tag.

Organization editors can't enable a service such as Compute. Enabling one
creates a ServiceEntitlement in the project, and the request is refused:

    serviceentitlements.services.miloapis.com is forbidden: User cannot
    create resource "serviceentitlements" in API group
    "services.miloapis.com" at the cluster scope

Owners got this grant in 85fb285, but Editor was left out, even though it
already administers Compute, networking and billing. An editor who joins an
organization to deploy a workload has to ask an owner to switch Compute on
first.

Inherit `services.miloapis.com-entitlement-admin` on Editor, matching
Owner. This also lets editors update and delete entitlements, the same as
owners can today.
@mattdjenkinson
mattdjenkinson requested a review from a team November 16, 2026 18:37
@mattdjenkinson mattdjenkinson self-assigned this Nov 16, 2026
@mattdjenkinson
mattdjenkinson merged commit f37af42 into main Nov 16, 2026
10 checks passed
@mattdjenkinson
mattdjenkinson deleted the feat/editor-service-entitlements branch November 16, 2026 18:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants