Repository navigation
fix(search): Reuse the existing org and project index policy names - #333
Closed
vvoytovych wants to merge 1 commit into
Closed
vvoytovych wants to merge 1 commit into
vvoytovych wants to merge 1 commit into
Conversation
Staging's Milo already has organization-index-policy and project-index-policy for the Organization and Project resources. The search validator allows one policy for each group, version and kind, so it refuses the two policies of #331, and the datum bundle stops applying on staging. The validator skips a policy with the same name. With the names staging uses, Flux applies over the two existing objects and takes them over. Nothing is deleted, so the search cleanup finalizer does not run and both indexes keep their names. On an environment with no such policies, the two policies are created under these names. On staging, the organization type stops being searchable, as #331 intends. The spec hash of both policies changes, so the search controller re-publishes every organization and project once. Related to: datum-cloud/staff-portal#840
Author
|
Closing this without merging. The fault was not in #331: staging still had two search policies for organizations and projects, applied by hand in March under other names, and Milo allows one policy per kind. We removed those two from staging, so #331's |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Since #331 merged, staging stops applying the datum bundle. Staging's search service already has an organization policy and a project policy under other names, and the search validator allows only one policy for each resource type.
This change gives the two policies from #331 the names staging already uses, so Flux takes over the existing objects in place and deletes nothing.
One search behaviour changes on staging, as #331 intends: the organization type (Personal or Standard) is no longer searchable.
Test plan
Before this change it prints:
The last box has one read, in staging's metrics:
Now neither Kustomization reports
ready="True". After merge, both reportready="True", anddatum-milo-customizationreports a newv0.0.0-mainrevision.Related to #331
Related to datum-cloud/staff-portal#840