Skip to content

feat: Deprecate five plugins moved to the Milo catalog - #267

Merged
0xmc merged 1 commit into
mainfrom
feat/266-deprecate-milo-entries
Nov 18, 2026
Merged

0xmc merged 1 commit into
mainfrom
feat/266-deprecate-milo-entries

Conversation

@0xmc

@0xmc 0xmc commented Nov 18, 2026

Copy link
Copy Markdown
Contributor

Summary

Five plugins listed here are now maintained in milo-os/cli-plugins, and removing their entries outright would break upgrade for everyone who installed them from this catalog.

Each entry now says it is deprecated and names the Milo catalog as its replacement, so datumctl v0.25.0 and later warns users and shows the commands to switch, while older releases keep working unchanged.

The README marks the five as deprecated, and #237 removes the entries later.

Test plan

  • The index rebuilt from these manifests differs from the current one only by the five deprecation blocks, and catalog validation passes with datumctl v0.23.3, a pre-deprecation build, and v0.25.0
  • A pre-deprecation datumctl installs, upgrades, and installs every plugin from this catalog with no warnings
  • datumctl v0.25.0 warns on install and upgrade with the switch commands, and installing every plugin skips the deprecated ones

Fixes #266

🤖 Generated with Claude Code

assistant, billing, ipam, search, and telemetry also live in
milo-os/cli-plugins, which is where they are maintained from now on.
Removing them here outright would break upgrade for everyone who
installed them from this catalog.

Each entry now carries a deprecated block naming milo-os/cli-plugins
as the replacement catalog. datumctl v0.25.0 and later shows a
warning with the commands to add that catalog and install from it,
skips these plugins in install --all-available for users who don't
have them, and lets a bare-name install prefer the replacement once
the Milo catalog is added. Older datumctl releases ignore the field
and keep installing and upgrading from here. The release automation
only rewrites version, download URLs, and checksums, so the block
survives future updates.

The README marks the five plugins deprecated and shows how to
switch. index.yaml regenerates from these manifests after merge.

Resolves: #266

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@0xmc 0xmc changed the title feat: Point the Milo plugin entries at the Milo catalog feat: Deprecate five plugins moved to the Milo catalog Nov 18, 2026
@0xmc
0xmc marked this pull request as ready for review November 18, 2026 21:08
@0xmc
0xmc requested a review from a team as a code owner November 18, 2026 21:08
@0xmc
0xmc enabled auto-merge November 18, 2026 21:08
@0xmc

0xmc commented Nov 18, 2026

Copy link
Copy Markdown
Contributor Author

Two reviewers agreed on head 5df6437.

pr-adversary: VERDICT merge, no findings. It ran: gh pr view; git log/diff 17ecd49...5df6437; gh pr checks; datumctl validate, index add, install, list, upgrade and install --all-available in a temp plugins dir against a local index copy with the five deprecated blocks (datumctl v0.25.0: validate OK for 9 plugins; install warns with both switch commands; list shows STATUS deprecated; upgrade warns; install --all-available skips deprecated plugins not installed); gh api on milo-os/cli-plugins (public, has all five plugins); gh issue view 237 and 266. Older datumctl builds were not tested.

pr-conventions-reviewer: VERDICT merge. It ran: cat CLAUDE.md (absent); gh pr view; git diff 17ecd49...5df6437; gh pr list for overlap. Its warning that the title described the mechanism was applied by retitling to "feat: Deprecate five plugins moved to the Milo catalog". Two nits were not applied: commit subject length (54 chars) and "Resolves: #266" versus "Fixes #266"; both close the issue.

CI: ci / Build and test and license/cla both passed on the head.

Auto-merge is enabled with the merge method, because the base-branch ruleset allows only merge, not squash. The commit subject on main will therefore be the merge commit's, not the PR title. The ruleset requires one approving review including a code owner, so the PR waits for a human approval.

@ecv ecv left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approve.

Each of the five entries gets a deprecated block with a message and replacement.catalog: milo-os/cli-plugins, which is what datumctl's validator now requires, and all five plugins exist in that catalog. index.yaml is rebuilt on merge by the rebuild workflow, so the warning reaches users once that follow-up merges. Releases before v0.25.0 ignore the block and keep installing from here.

@0xmc
0xmc merged commit 0356e88 into main Nov 18, 2026
2 checks passed
@0xmc
0xmc deleted the feat/266-deprecate-milo-entries branch November 18, 2026 21:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Point the Milo plugin entries at the Milo catalog

2 participants