Skip to content

feat: Let catalog entries declare a deprecation - #373

Merged
0xmc merged 1 commit into
mainfrom
feat/367-plugin-deprecation-format
Nov 17, 2026
Merged

0xmc merged 1 commit into
mainfrom
feat/367-plugin-deprecation-format

Conversation

@0xmc

@0xmc 0xmc commented Nov 17, 2026 •

Copy link
Copy Markdown
Contributor

Summary

Removing a plugin from a catalog breaks upgrade for everyone who installed it, and nothing tells them where the plugin went.

A catalog entry can now mark itself deprecated and name a replacement plugin in another catalog, and catalog validation flags an incomplete deprecation.

This opens a stack for #355, and later PRs show the notice in each plugin command.

Test plan

  • A build from main installs, upgrades, and lists a plugin whose catalog entry carries a deprecation
  • Catalog validation rejects a deprecation with no message and accepts a complete one
  • Build, vet, and the plugin store tests pass

Fixes #367

🤖 Generated with Claude Code

@0xmc 0xmc changed the title feat: Let catalog entries mark a plugin as deprecated feat: Let catalog entries declare a deprecation Nov 17, 2026
Removing a plugin from a catalog breaks upgrade for everyone who
installed it, and nothing tells them where the plugin went.

Catalog entries can now carry an optional spec.deprecated block with
a message and a replacement plugin in another catalog. The
replacement names a catalog source rather than a catalog name,
because users pick their own names when they add a catalog.
SameCatalogSource resolves two sources and compares them, so later
changes can recognize a replacement catalog the user already added.
GitHub sources match by owner and repository, ignoring case and
branch, since GitHub treats those as one repository.

plugin index validate reports a deprecation with no message or no
replacement catalog. The field is additive, and datumctl parses
catalogs without rejecting unknown fields, so older releases keep
installing and upgrading deprecated plugins.

Resolves: #367

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@0xmc
0xmc force-pushed the feat/367-plugin-deprecation-format branch from af391f7 to 90d42ce Compare November 17, 2026 17:21
@0xmc
0xmc marked this pull request as ready for review November 17, 2026 17:37
@0xmc
0xmc requested a review from a team as a code owner November 17, 2026 17:37
@0xmc
0xmc enabled auto-merge November 17, 2026 17:37
@0xmc

0xmc commented Nov 17, 2026

Copy link
Copy Markdown
Contributor Author

Second-pass review of this PR found no open defects.

pr-conventions-reviewer: VERDICT merge. Its two nits were to squash the fix commit into the first commit and to reword "stranding" in the summary. Both are done.

pr-rereviewer: it confirmed all three applied findings fixed, including a tamper test of the case-insensitive owner/repo match. Its only open item was a warning that the fix commit trailer said "Claude Opus 5.5" rather than "Claude Sonnet 5.5". Its verdict was hold on that item alone. The session overruled it: Opus 5.5 is the attribution this session is configured with. The fix commit was then squashed into the first commit, so the head (90d42ce) has the same tree the reviewer checked.

What each reviewer ran: the findings re-check against the fixed head, including the owner/repo tamper test, and the conventions check of the commits and PR body. The full RAN lists are in the second-pass reports.

Applied findings: the three fixes from the first pass, now part of the squashed first commit.

CI on 90d42ce: ci / Build and test passed, license/cla passed.

Auto-merge is enabled with the merge method (the only one the ruleset allows). The ruleset requires one approving review, code owner review, and approval of the last push, so it waits for a human approval.

PRs #374 and #375 are stacked on this one.

@0xmc
0xmc merged commit 4629ef7 into main Nov 17, 2026
2 checks passed
@0xmc
0xmc deleted the feat/367-plugin-deprecation-format branch November 17, 2026 17:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Catalogs can't mark a plugin as deprecated

2 participants