Repository navigation
feat: Let catalog entries declare a deprecation - #373
Conversation
Removing a plugin from a catalog breaks upgrade for everyone who installed it, and nothing tells them where the plugin went. Catalog entries can now carry an optional spec.deprecated block with a message and a replacement plugin in another catalog. The replacement names a catalog source rather than a catalog name, because users pick their own names when they add a catalog. SameCatalogSource resolves two sources and compares them, so later changes can recognize a replacement catalog the user already added. GitHub sources match by owner and repository, ignoring case and branch, since GitHub treats those as one repository. plugin index validate reports a deprecation with no message or no replacement catalog. The field is additive, and datumctl parses catalogs without rejecting unknown fields, so older releases keep installing and upgrading deprecated plugins. Resolves: #367 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
af391f7 to
90d42ce
Compare
|
Second-pass review of this PR found no open defects. pr-conventions-reviewer: VERDICT merge. Its two nits were to squash the fix commit into the first commit and to reword "stranding" in the summary. Both are done. pr-rereviewer: it confirmed all three applied findings fixed, including a tamper test of the case-insensitive owner/repo match. Its only open item was a warning that the fix commit trailer said "Claude Opus 5.5" rather than "Claude Sonnet 5.5". Its verdict was hold on that item alone. The session overruled it: Opus 5.5 is the attribution this session is configured with. The fix commit was then squashed into the first commit, so the head (90d42ce) has the same tree the reviewer checked. What each reviewer ran: the findings re-check against the fixed head, including the owner/repo tamper test, and the conventions check of the commits and PR body. The full RAN lists are in the second-pass reports. Applied findings: the three fixes from the first pass, now part of the squashed first commit. CI on 90d42ce: ci / Build and test passed, license/cla passed. Auto-merge is enabled with the merge method (the only one the ruleset allows). The ruleset requires one approving review, code owner review, and approval of the last push, so it waits for a human approval. |
Summary
Removing a plugin from a catalog breaks upgrade for everyone who installed it, and nothing tells them where the plugin went.
A catalog entry can now mark itself deprecated and name a replacement plugin in another catalog, and catalog validation flags an incomplete deprecation.
This opens a stack for #355, and later PRs show the notice in each plugin command.
Test plan
Fixes #367
🤖 Generated with Claude Code