Repository navigation
chore: move to go.miloapis.com/dns v0.16.0 - #916
Merged
Merged
Conversation
The dns-operator module is now go.miloapis.com/dns, published from datum-cloud/dns. Update the imports and require v0.16.0, the first release under the new path.
scotwells
marked this pull request as ready for review
November 17, 2026 22:45
ecv
approved these changes
Nov 17, 2026
ecv
left a comment
Contributor
There was a problem hiding this comment.
Approve.
Beyond the import rename, the PR swaps the test-infra CRD bundle, regenerates NOTICE and raises go.mod dependencies, but v0.16.0 changes no API or behaviour; ci / Build and test, the Karmada two-cluster check, Run on Ubuntu and Verify Generated Files pass at 23939ff.
- Rename sweep: every dnsv1alpha1 import in manager.go, the gateway and httpproxy DNS controllers and their tests moves to go.miloapis.com/dns/api/v1alpha1; no logic changes, and the 57 DNSRecordSet and 43 DNSZone uses compile unchanged. go.mod has no dns-operator require or replace.
- v0.15.0 to v0.16.0 is rename-only by the release notes (compare touches 334 files, 617 lines in, 617 out). The real API change is v0.5.1 to v0.15.0, and it is additive: DNSZone gains immutable Visibility (default Public), DNSZoneClassName becomes optional, RecordCount now counts records, plus new CRDs. NSO sets none of these, so it behaves the same.
- Taskfile.test-infra.yml moves DNS_BUNDLE_REPO to ghcr.io/datum-cloud/dns-kustomize at v0.16.0 pinned by digest, which is what the test-infra CRDs install in CI; the new CRDs load and the e2e checks pass. NOTICE swaps the module entry from License Unknown to AGPL-3.0 with the full text, which explains its +673 lines.
- Compatibility with the deployed operator: production runs dns-operator v0.15.0 and staging tracks main, and v0.16.0 has the same CRDs and types as v0.15.0, so this client works against either.
- go.mod raises more than the body says: datumctl v0.18.1 to v0.23.3, milo v0.36.9 to v0.36.22, activity v0.7.1 to v0.7.4, go-sdk v1.7.0 to v1.8.0, ginkgo 2.32 to 2.34 (dns v0.16.0 requires datumctl v0.23.3 and milo v0.36.22; the rest come with them). Tests pass, so no hold.
Follow-ups:
- internal/util/dns/nameserver.go HasDNSAuthority does not check DNSZone.Spec.Visibility, so a Private zone with the same domain could count as authority for a Domain. Pre-existing against the v0.15.0 operator, not caused here; add a Public filter.
- Production infra still points OCIRepository at oci://ghcr.io/datum-cloud/dns-operator-kustomize (apps/dns-operator pins v0.15.0, base semver '>= 0.x'). v0.16.0 and later are published only as dns-kustomize, so the infra pin moves with a URL change, not just a tag.
kevwilliams
approved these changes
Nov 18, 2026
kevwilliams
left a comment
Contributor
There was a problem hiding this comment.
Verified no old import path remains, the CRD bundle digest matches v0.16.0, and the zone fields and condition reasons the operator reads are unchanged.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Requested by Scot Schuchert-Wells · project thread
The dns-operator Go module is now
go.miloapis.com/dns, published fromdatum-cloud/dns. v0.16.0 is the first release under the new path, and the old path gets no new tags.go.miloapis.com/dns-operatortogo.miloapis.com/dns, and go.mod requires v0.16.0.ghcr.io/datum-cloud/dns-kustomizev0.16.0, pinned by digest, so the CRDs installed match the types compiled against.