Skip to content

fix(ui): Bump React Router to 8.5.1 and add the vuln scan - #923

Merged
ecv merged 2 commits into
datum-cloud:mainfrom
yahyafakhroji:fix/dependency-vulnerabilities
Nov 19, 2026
Merged

ecv merged 2 commits into
datum-cloud:mainfrom
yahyafakhroji:fix/dependency-vulnerabilities

Conversation

@yahyafakhroji

Copy link
Copy Markdown
Contributor

Problem
The consumer UI pinned React Router 8.3.1, which falls inside the advisories published on 18 Nov. No CI job scanned the npm lockfile or the Go modules.

Solution
The consumer UI moves to 8.5.1. A new workflow runs the shared datum-cloud/actions vuln-scan on pull requests, pushes to main and every Monday, across npm and Go. CI picks go1.27.4 from the root toolchain directive, which already fixes the net/http finding (GO-2026-6859) in the connector-tunnel test fixture. govulncheck finds no reachable call into the containerd, karmada and otel module hits.

The consumer UI typechecks, its tests pass, and it builds.

The consumer UI pinned 8.3.1, which falls inside the React Router
advisories published on 18 Nov. 8.5.1 carries the fixes.
Nothing checked the npm lockfiles or Go modules against advisory
databases. Call the shared vuln-scan workflow from datum-cloud/actions
on pull requests, pushes to main and a weekly schedule.
@yahyafakhroji
yahyafakhroji requested a review from a team as a code owner November 18, 2026 23:17

@ecv ecv left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approve.

React Router 8.3.1 to 8.5.1 in the consumer UI, with the lockfile in step, and the new vulnerability scan passes.

@ecv
ecv merged commit cb871d8 into datum-cloud:main Nov 19, 2026
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants