Repository navigation
fix(ui): Bump React Router to 8.5.1 and add the vuln scan - #923
Merged
ecv merged 2 commits intoNov 19, 2026
Merged
Conversation
The consumer UI pinned 8.3.1, which falls inside the React Router advisories published on 18 Nov. 8.5.1 carries the fixes.
Nothing checked the npm lockfiles or Go modules against advisory databases. Call the shared vuln-scan workflow from datum-cloud/actions on pull requests, pushes to main and a weekly schedule.
scotwells
approved these changes
Nov 18, 2026
ecv
approved these changes
Nov 18, 2026
ecv
left a comment
Contributor
There was a problem hiding this comment.
Approve.
React Router 8.3.1 to 8.5.1 in the consumer UI, with the lockfile in step, and the new vulnerability scan passes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The consumer UI pinned React Router 8.3.1, which falls inside the advisories published on 18 Nov. No CI job scanned the npm lockfile or the Go modules.
Solution
The consumer UI moves to 8.5.1. A new workflow runs the shared datum-cloud/actions vuln-scan on pull requests, pushes to main and every Monday, across npm and Go. CI picks go1.27.4 from the root toolchain directive, which already fixes the net/http finding (GO-2026-6859) in the connector-tunnel test fixture. govulncheck finds no reachable call into the containerd, karmada and otel module hits.
The consumer UI typechecks, its tests pass, and it builds.