[search] Make regex matching default [FCOM-12] - #1136
Merged
Conversation
Make regular-expression matching the default for search strings and replace the `-r`/`--regex` flags with `-F`/`--fixed-strings` for users who need literal matching. The query pipeline must keep using a composite `rg` expression so that commit and diff headers remain available to the parser. Fixed-string searches therefore escape the user pattern before embedding it in that expression. When the querier invokes `fcom` in parse mode, it forwards `--fixed-strings` so the parser applies the same matching semantics. Update the executable help examples, README help snapshot, and unreleased changelog entry to document the breaking default. codex resume 01a04957-3702-7290-846b-e8ff8330a979
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Make regular-expression matching the default for search strings and replace the
-r/--regexflags with-F/--fixed-stringsfor users who need literal matching.The query pipeline must keep using a composite
rgexpression so that commit and diff headers remain available to the parser. Fixed-string searches therefore escape the user pattern before embedding it in that expression. When the querier invokesfcomin parse mode, it forwards--fixed-stringsso the parser applies the same matching semantics.Update the executable help examples, README help snapshot, and unreleased changelog entry to document the breaking default.
codex resume 01a04957-3702-7290-846b-e8ff8330a979