[querier] Ignore diff context matches [FCOM-14] - #1138
Merged
Conversation
Git emits three lines of patch context by default. Because the `rg` stage searched every emitted line, a match in unchanged context could make `fcom` print a commit or file without a matching added or removed line. Request zero context lines with Git `--unified=0` and keep the command contract covered by the existing `Fcom::Querier` spec. This preserves changed-line output while preventing context-only results. codex resume 01a04984-da1c-7712-bcfb-a9a54ee38a12
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Git emits three lines of patch context by default. Because the
rgstage searched every emitted line, a match in unchanged context could makefcomprint a commit or file without a matching added or removed line.Request zero context lines with Git
--unified=0and keep the command contract covered by the existingFcom::Querierspec. This preserves changed-line output while preventing context-only results.codex resume 01a04984-da1c-7712-bcfb-a9a54ee38a12