[parser] Ignore diff file headers [FCOM-16] - #1140
Merged
Merged
Conversation
Git emits `---` and `+++` metadata lines before each patch hunk. When a search expression matches a path component such as `file` in `Gemfile.lock`, the parser previously treated those headers as changed lines and printed an otherwise unrelated commit. Skip diff file headers after recording the filename from `diff --git`. This preserves filename output for real added or removed lines while preventing header-only matches. Add a parser regression covering the `path|file` search that previously matched `Gemfile.lock` headers. codex resume 01a049a6-68c1-7360-90e2-13ff6064e6cb
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Git emits
---and+++metadata lines before each patch hunk. When a search expression matches a path component such asfileinGemfile.lock, the parser previously treated those headers as changed lines and printed an otherwise unrelated commit.Skip diff file headers after recording the filename from
diff --git. This preserves filename output for real added or removed lines while preventing header-only matches.Add a parser regression covering the
path|filesearch that previously matchedGemfile.lockheaders.codex resume 01a049a6-68c1-7360-90e2-13ff6064e6cb