[fix] KeyError crash when completing right after USE#1934
Merged
scottnemes merged 1 commit intoJun 17, 2026
Merged
Conversation
rolandwalker
approved these changes
Jun 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Issue
Running USE immediately points the live completer at the new schema so unqualified completions reflect the switch, but that schema's tables are still loading on a background thread. If you triggered a completion in that window, mycli crashed:
To reproduce (difficult unless you have a large database and/or slow computer):
Fix
populate_scoped_cols now reads the per-schema metadata with meta["tables"].get(self.dbname, {}), snapshotting it once. During the load window it suggests * instead of raising an error, and shows real columns once the refresh completes. Grabbing the reference once also avoids a concurrent refresh swapping the dict out mid-iteration.
Added regression tests in test_completer_use_switch.py covering the unloaded-schema window, the post-load result, and concurrent USE switching.
Fixes #1933
Checklist
changelog.mdfile.AUTHORSfile (or it's already there).