Skip to content

360 design review - #1048

Open
jeffjensen wants to merge 187 commits into
mainfrom
360-design-review
Open

jeffjensen wants to merge 187 commits into
mainfrom
360-design-review

Conversation

@jeffjensen

Copy link
Copy Markdown
Member

No description provided.

* Install the executor's operation listener only on a tester that
  overrides IDatabaseTester.getOperationListener(), so the listener it
  carries can be wrapped and put back after the test.
* Leave the listener of a tester that does not override it exactly as
  configured, instead of replacing it with a closing one that stays
  installed for good and discards, for example, the no-op listener
  marking its connections as managed elsewhere.
* Capture the row count check baseline eagerly for such a tester, as
  there is no executor listener to piggyback on.
* Document in the IOperationListener and annotations pages, the latter's
  properties section included, that the @DbUnitProperty values then
  reach only the connection the extension resolves itself, not one the
  tester's own onSetup() retrieves.

Refs: 753
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01Q55xijb8HCBhpVuuV644ms

@sourcery-ai sourcery-ai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry @jeffjensen, this pull request is too large to review

It changes 302 files. Sourcery can review pull requests with up to 300 changed files.

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Nov 11, 2026 •

Copy link
Copy Markdown
Codex Review Summary: ❌ Failed

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ❌ Failed 2026-11-18T22:22:32.871757Z
We couldn’t complete this review. Comment @codex review to try again.
c561014 New commits
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@coderabbitai

coderabbitai Bot commented Nov 11, 2026 •

Copy link
Copy Markdown

Important

Review skipped

Too many files!

This PR contains 352 files, which is 252 over the limit of 100.

To get a review, reduce the PR to 100 files or fewer by splitting it into smaller PRs or changing its base branch.

Upgrade to a paid plan to raise the limit.

Usage-priced reviews support at most 300 files.

Run configuration

Commits

Reviewing files that changed from the base of the PR and between feb1dab and c561014.

Files selected for processing: 352

  • .coderabbit.yml
  • .github/workflows/build-any-branch-with-all-dbs.yml
  • CLAUDE.md
  • pom.xml
  • src/changes/changes.xml
  • src/main/java/org/dbunit/AbstractDatabaseTester.java
  • src/main/java/org/dbunit/ConnectionPreservingOperationListener.java
  • src/main/java/org/dbunit/DataSourceDatabaseTester.java
  • src/main/java/org/dbunit/DatabaseTesterFactory.java
  • src/main/java/org/dbunit/DefaultDatabaseTester.java
  • src/main/java/org/dbunit/DefaultPrepAndExpectedTestCase.java
  • src/main/java/org/dbunit/FreshTableColumns.java
  • src/main/java/org/dbunit/IDatabaseTester.java
  • src/main/java/org/dbunit/IOperationListener.java
  • src/main/java/org/dbunit/JdbcDatabaseTester.java
  • src/main/java/org/dbunit/JndiDatabaseTester.java
  • src/main/java/org/dbunit/MultiDataSourceAssertionError.java
  • src/main/java/org/dbunit/MultiDataSourcePrepAndExpectedTestCase.java
  • src/main/java/org/dbunit/PrepAndExpectedTestCase.java
  • src/main/java/org/dbunit/PrepAndExpectedTestData.java
  • src/main/java/org/dbunit/VerifyColumnNamesCheck.java
  • src/main/java/org/dbunit/VerifyTableDefinition.java
  • src/main/java/org/dbunit/VerifyTableDefinitionsProvider.java
  • src/main/java/org/dbunit/annotation/DbUnitColumnComparer.java
  • src/main/java/org/dbunit/annotation/DbUnitConfig.java
  • src/main/java/org/dbunit/annotation/DbUnitExpected.java
  • src/main/java/org/dbunit/annotation/DbUnitPrep.java
  • src/main/java/org/dbunit/annotation/DbUnitProperty.java
  • src/main/java/org/dbunit/annotation/DbUnitRowCountCheck.java
  • src/main/java/org/dbunit/annotation/DbUnitSetUpOperation.java
  • src/main/java/org/dbunit/annotation/DbUnitSetup.java
  • src/main/java/org/dbunit/annotation/DbUnitTearDown.java
  • src/main/java/org/dbunit/annotation/DbUnitTearDownOperation.java
  • src/main/java/org/dbunit/annotation/DbUnitTestCase.java
  • src/main/java/org/dbunit/annotation/DbUnitVerifyTable.java
  • src/main/java/org/dbunit/annotation/runtime/AnnotatedTestConfiguration.java
  • src/main/java/org/dbunit/annotation/runtime/AnnotatedTestExecutor.java
  • src/main/java/org/dbunit/annotation/runtime/AnnotatedTestOptIn.java
  • src/main/java/org/dbunit/annotation/runtime/AnnotationLookup.java
  • src/main/java/org/dbunit/annotation/runtime/ClassicLifecycle.java
  • src/main/java/org/dbunit/annotation/runtime/ClassicOperationListener.java
  • src/main/java/org/dbunit/annotation/runtime/ClassicRowCountCheck.java
  • src/main/java/org/dbunit/annotation/runtime/DataFileLoaderInstances.java
  • src/main/java/org/dbunit/annotation/runtime/DataSetPathsResolver.java
  • src/main/java/org/dbunit/annotation/runtime/DataSetResourcePathResolver.java
  • src/main/java/org/dbunit/annotation/runtime/DatabaseConfigPropertiesResolver.java
  • src/main/java/org/dbunit/annotation/runtime/DeclaredMethodsOfHierarchy.java
  • src/main/java/org/dbunit/annotation/runtime/DefaultMethodOverrideCheck.java
  • src/main/java/org/dbunit/annotation/runtime/ExecutorOperationListener.java
  • src/main/java/org/dbunit/annotation/runtime/ExpectedLifecycle.java
  • src/main/java/org/dbunit/annotation/runtime/FixedConnectionCheck.java
  • src/main/java/org/dbunit/annotation/runtime/InjectedTestCaseConfigurer.java
  • src/main/java/org/dbunit/annotation/runtime/InjectedTestCaseDeclarationCheck.java
  • src/main/java/org/dbunit/annotation/runtime/InjectedTestCaseTesterBinding.java
  • src/main/java/org/dbunit/annotation/runtime/LifecycleMethodAnnotationCheck.java
  • src/main/java/org/dbunit/annotation/runtime/MergedDbUnitConfig.java
  • src/main/java/org/dbunit/annotation/runtime/ProvidedAttribute.java
  • src/main/java/org/dbunit/annotation/runtime/ReflectiveInstantiation.java
  • src/main/java/org/dbunit/annotation/runtime/SetupTeardownLifecycle.java
  • src/main/java/org/dbunit/annotation/runtime/TableNameKey.java
  • src/main/java/org/dbunit/annotation/runtime/TestCaseConfigurer.java
  • src/main/java/org/dbunit/annotation/runtime/TestCaseLifecycle.java
  • src/main/java/org/dbunit/annotation/runtime/TestCaseRestoration.java
  • src/main/java/org/dbunit/annotation/runtime/TestInstanceTesterResolver.java
  • src/main/java/org/dbunit/annotation/runtime/TesterFields.java
  • src/main/java/org/dbunit/annotation/runtime/TesterStateSnapshot.java
  • src/main/java/org/dbunit/annotation/runtime/VerifyTableDefinitionCatalog.java
  • src/main/java/org/dbunit/annotation/runtime/VerifyTableDefinitionResolver.java
  • src/main/java/org/dbunit/assertion/DiffCollectingFailureHandler.java
  • src/main/java/org/dbunit/assertion/comparer/value/CompiledPatternCache.java
  • src/main/java/org/dbunit/assertion/comparer/value/ConditionalSelectorMultiValueComparer.java
  • src/main/java/org/dbunit/assertion/comparer/value/ConditionalSetBiValueComparer.java
  • src/main/java/org/dbunit/assertion/comparer/value/IsActualContainingExpectedStringValueComparer.java
  • src/main/java/org/dbunit/assertion/comparer/value/IsActualEqualToExpectedJsonValueComparer.java
  • src/main/java/org/dbunit/assertion/comparer/value/IsActualNotEqualToExpectedValueComparer.java
  • src/main/java/org/dbunit/assertion/comparer/value/IsActualNotNullValueComparer.java
  • src/main/java/org/dbunit/assertion/comparer/value/IsActualNullValueComparer.java
  • src/main/java/org/dbunit/assertion/comparer/value/NeverFailsValueComparer.java
  • src/main/java/org/dbunit/assertion/comparer/value/RegularExpressionValueComparer.java
  • src/main/java/org/dbunit/assertion/comparer/value/ValueComparer.java
  • src/main/java/org/dbunit/database/DatabaseConfig.java
  • src/main/java/org/dbunit/database/DatabaseConfigOverrides.java
  • src/main/java/org/dbunit/database/DatabaseConfigPropertiesProvider.java
  • src/main/java/org/dbunit/database/DatabaseDataSet.java
  • src/main/java/org/dbunit/database/IMetadataHandler.java
  • src/main/java/org/dbunit/database/QuotedColumnsTableMetaData.java
  • src/main/java/org/dbunit/database/connection/AutoCommitOffWarning.java
  • src/main/java/org/dbunit/database/connection/ClosedConnectionHandedOutWarning.java
  • src/main/java/org/dbunit/database/connection/ClosedFixedConnectionWarning.java
  • src/main/java/org/dbunit/database/connection/ConnectionOwnership.java
  • src/main/java/org/dbunit/database/connection/LeftOpenConnectionWarning.java
  • src/main/java/org/dbunit/database/connection/TestScopedConnection.java
  • src/main/java/org/dbunit/database/connection/UsedTesters.java
  • src/main/java/org/dbunit/database/connection/WarnedTesters.java
  • src/main/java/org/dbunit/database/rowcount/CurrentSchemaConnection.java
  • src/main/java/org/dbunit/database/rowcount/QueryPerTableRowCounter.java
  • src/main/java/org/dbunit/database/rowcount/RowCountBaselineTracker.java
  • src/main/java/org/dbunit/database/rowcount/RowCountCheck.java
  • src/main/java/org/dbunit/database/rowcount/RowCountCheckConfiguration.java
  • src/main/java/org/dbunit/database/rowcount/RowCountCheckOverride.java
  • src/main/java/org/dbunit/database/rowcount/RowCountChecker.java
  • src/main/java/org/dbunit/database/rowcount/RowCountDifference.java
  • src/main/java/org/dbunit/database/rowcount/RowCounter.java
  • src/main/java/org/dbunit/dataset/JdbcEscapeText.java
  • src/main/java/org/dbunit/dataset/RequiredLibrary.java
  • src/main/java/org/dbunit/dataset/datatype/BigIntegerDataType.java
  • src/main/java/org/dbunit/dataset/datatype/BytesDataType.java
  • src/main/java/org/dbunit/dataset/datatype/DateDataType.java
  • src/main/java/org/dbunit/dataset/datatype/IntegerDataType.java
  • src/main/java/org/dbunit/dataset/datatype/IsoTimestampText.java
  • src/main/java/org/dbunit/dataset/datatype/LongDataType.java
  • src/main/java/org/dbunit/dataset/datatype/NumberDataType.java
  • src/main/java/org/dbunit/dataset/datatype/TimestampDataType.java
  • src/main/java/org/dbunit/dataset/datatype/ToleratedDeltaMap.java
  • src/main/java/org/dbunit/dataset/excel/XlsDataSet.java
  • src/main/java/org/dbunit/dataset/excel/XlsTable.java
  • src/main/java/org/dbunit/dataset/json/JsonDataSet.java
  • src/main/java/org/dbunit/dataset/json/JsonProducer.java
  • src/main/java/org/dbunit/dataset/json/JsonWriter.java
  • src/main/java/org/dbunit/dataset/yaml/YamlDataSet.java
  • src/main/java/org/dbunit/dataset/yaml/YamlProducer.java
  • src/main/java/org/dbunit/dataset/yaml/YamlWriter.java
  • src/main/java/org/dbunit/ext/h2/H2DataTypeFactory.java
  • src/main/java/org/dbunit/ext/h2/H2JsonType.java
  • src/main/java/org/dbunit/ext/mysql/MultiSchemaMySqlMetadataHandler.java
  • src/main/java/org/dbunit/ext/mysql/MySqlMetadataHandler.java
  • src/main/java/org/dbunit/junit/jupiter/ContextAnnotationLookup.java
  • src/main/java/org/dbunit/junit/jupiter/DbUnitExtension.java
  • src/main/java/org/dbunit/junit/jupiter/DbUnitTest.java
  • src/main/java/org/dbunit/junit/jupiter/DeclarationsFinder.java
  • src/main/java/org/dbunit/junit/jupiter/DeclaringClassFinder.java
  • src/main/java/org/dbunit/junit/jupiter/EnclosingTestClasses.java
  • src/main/java/org/dbunit/junit/jupiter/JupiterLifecycleMethods.java
  • src/main/java/org/dbunit/junit/jupiter/SpringTestTransactionCheck.java
  • src/main/java/org/dbunit/junit/jupiter/TesterResolver.java
  • src/main/java/org/dbunit/operation/DbUnitOperation.java
  • src/main/java/org/dbunit/spring/DbUnitSpringTest.java
  • src/main/java/org/dbunit/spring/DbUnitTestExecutionListener.java
  • src/main/java/org/dbunit/spring/SpringAnnotationLookup.java
  • src/main/java/org/dbunit/spring/SpringLifecycleMethods.java
  • src/main/java/org/dbunit/spring/SpringTesterResolver.java
  • src/main/java/org/dbunit/util/CommaSeparatedValues.java
  • src/main/java/org/dbunit/util/fileloader/CachingDataFileLoader.java
  • src/main/java/org/dbunit/util/fileloader/CachingFileExtensionDataFileLoader.java
  • src/main/java/org/dbunit/util/fileloader/DataSetPathsProvider.java
  • src/main/java/org/dbunit/util/fileloader/FileExtensionDataFileLoader.java
  • src/main/java/org/dbunit/util/fileloader/FullXmlFileShape.java
  • src/main/java/org/dbunit/util/fileloader/JsonDataFileLoader.java
  • src/main/java/org/dbunit/util/fileloader/XlsDataFileLoader.java
  • src/main/java/org/dbunit/util/fileloader/YamlDataFileLoader.java
  • src/main/resources/META-INF/spring.factories
  • src/site/asciidoc/anttask.adoc
  • src/site/asciidoc/building.adoc
  • src/site/asciidoc/codingstandards/testconventions.adoc
  • src/site/asciidoc/components.adoc
  • src/site/asciidoc/components/imetadatahandler.adoc
  • src/site/asciidoc/components/ioperationlistener.adoc
  • src/site/asciidoc/components/rowcountcheck.adoc
  • src/site/asciidoc/components/verifytabledefinition.adoc
  • src/site/asciidoc/connections.adoc
  • src/site/asciidoc/databases.adoc
  • src/site/asciidoc/databases/h2.adoc
  • src/site/asciidoc/databases/mariadb.adoc
  • src/site/asciidoc/databases/mysql.adoc
  • src/site/asciidoc/databases/postgresql.adoc
  • src/site/asciidoc/datacomparisons/failurehandling.adoc
  • src/site/asciidoc/datacomparisons/valuecomparer.adoc
  • src/site/asciidoc/datasets.adoc
  • src/site/asciidoc/datasets/csv.adoc
  • src/site/asciidoc/datasets/excel.adoc
  • src/site/asciidoc/datasets/fileloader.adoc
  • src/site/asciidoc/datasets/flatxml.adoc
  • src/site/asciidoc/datasets/json.adoc
  • src/site/asciidoc/datasets/streaming.adoc
  • src/site/asciidoc/datasets/values.adoc
  • src/site/asciidoc/datasets/xml.adoc
  • src/site/asciidoc/datasets/yaml.adoc
  • src/site/asciidoc/fiveminutes.adoc
  • src/site/asciidoc/github/continuousintegration.adoc
  • src/site/asciidoc/index.adoc
  • src/site/asciidoc/properties.adoc
  • src/site/asciidoc/testcases/DbUnitExtension.adoc
  • src/site/asciidoc/testcases/DbUnitTestExecutionListener.adoc
  • src/site/asciidoc/testcases/IDatabaseTester.adoc
  • src/site/asciidoc/testcases/JdbcBasedDBTestCase.adoc
  • src/site/asciidoc/testcases/MigratingToIDatabaseTester.adoc
  • src/site/asciidoc/testcases/MultiDataSourcePrepAndExpectedTestCase.adoc
  • src/site/asciidoc/testcases/PrepAndExpectedTestCase.adoc
  • src/site/asciidoc/testcases/annotations.adoc
  • src/site/fml/faq.fml
  • src/site/site.xml
  • src/test/java/org/dbunit/AbstractDatabaseTesterIT.java
  • src/test/java/org/dbunit/AbstractDatabaseTesterTest.java
  • src/test/java/org/dbunit/ConnectionPreservingOperationListenerTest.java
  • src/test/java/org/dbunit/DataSourceDatabaseTesterTest.java
  • src/test/java/org/dbunit/DatabaseTestCaseIT.java
  • src/test/java/org/dbunit/DefaultDatabaseTesterTest.java
  • src/test/java/org/dbunit/DefaultPrepAndExpectedTestCaseColumnProjectionIT.java
  • src/test/java/org/dbunit/DefaultPrepAndExpectedTestCaseFreshColumnsTest.java
  • src/test/java/org/dbunit/DefaultPrepAndExpectedTestCaseGeneratedIdRowOrderIT.java
  • src/test/java/org/dbunit/DefaultPrepAndExpectedTestCaseRowCountCheckIT.java
  • src/test/java/org/dbunit/DefaultPrepAndExpectedTestCaseTest.java
  • src/test/java/org/dbunit/IDatabaseTesterTest.java
  • src/test/java/org/dbunit/JndiDatabaseTesterTest.java
  • src/test/java/org/dbunit/MariaDbEnvironment.java
  • src/test/java/org/dbunit/MultiDataSourcePrepAndExpectedTestCaseIT.java
  • src/test/java/org/dbunit/MultiDataSourcePrepAndExpectedTestCaseTest.java
  • src/test/java/org/dbunit/MySqlEnvironment.java
  • src/test/java/org/dbunit/NonUtcDefaultTimeZoneTest.java
  • src/test/java/org/dbunit/PrepAndExpectedTestCaseTest.java
  • src/test/java/org/dbunit/PrepAndExpectedTestDataTest.java
  • src/test/java/org/dbunit/annotation/runtime/AnnotatedTestConfigurationTest.java
  • src/test/java/org/dbunit/annotation/runtime/AnnotatedTestExecutorTest.java
  • src/test/java/org/dbunit/annotation/runtime/AnnotatedTestOptInTest.java
  • src/test/java/org/dbunit/annotation/runtime/ClassicOperationListenerTest.java
  • src/test/java/org/dbunit/annotation/runtime/ClassicRowCountCheckTest.java
  • src/test/java/org/dbunit/annotation/runtime/DataFileLoaderInstancesTest.java
  • src/test/java/org/dbunit/annotation/runtime/DataSetPathsResolverTest.java
  • src/test/java/org/dbunit/annotation/runtime/DataSetResourcePathResolverTest.java
  • src/test/java/org/dbunit/annotation/runtime/DatabaseConfigPropertiesResolverTest.java
  • src/test/java/org/dbunit/annotation/runtime/DeclaredMethodsOfHierarchyTest.java
  • src/test/java/org/dbunit/annotation/runtime/DefaultMethodOverrideCheckTest.java
  • src/test/java/org/dbunit/annotation/runtime/FakeAnnotationLookup.java
  • src/test/java/org/dbunit/annotation/runtime/FixedConnectionCheckTest.java
  • src/test/java/org/dbunit/annotation/runtime/InjectedTestCaseConfigurerTest.java
  • src/test/java/org/dbunit/annotation/runtime/InjectedTestCaseDeclarationCheckTest.java
  • src/test/java/org/dbunit/annotation/runtime/InjectedTestCaseTesterBindingTest.java
  • src/test/java/org/dbunit/annotation/runtime/LifecycleMethodAnnotationCheckTest.java
  • src/test/java/org/dbunit/annotation/runtime/MergedDbUnitConfigTest.java
  • src/test/java/org/dbunit/annotation/runtime/ProvidedAttributeTest.java
  • src/test/java/org/dbunit/annotation/runtime/ReflectiveInstantiationTest.java
  • src/test/java/org/dbunit/annotation/runtime/TestCaseConfigurerTest.java
  • src/test/java/org/dbunit/annotation/runtime/TestCaseRestorationTest.java
  • src/test/java/org/dbunit/annotation/runtime/TestInstanceTesterResolverTest.java
  • src/test/java/org/dbunit/annotation/runtime/TesterFieldsTest.java
  • src/test/java/org/dbunit/annotation/runtime/TesterStateSnapshotTest.java
  • src/test/java/org/dbunit/annotation/runtime/VerifyTableDefinitionCatalogTest.java
  • src/test/java/org/dbunit/annotation/runtime/VerifyTableDefinitionResolverTest.java
  • src/test/java/org/dbunit/ant/DbUnitTaskIT.java
  • src/test/java/org/dbunit/assertion/DiffCollectingFailureHandlerTest.java
  • src/test/java/org/dbunit/assertion/comparer/value/CompiledPatternCacheTest.java
  • src/test/java/org/dbunit/assertion/comparer/value/ConditionalSelectorMultiValueComparerTest.java
  • src/test/java/org/dbunit/assertion/comparer/value/ConditionalSetBiValueComparerTest.java
  • src/test/java/org/dbunit/assertion/comparer/value/IsActualEqualToExpectedJsonValueComparerTest.java
  • src/test/java/org/dbunit/assertion/comparer/value/RegularExpressionValueComparerTest.java
  • src/test/java/org/dbunit/assertion/comparer/value/ValueComparerTest.java
  • src/test/java/org/dbunit/database/AbstractDatabaseConnectionIT.java
  • src/test/java/org/dbunit/database/DatabaseConfigOverridesTest.java
  • src/test/java/org/dbunit/database/DatabaseConfigTest.java
  • src/test/java/org/dbunit/database/DefaultMetadataHandlerTest.java
  • src/test/java/org/dbunit/database/QuotedColumnsTableMetaDataTest.java
  • src/test/java/org/dbunit/database/connection/AutoCommitOffWarningTest.java
  • src/test/java/org/dbunit/database/connection/ClosedConnectionHandedOutWarningTest.java
  • src/test/java/org/dbunit/database/connection/ClosedFixedConnectionWarningTest.java
  • src/test/java/org/dbunit/database/connection/ConnectionOwnershipTest.java
  • src/test/java/org/dbunit/database/connection/LeftOpenConnectionWarningTest.java
  • src/test/java/org/dbunit/database/connection/TestScopedConnectionTest.java
  • src/test/java/org/dbunit/database/connection/UsedTestersTest.java
  • src/test/java/org/dbunit/database/rowcount/CurrentSchemaConnectionTest.java
  • src/test/java/org/dbunit/database/rowcount/QueryPerTableRowCounterTest.java
  • src/test/java/org/dbunit/database/rowcount/RowCountBaselineTrackerTest.java
  • src/test/java/org/dbunit/database/rowcount/RowCountCheckConfigurationTest.java
  • src/test/java/org/dbunit/database/rowcount/RowCountCheckOverrideTest.java
  • src/test/java/org/dbunit/database/rowcount/RowCountCheckTest.java
  • src/test/java/org/dbunit/database/rowcount/RowCountDifferenceTest.java
  • src/test/java/org/dbunit/database/rowcount/UnexpectedRowCountExceptionTest.java
  • src/test/java/org/dbunit/dataset/JdbcEscapeTextTest.java
  • src/test/java/org/dbunit/dataset/OptionalLibraryMissingTest.java
  • src/test/java/org/dbunit/dataset/RequiredLibraryTest.java
  • src/test/java/org/dbunit/dataset/datatype/BigIntegerDataTypeTest.java
  • src/test/java/org/dbunit/dataset/datatype/BytesDataTypeTest.java
  • src/test/java/org/dbunit/dataset/datatype/DateDataTypeTest.java
  • src/test/java/org/dbunit/dataset/datatype/IntegerDataTypeTest.java
  • src/test/java/org/dbunit/dataset/datatype/IsoTimestampTextTest.java
  • src/test/java/org/dbunit/dataset/datatype/LongDataTypeTest.java
  • src/test/java/org/dbunit/dataset/datatype/NumberDataTypeTest.java
  • src/test/java/org/dbunit/dataset/datatype/TimestampDataTypeTest.java
  • src/test/java/org/dbunit/dataset/excel/XlsTableTest.java
  • src/test/java/org/dbunit/dataset/excel/XlsTableTimezoneOffsetTest.java
  • src/test/java/org/dbunit/dataset/json/JsonDataSetTest.java
  • src/test/java/org/dbunit/dataset/json/JsonWriterTest.java
  • src/test/java/org/dbunit/dataset/yaml/YamlProducerTest.java
  • src/test/java/org/dbunit/dataset/yaml/YmlDataSetTest.java
  • src/test/java/org/dbunit/dataset/yaml/YmlWriterTest.java
  • src/test/java/org/dbunit/ext/h2/H2DataTypeFactoryTest.java
  • src/test/java/org/dbunit/ext/h2/H2JsonTypeIT.java
  • src/test/java/org/dbunit/ext/h2/H2JsonTypeTest.java
  • src/test/java/org/dbunit/ext/mysql/MySqlMetadataHandlerTest.java
  • src/test/java/org/dbunit/ext/postgresql/PostgresqlJsonIT.java
  • src/test/java/org/dbunit/junit/jupiter/ContextAnnotationLookupTest.java
  • src/test/java/org/dbunit/junit/jupiter/DbUnitConfigPropertiesIT.java
  • src/test/java/org/dbunit/junit/jupiter/DbUnitExtensionAnnotationIT.java
  • src/test/java/org/dbunit/junit/jupiter/DbUnitExtensionAutoCommitOffIT.java
  • src/test/java/org/dbunit/junit/jupiter/DbUnitExtensionBoundedPoolIT.java
  • src/test/java/org/dbunit/junit/jupiter/DbUnitExtensionClassicPathIT.java
  • src/test/java/org/dbunit/junit/jupiter/DbUnitExtensionCollectingFailureHandlerIT.java
  • src/test/java/org/dbunit/junit/jupiter/DbUnitExtensionConnectionBalanceIT.java
  • src/test/java/org/dbunit/junit/jupiter/DbUnitExtensionConnectionReuseIT.java
  • src/test/java/org/dbunit/junit/jupiter/DbUnitExtensionDataFileLoaderSharingTest.java
  • src/test/java/org/dbunit/junit/jupiter/DbUnitExtensionInjectedTestCaseSettingsIT.java
  • src/test/java/org/dbunit/junit/jupiter/DbUnitExtensionLifecycleMethodCheckTest.java
  • src/test/java/org/dbunit/junit/jupiter/DbUnitExtensionLifecycleTest.java
  • src/test/java/org/dbunit/junit/jupiter/DbUnitExtensionNoOpListenerIT.java
  • src/test/java/org/dbunit/junit/jupiter/DbUnitExtensionParameterResolverTest.java
  • src/test/java/org/dbunit/junit/jupiter/DbUnitExtensionRealTesterRowCountCheckIT.java
  • src/test/java/org/dbunit/junit/jupiter/DbUnitExtensionRegisteredTwiceIT.java
  • src/test/java/org/dbunit/junit/jupiter/DbUnitExtensionRowCountCheckIT.java
  • src/test/java/org/dbunit/junit/jupiter/DbUnitExtensionSelfManagedTestCaseIT.java
  • src/test/java/org/dbunit/junit/jupiter/DbUnitExtensionSpringTransactionIT.java
  • src/test/java/org/dbunit/junit/jupiter/DbUnitExtensionTest.java
  • src/test/java/org/dbunit/junit/jupiter/DbUnitExtensionTestMethodDrivesTestCaseIT.java
  • src/test/java/org/dbunit/junit/jupiter/DbUnitExtensionTesterListenerIT.java
  • src/test/java/org/dbunit/junit/jupiter/DeclarationsFinderTest.java
  • src/test/java/org/dbunit/junit/jupiter/EnclosingTestClassesTest.java
  • src/test/java/org/dbunit/junit/jupiter/JupiterLifecycleMethodsTest.java
  • src/test/java/org/dbunit/junit/jupiter/NestedContextChain.java
  • src/test/java/org/dbunit/junit/jupiter/SpringTestTransactionCheckTest.java
  • src/test/java/org/dbunit/junit/jupiter/TesterResolverTest.java
  • src/test/java/org/dbunit/operation/InsertOperationIT.java
  • src/test/java/org/dbunit/spring/DbUnitTestExecutionListenerFieldExtendWithTest.java
  • src/test/java/org/dbunit/spring/DbUnitTestExecutionListenerIT.java
  • src/test/java/org/dbunit/spring/DbUnitTestExecutionListenerInheritanceTest.java
  • src/test/java/org/dbunit/spring/DbUnitTestExecutionListenerLifecycleMethodCheckTest.java
  • src/test/java/org/dbunit/spring/DbUnitTestExecutionListenerRegistrationTest.java
  • src/test/java/org/dbunit/spring/DbUnitTestExecutionListenerTest.java
  • src/test/java/org/dbunit/spring/DbUnitTestExecutionListenerTransactionalIT.java
  • src/test/java/org/dbunit/spring/SpringAnnotationLookupTest.java
  • src/test/java/org/dbunit/spring/SpringLifecycleMethodsTest.java
  • src/test/java/org/dbunit/spring/SpringTesterResolverTest.java
  • src/test/java/org/dbunit/util/CommaSeparatedValuesTest.java
  • src/test/java/org/dbunit/util/fileloader/CachingDataFileLoaderTest.java
  • src/test/java/org/dbunit/util/fileloader/CachingFileExtensionDataFileLoaderTest.java
  • src/test/java/org/dbunit/util/fileloader/FileExtensionDataFileLoaderTest.java
  • src/test/java/org/dbunit/util/fileloader/YamlDataFileLoaderTest.java
  • src/test/java/org/dbunit/util/fileloader/subclass/CachingFileExtensionDataFileLoaderSubclassTest.java
  • src/test/resources/org/dbunit/junit/jupiter/annotation-it-missing-table-prep.xml
  • src/test/resources/org/dbunit/util/fileloader/column-and-row-tables.xml
  • src/test/resources/org/dbunit/util/fileloader/column-sensing-test.xml
  • src/test/resources/org/dbunit/util/fileloader/column-table-with-a-column.xml
  • src/test/resources/org/dbunit/util/fileloader/doctype/dataset.dtd
  • src/test/resources/org/dbunit/util/fileloader/doctype/flat-xml-doctype-dtd-lacks-table.xml
  • src/test/resources/org/dbunit/util/fileloader/doctype/flat-xml-doctype.xml
  • src/test/resources/org/dbunit/util/fileloader/doctype/flat.dtd
  • src/test/resources/org/dbunit/util/fileloader/doctype/full-xml-doctype-missing-dtd.xml
  • src/test/resources/org/dbunit/util/fileloader/doctype/full-xml-doctype.xml
  • src/test/resources/org/dbunit/util/fileloader/full-shape-and-another-table.xml
  • src/test/resources/org/dbunit/util/fileloader/full-xml-columns-only.xml
  • src/test/resources/org/dbunit/util/fileloader/subclass/subclass-relative.xml
  • src/test/resources/org/dbunit/util/fileloader/table-named-table.xml
  • src/test/resources/org/dbunit/util/fileloader/table-table-with-another-column.xml
  • src/test/resources/org/dbunit/util/fileloader/upper-case-full-shape.xml
  • src/test/resources/yaml/yamlDataSetSyntaxErrorTest.yml

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: eab022edd3

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: bac29fc7be

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 3e2c8b8ebe

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@jeffjensen
jeffjensen force-pushed the 360-design-review branch 2 times, most recently from 1ffff3a to 4c0bac1 Compare November 13, 2026 03:29
jacobjdev and others added 7 commits November 13, 2026 09:28
* Discard the baseline in RowCountChecker.verify(), whether the
  verification passes or fails, so a later lifecycle on the same
  instance that never captures a baseline of its own, such as the legacy
  setUp() and tearDown() hooks, does not verify against the counts of
  the test before it.
* Discard the baseline in DefaultPrepAndExpectedTestCase when its
  database tester is replaced, as it was captured from the replaced
  tester's database.

Refs: 939
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
* Clear the involved data sources in runTest() before tearing them down
  after failing test steps, as postTest() does, so a postTest(false)
  call in the caller's finally block does not tear each delegate down a
  second time.
* Document that the run is over once postTest() has run, or runTest()
  has torn it down after failing test steps.

Refs: 968
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
* Keep the connection for the rest of the test when it had no JDBC
  connection to capture at acquisition, as a
  DatabaseDataSourceConnection does when its pool times out, instead of
  replacing it on every getConnection() call and leaving each replaced
  connection unclosed.
* Replace a kept connection only when its JDBC connection reports
  closed, or fails to report; release() closes the one it holds.
* Drop the sentence of the release() Javadoc saying it leaves the memo
  in place and relies on a revalidation flag that does not exist:
  release() forgets a connection it closed and keeps it only when
  ownership leaves it open for its real owner.

Refs: 753
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01Q55xijb8HCBhpVuuV644ms
* Report from the tester resolution whether it gave an injected
  @DbUnitTestCase instance the tester because the instance carried none.
* Give such an instance no tester again once the whole test is over, in
  the new AnnotatedTestExecutor.unbindTesterFromInjectedTestCase(). The
  JUnit Jupiter extension calls it from its afterEach callback, which
  runs after the test's @AfterEach methods, and the Spring listener
  after the after-test steps; both call it also when the step before it
  fails. A test case shared across tests, such as a static field, is
  then given each test's own tester instead of keeping the first test's,
  and an @AfterEach method can still reach the tester through the
  injected instance.
* Hold the instance to the closeConnectionAfterTest = false a test
  declared while the tester is taken off it, and put the instance's own
  value back after, so the instance does not close a connection that
  belongs to its real owner, such as a CachingConnectionProvider. When
  the test declares nothing, the instance's own value decides.
* Build the executor from the resolution in the JUnit Jupiter and Spring
  bindings.

Refs: 753
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01Q55xijb8HCBhpVuuV644ms
* Index a catalog's definitions by the table name ignoring case, as
  dbUnit finds a table in a dataset, so verifyTables = "account" selects
  a catalog's ACCOUNT definition, which is returned under its own
  spelling.
* Reject a table defined twice in catalog classes, named twice in
  verifyTables, or declared twice in verify, when the names differ only
  in case.
* List the available catalog table names as the catalog spells them.

Refs: 753
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
* Resolve every @DbUnitProperty name, and every name a
  DatabaseConfigPropertiesProvider supplies, to the long name
  DatabaseConfig knows the property by, and reject a property that is
  declared twice under its long and its short form instead of leaving
  the value that wins to the iteration order of a Properties.
* Replace an injected test case's own property with a declared one for
  the same DatabaseConfig property, whichever form of the name each
  uses.
* Resolve a long or short name with the new
  DatabaseConfig.findByNameOrShortName(), which setPropertiesByString()
  and DatabaseConfigOverrides use too, so every place reads a property
  name the same way.

Refs: 753
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
* Add
  PrepAndExpectedTestCase.configureTestVerifyingEveryExpectedTable(), a
  default method reporting that it configured nothing, which
  DefaultPrepAndExpectedTestCase implements by taking one default
  VerifyTableDefinition per table of the expected dataset it loads,
  instead of the annotation runtime parsing every expected file a first
  time just to list its tables.
* Use it from the prep/expected lifecycle when @DbUnitExpected declares
  no tables to verify; a subclass that overrides
  configureTest(VerifyTableDefinition[], String[], String[]), which may
  expect the definitions it is given, and any other implementation keep
  deriving the definitions by reading the files.

Refs: 753
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
jeffjensen and others added 13 commits November 17, 2026 21:49
* Rethrow the SQLException of a counter that fails with a message that
  names the exclusion and the escapePattern property, and the original
  as its cause.
* Say on the row count page that a table whose stored name needs
  quoting, such as Flyway's flyway_schema_history on H2, cannot be
  counted by its unquoted name.

Refs: 939
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01EiskJTYEbkyG9NzTHv5JsE
* Limit the row count caveat about a fresh, default DatabaseConfig to a
  JdbcDatabaseTester and a DataSourceDatabaseTester built without a
  DatabaseConfig.
* Name the DatabaseConfig the four-argument constructor takes as the
  place to set the row count feature.

Refs: 939
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01EiskJTYEbkyG9NzTHv5JsE
* Fail a test with an IllegalStateException that names the method and
  the annotation when a lifecycle method of its class, a superclass, an
  interface or an enclosing class carries a method-level dbUnit
  annotation, which no binding reads there.
* Say on the annotation Javadoc and the annotations, DbUnitExtension and
  DbUnitTestExecutionListener pages that a method-level annotation
  counts on the test method only.

Refs: 753
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01EiskJTYEbkyG9NzTHv5JsE
* Fail the comparison with a DatabaseUnitException that names the column
  and the row when the expected or the actual value has content after
  its first JSON value, which Jackson ignores by default.
* Compare a number with a fraction as an exact decimal, as a double
  drops the digits past about 17 significant ones and made values that
  differ there equal.
* Say on the Value Comparers page and in the Javadoc what counts as
  equal: member order and whitespace do not matter, array order does, 1
  and 1.0 differ, a null member differs from a missing one.

Refs: 1046
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01EiskJXVAfxC6BK1iNga1R4
* Fail with an SQLException that names the table and gives the
  database's message when QueryPerTableRowCounter cannot count a table,
  with the database's exception as the cause and its SQL state and error
  code kept, as a driver's own message may not name the table.
* Say in the RowCounter contract and on the row count page that a
  failure to count a table must name the table, as the row count check
  gives the message to the user.

Refs: 939
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01EiskJXVAfxC6BK1iNga1R4
* Describe in the Javadoc and on the Value Comparers page that the
  actual value is matched as the text dbUnit makes of it.
* Name the forms that differ from what the database shows: a timestamp's
  fraction, a decimal's scale and a binary value's Base64 text.
* Pin the rule with unit tests.

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01EiskJWqtZkgmLqhKJCqaGD
The comparer parsed the Base64 text that DataType.asString() makes of a
byte[], which H2 returns for a JSON column, so it failed for every such
document.

* Read a byte[] actual value as UTF-8 text before parsing, as RFC 8259
  makes UTF-8 the encoding of JSON exchanged between systems.

Refs: 1047
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01EiskJWqtZkgmLqhKJCqaGD
H2DataTypeFactory gave a JSON column DataType.UNKNOWN, so the database
dataset dropped it with a warning and a dataset could neither load nor
verify it.

* Map the JSON type name to the new H2JsonType, which reads the value as
  the text of the document and writes it as the UTF-8 bytes of the text,
  as H2 stores a value bound with setString() as a JSON string.
* Document the type on the H2 page and keep H2 in the list of the JSON
  value comparer's databases.

Refs: 1047
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01EiskJWqtZkgmLqhKJCqaGD
* Fail the verification of a table when a column name to include matches
  no column of the database table, instead of comparing only the row
  count.
* Fail it too when the column name of a column comparer matches no
  column, or names a column that the include or exclude names leave out,
  as its comparer would not be used.
* Add DatabaseConfig.FEATURE_FAIL_ON_UNKNOWN_VERIFY_COLUMN_NAME, enabled
  by default, which when set to false logs a warning for such a name
  instead of failing.
* Name the column, the table and the table's columns in the message.
* Skip the check when the table's columns cannot be read or a subclass
  loads the actual table itself.
* Say so in the Javadoc, the properties page and the Annotations, Verify
  Table Definition and PrepAndExpectedTestCase pages.

Refs: 1049
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01EiskJTJQQHut5U1jXdN7kp
* Take the compared columns from a select that returns no row instead of
  the connection's cached DatabaseDataSet, which leaves out a column of
  a type the data type factory does not know and a column added since it
  first read the table.
* Select every column as before when the columns cannot be read or all
  are filtered out.

Refs: 1008
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01EiskJVoEoYrdCK6mHfqyRL
The filtered sort selects the compared columns by name instead of
select *. The names come from the driver exactly as the database
stores them, but were written into the select unquoted without an
escape pattern, so a column named as a reserved word or in mixed case
failed to load, where 3.5.2 passed.

* Write each projected column name, and each key of the order by,
  between the database's identifier quote string when no escape
  pattern is set, with the escape pattern still winning when set.
* Select every column, as the default mode does, when no column is
  filtered out, as selecting them by name saves nothing.
* Add QuotedColumnsTableMetaData to carry the quote string to the
  select statement builder through the result set table factory.
* Update the Javadoc, the verify table definition page and the
  changes.xml action to say how the names are written.
* Exclude a column per table shape in the projection integration test,
  so that each shape still projects, and add a test for no filter.

Refs: 1008
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01EiskJVeqXg5NxSmkoykVNc
verifyData() moved every column that has a comparer of its own to the
end of the sort key. A leading sequence of generated ids compared with
"greater than or equal to" holds expected values in the order of the
actual ids, so it orders the rows, but sorted last it no longer did and
the other columns ordered them instead. In the default sort mode, with
a column of the actual table that the expected table leaves out, that
lined an expected row up against the wrong actual row.

* Add ValueComparer.isSortableByExpectedValue(), a default method that
  returns true. The not-null, null, never-fails, regular expression,
  containing-string, not-equal and JSON comparers return false, and the
  two conditional comparers return true only when every comparer they
  can pick does.
* Move only the columns whose comparer returns false to the end of the
  sort key, for the sort, its TypeCastException report and the retry
  behind the sortOnFilteredColumnsOnly hint. A column compared by
  equality, by order or by a tolerance keeps its place.
* Say so in the Sort Mode section of verifytabledefinition.adoc, in
  valuecomparer.adoc, PrepAndExpectedTestCase.adoc and the 973 and 1006
  changes.xml actions.

Refs: 1006
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01EiskJSfriYvZ43x14kUECw
@chatgpt-codex-connector

Copy link
Copy Markdown

You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard.

1 similar comment
@chatgpt-codex-connector

Copy link
Copy Markdown

You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard.

jeffjensen and others added 12 commits November 18, 2026 16:06
* After a failed comparison in which a column whose value comparer can
  order the rows kept its place in the sort, compare again with every
  column that has a comparer sorted after the others. When that passes,
  attach a hint to the failure as a suppressed exception and log it as
  a warning, as the sortOnFilteredColumnsOnly hint does. The hint names
  the columns and the remedy: expected values in the order of the
  actual ones, such as a sequence of ids, or a comparer whose
  isSortableByExpectedValue() returns false.
* Add nothing when no such column kept its place, when the comparison
  also fails sorted that way, or when the sortOnFilteredColumnsOnly
  hint applies, which is added instead.
* Log either hint as a warning when a failure handler that collects the
  differences, such as DiffCollectingFailureHandler, gained some in the
  comparison, as nothing is thrown for the hint to be attached to.
* Share the retry of the two hints in passesWhenSortedBy().
* Say so in the Sort Mode section of verifytabledefinition.adoc, in the
  ValueComparer and verifyData() Javadoc, and in the changes.xml
  actions of the two hints.
* Test both hints with a collecting handler.

Refs: 1006
Refs: 1011
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01EiskJSfriYvZ43x14kUECw
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01EiskJWhkfoW63Uk5cBNJHZ
The release news lists link to each milestone's features and bugs but
not to its tasks.

* Add a task list link to each release entry that links the feature and
  bug lists.
* Put each phrase of the release links sentence on its own line.

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01EiskJXUbgVQYtTRayrG5oz
The JSON value comparer formatted the row number of its parse failure in
the default locale, so a locale with digits of its own wrote "row ٣"
where every other dbUnit message writes "row 3".

* Format the parse failure message with the English locale.
* Test the message in a locale with digits of its own.

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01EiskJXUbgVQYtTRayrG5oz
JUnit Jupiter ignores a duplicate declarative registration, but keeps a
@RegisterExtension instance next to it. A class with @DbUnitTest and a
@RegisterExtension field so has two extension instances sharing the one
executor of the test, and each ran its steps: the prep twice, and a
second verification against the database that the first teardown had
emptied, which failed a correct test and blamed the data. Both also
claimed an IDatabaseTester or IDatabaseConnection parameter, which JUnit
rejects as competing parameter resolvers.

* Make a second beforeTest() of an executor do nothing.
* Make a second afterTest() of an executor do nothing.
* Let the instance asked first for a test resolve all its parameters.
* Test both lifecycles, both parameter claims, and a test class that
  registers the extension twice against a real database.

Refs: 753
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01EiskJXUbgVQYtTRayrG5oz
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01EiskJWhkfoW63Uk5cBNJHZ
…nces

A failure handler that collects, such as DiffCollectingFailureHandler,
does not throw on a value that differs. The annotation runtime verifies
after the test method returned, and nothing read the collected list, so
a test whose data differed passed. This held for
@DbUnitConfig(failureHandler), and for an injected test case built with
such a handler, as the Annotations page's own example does.

* Fail the test with the collected differences after the verification
  and the teardown, as one message that lists each of them.
* Empty the handler and its hints before each verification, as a static
  injected test case keeps its handler from test to test.
* Add DiffCollectingFailureHandler.createFailureForCollectedDifferences().
* Add addHint(), getHints() and clear() to the handler, so that the
  hint about a sort that lined up rows against the wrong counterparts,
  which a verification that throws attaches to its failure, is carried
  as a suppressed exception by the failure for the collected
  differences too.
* Say in the Javadoc and in the Annotations and Failure Handling pages
  that a collecting handler fails the test, and that a handler set by
  the annotation brings no additional row information.

Refs: 753
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01EiskJXUbgVQYtTRayrG5oz
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01EiskJWhkfoW63Uk5cBNJHZ
…uired

A bare @DbUnitTearDownOperation declared NONE and so replaced the
tester's own teardown operation with nothing, and a bare @DbUnitPrep
named no file. Both annotations exist to name something, so writing
them bare was a mistake that went unnoticed.

* Remove the defaults of DbUnitTearDownOperation.value() and
  DbUnitPrep.value(). NONE and an empty array still declare no teardown
  and no files explicitly.
* Say in the Annotations page and the Javadoc that a test without the
  annotation runs the tester's own teardown operation.
* Test an explicit NONE and an empty prep declaration.

Refs: 753
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01EiskJXUbgVQYtTRayrG5oz
The autocommit and the left-open connection warnings kept their flag in
one instance per lifecycle owner. An annotation-driven test builds a
test case for every test, so a suite whose tester triggered one of them
logged the same long warning once for every test. The condition belongs
to the tester, how it builds its connections, and not to the test.

* Add WarnedTesters, which remembers in the JVM, by identity and
  without keeping a tester alive, the testers a kind of warning was
  given about.
* Warn once for a tester, besides once for an instance, in
  AutoCommitOffWarning and LeftOpenConnectionWarning.
* Give AutoCommitOffWarning the tester supplier that its sibling
  warnings have.
* Test that two instances for one tester warn once, and two testers
  twice.

Refs: 1013
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01EiskJXUbgVQYtTRayrG5oz
… test

The annotation-driven test case takes its connection for the prep and
keeps it until the teardown, so a pooled connection is checked out
while the test method runs. A pool of one starves a test whose own code
takes a connection from the same pool, and the failure names the pool,
not dbUnit.

* Describe the held connection and the pool size it needs in the
  Annotations page.
* Add the same to the transactional tests of the listener page.

Refs: 753
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01EiskJXUbgVQYtTRayrG5oz
An unquoted YAML timestamp with a T, such as 2024-01-15T10:00:00, was
read by SnakeYAML as an instant in UTC, so a TIMESTAMP column stored it
shifted by the offset of the JVM's time zone, and a text column got the
toString() of a java.util.Date, while 2024-01-15 10:00:00 was stored as
written. The same text failed in the other formats.

A timestamp with an offset stays the instant that SnakeYAML reads: as
text, TimestampDataType writes it to a column without a time zone as
the time written in its offset but compares it as the instant, so a
dataset would not verify against the rows it inserted.

* Hand a YAML timestamp without an offset on as the text of the
  document, and one with an offset as the instant SnakeYAML reads.
* Let TimestampDataType read the ISO 8601 and YAML 1.1 forms: a T, a t,
  a tab or more than one space between date and time, and an empty
  fraction, in the JVM's time zone, and an offset as Z, +hh, +hh:mm or
  +hhmm, as that instant.
* Let DateDataType read them too, so a DATE column keeps loading them.
* Say it in the YAML and the Dataset Values pages, and say what a column
  without a time zone stores for a text with an offset.

Refs: 1053
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01EiskJXUbgVQYtTRayrG5oz
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01EiskJWhkfoW63Uk5cBNJHZ
The oldest-supported-versions job compiled against JUnit Jupiter 5.7.0
and Spring Framework 6.2.0, which guards against calling an API they
lack, but not against relying on behavior that changed since: the order
and context of the extension callbacks, the store lookup through parent
contexts, the handling of nested classes, the listener ordering and the
test context attributes. The binding tests only ran on JUnit 6.1.3 and
Spring 7.0.9.

* Add the oldest-supported-versions profile, which sets both oldest
  versions and leaves out the test classes that need a newer JUnit
  Jupiter or that its discovery cannot run.
* Add junitPlatformVersion, as the JUnit Platform artifacts have their
  own version number up to JUnit 5.
* Run the unit tests of the bindings against both oldest versions in
  the job.
* Move the two tests that use @ExtendWith on a field into a class of
  their own, as that needs JUnit Jupiter 5.8.
* Say in the pages of the bindings that the tests run on the oldest.

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01EiskJXUbgVQYtTRayrG5oz
Under SpringExtension, a @transactional test starts its transaction
before DbUnitExtension sets up and ends it after the teardown, so the
extension works inside the transaction. A tester on a
TransactionAwareDataSourceProxy gets the transaction's connection and
rolls back with it. A tester with a connection of its own does not: a
teardown of rows that the test method changed waits for locks of the
transaction, which cannot end until the teardown returns, so it fails
after the lock timeout and on PostgreSQL waits without end, and its
verification does not see what is not committed. Nothing said why.

* Log a warning, once for a test class, when a Spring test-managed
  transaction is active before the extension sets up. Ask Spring by
  reflection, so the extension still needs no Spring. The warning
  names both testers, as it cannot tell them apart.
* Name the ways out in the warning and in the pages of the extension
  and the listener: a tester on a TransactionAwareDataSourceProxy,
  @DbUnitSpringTest with @Commit for a test that verifies its own
  changes, or no @transactional.
* Test a transactional test on a transaction-aware tester.

Refs: 753
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01EiskJXUbgVQYtTRayrG5oz
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01EiskJWhkfoW63Uk5cBNJHZ
@chatgpt-codex-connector

Copy link
Copy Markdown

You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

3 participants