Codex/player portrait stacked stage#1
Conversation
Keep the stacked hero and visual in separately budgeted bands while preserving final-five stability, accessibility sizing, and the wide player composition. Add focused geometry and long-name coverage for the verified contract.
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 28506f16a9
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| } else { | ||
| visualLabel(style: style) | ||
| } |
There was a problem hiding this comment.
In the new implementation the hidden modifier is applied before the overlay, and this branch then adds the non-stage visualLabel outside that hidden subtree. On screens such as the workout picker, whose rows use .accessibilityElement(children: .combine), the SF Symbol inside WorkoutVisual will be announced as part of each row even though these visuals were decorative and were fully hidden before this change. Move the hiding after the overlay or hide the label content unless a caller explicitly supplies an accessibility label.
Useful? React with 👍 / 👎.
1 participant
No description provided.