Skip to content

Avoid MSAN timeouts - #297

Open
tameware wants to merge 2 commits into
dds-bridge:developfrom
tameware:fix-test-timeout
Open

Avoid MSAN timeouts#297
tameware wants to merge 2 commits into
dds-bridge:developfrom
tameware:fix-test-timeout

Conversation

@tameware

@tameware tameware commented Aug 7, 2026

Copy link
Copy Markdown
Collaborator

Drop the redundant ContextReusePerformance loop (reuse is already covered by ContextReuseMultipleCalls) and mark the target medium so the remaining suite has headroom under the MSAN small-test limit.

Drop the redundant ContextReusePerformance loop (reuse is already covered) and mark the target medium so the remaining suite has headroom under the MSAN small-test limit.

Co-authored-by: Cursor <cursoragent@cursor.com>
@tameware tameware self-assigned this Aug 7, 2026
@tameware
tameware requested a review from zzcgumn August 7, 2026 21:42
Mark the target medium so the random-playout suite has headroom under the MSAN small-test limit.

Co-authored-by: Cursor <cursoragent@cursor.com>
@tameware
tameware marked this pull request as ready for review August 7, 2026 22:27
@tameware tameware changed the title Avoid MSAN timeout in calc_par_test. Avoid MSAN timeouts Aug 7, 2026
@tameware
tameware requested a lite review from Copilot August 7, 2026 23:26

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Reduces the risk of MemorySanitizer (MSAN) CI timeouts by removing a redundant context-reuse loop in calc_par_test and increasing Bazel test sizes for two long-running tests so they receive a higher timeout budget under --config=msan.

Changes:

  • Mark analyse_play_consistency_test as medium to avoid exceeding MSAN “small” timeout limits.
  • Remove the ContextReusePerformance GoogleTest case (context reuse is already exercised elsewhere).
  • Mark calc_par_test as medium to provide additional MSAN timeout headroom.

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.

File Description
library/tests/solve_board/BUILD.bazel Increases analyse_play_consistency_test size to medium with an explanatory comment for MSAN timeouts.
library/tests/calc_par_test.cpp Removes redundant ContextReusePerformance test (context reuse remains covered by ContextReuseMultipleCalls).
library/tests/BUILD.bazel Increases calc_par_test size to medium with an explanatory comment for MSAN headroom.

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants