Avoid MSAN timeouts - #297
Open
tameware wants to merge 2 commits into
Open
Conversation
Drop the redundant ContextReusePerformance loop (reuse is already covered) and mark the target medium so the remaining suite has headroom under the MSAN small-test limit. Co-authored-by: Cursor <cursoragent@cursor.com>
Mark the target medium so the random-playout suite has headroom under the MSAN small-test limit. Co-authored-by: Cursor <cursoragent@cursor.com>
Contributor
There was a problem hiding this comment.
Pull request overview
Reduces the risk of MemorySanitizer (MSAN) CI timeouts by removing a redundant context-reuse loop in calc_par_test and increasing Bazel test sizes for two long-running tests so they receive a higher timeout budget under --config=msan.
Changes:
- Mark
analyse_play_consistency_testasmediumto avoid exceeding MSAN “small” timeout limits. - Remove the
ContextReusePerformanceGoogleTest case (context reuse is already exercised elsewhere). - Mark
calc_par_testasmediumto provide additional MSAN timeout headroom.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
library/tests/solve_board/BUILD.bazel |
Increases analyse_play_consistency_test size to medium with an explanatory comment for MSAN timeouts. |
library/tests/calc_par_test.cpp |
Removes redundant ContextReusePerformance test (context reuse remains covered by ContextReuseMultipleCalls). |
library/tests/BUILD.bazel |
Increases calc_par_test size to medium with an explanatory comment for MSAN headroom. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Drop the redundant ContextReusePerformance loop (reuse is already covered by ContextReuseMultipleCalls) and mark the target medium so the remaining suite has headroom under the MSAN small-test limit.