Repository navigation
Don't save a number typed on the way to a wrong one - #295
Merged
Merged
Conversation
Typing 2.5 into Max characters saved the 2 typed on the way: the save for 2 waited for its debounce, and 2. and 2.5 were refused, so the 2 went out. The same for 11 in Height in lines, which saved 1. The workbench store now keeps the answer as it was sent before the changes that wait for their debounce. When a number turns wrong, the long text settings ask the store to put that option back, so the waiting save sends the stored value. Other changes in the same waiting save still go out. Part of BITS-351 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
PhilReinking
commented
Oct 17, 2026
PhilReinking
left a comment
Contributor
Author
There was a problem hiding this comment.
OK at 9694c62, CI green. Vitest 548, lint, vue-tsc clean; 3 new tests fail on main's code. Brave, key by key: 2.5 keeps 500, 11 keeps 5, both with the message; 10 and 800 save, ending Saved; -5, 0, -1 send nothing. Held: a slow save in flight, a failed save, a height change just before, a block switch, leaving the page. Scale settings save as before. A pause over 1 s on 2 still saves the 2.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Typing
2.5into "Max characters" over 500 saved the2typed on the way, and11in "Height in lines" saved1. The step's save waited for its debounce and went out after the next keys were refused. Now a number that turns wrong puts its option back into the waiting save, so the stored value stays.Fixes BITS-351
Tested: Vitest types key by key through the real store and debounce; 3 of the 5 new tests fail without the fix. Lint and vue-tsc pass.
Browser, counting saves on my own server: main saves 2 and 1; this branch saves only 500 and 5, and 10 and 800 still save.
Not tested: Firefox and Safari (checked in Brave).
Known gap: an owner who rests over 1 second on
2before typing.5saves the 2, like any number they pause on.🤖 Generated with Claude Code