Repository navigation
D9Label help text is easier to read and has an id (<id>-help); D9Select passes aria-describedby to its button - #28
Merged
Conversation
…289) Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
PhilReinking
commented
Oct 17, 2026
PhilReinking
left a comment
Contributor
Author
There was a problem hiding this comment.
OK at 1ed38aa, CI green. Help text is 4.76:1 on white and 4.55:1 on grey-50 (dark: 5.71:1 on grey-800). Packed .d.ts files match main. class and id on D9Select land where they did; Input's calls don't change. Headless Chrome reads the help text as the Select button's description. One should inline. The title could also name the D9Select fix: "…; D9Select passes aria-describedby to its button".
Comment on lines
+169
to
+173
| const wrapperAttrs = computed(() => | ||
| Object.fromEntries( | ||
| Object.entries(attrs).filter(([name]) => name !== "aria-describedby") | ||
| ) | ||
| ); |
Contributor
Author
There was a problem hiding this comment.
A computed over useAttrs() only re-runs if it read an attr. If D9Select first renders with no attrs and gets a class later, the class never reaches the wrapper (on main it does). Make it a plain function and bind it as v-bind="wrapperAttrs()" on line 8.
Suggested change
| const wrapperAttrs = computed(() => | |
| Object.fromEntries( | |
| Object.entries(attrs).filter(([name]) => name !== "aria-describedby") | |
| ) | |
| ); | |
| const wrapperAttrs = () => | |
| Object.fromEntries( | |
| Object.entries(attrs).filter(([name]) => name !== "aria-describedby") | |
| ); |
…289) Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
PhilReinking
commented
Oct 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
D9Label's help text is now readable, and a field can point at it with
aria-describedby. The help text gets the id<id>-help(none without anid) and the colorgrey-500. Contrast is 4.76:1 on white and 4.55:1 on grey-50 (before: 2.56:1 and 2.45:1).aria-describedby="name-help"on a D9Input.aria-describedbyon its button.class,style,data-*and other attrs stay on the wrapper as before.Fixes BITS-289
Tested: check, lint, test, build pass; the new Label and Select specs fail on main. Headless Brave accessibility tree reads the help text for Input, Textarea and Select.
After merge: Input needs an @deck9/ui bump and
aria-describedby="<id>-help"on its fields.🤖 Generated with Claude Code