Repository navigation
fix(google-tag-manager): keep untouched fields on update, add create_version - #568
Open
yuriassuncx wants to merge 1 commit into
Open
yuriassuncx wants to merge 1 commit into
yuriassuncx wants to merge 1 commit into
Conversation
…version GTM's PUT replaces the whole entity, so update_tag/update_trigger/update_variable silently deleted every field the tool did not forward: consentSettings (the Consent Mode/LGPD check), parentFolderId, setupTag/teardownTag, priority and schedule. The client now reads the current entity and overlays only the fields the caller set. Also: - get/list/update tag expose consentSettings; update_tag accepts it and parentFolderId - variable formatValue is an options object, not a Parameter; the old schema made list_variables/get_variable fail output validation - create_version tool (creates a version from a workspace, never publishes) Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
deco-hosting
Bot
requested a deployment
to
preview/pr-568/airtable
October 29, 2026 03:15
In progress
deco-hosting
Bot
requested a deployment
to
preview/pr-568/blog-generator
October 29, 2026 03:15
In progress
deco-hosting
Bot
requested a deployment
to
preview/pr-568/content-scraper
October 29, 2026 03:15
In progress
deco-hosting
Bot
requested a deployment
to
preview/pr-568/deco-llm
October 29, 2026 03:15
In progress
deco-hosting
Bot
requested a deployment
to
preview/pr-568/deco-news-weekly-digest
October 29, 2026 03:15
In progress
deco-hosting
Bot
requested a deployment
to
preview/pr-568/discord-read
October 29, 2026 03:15
In progress
deco-hosting
Bot
requested a deployment
to
preview/pr-568/figma-mcp
October 29, 2026 03:15
In progress
deco-hosting
Bot
requested a deployment
to
preview/pr-568/google-analytics
October 29, 2026 03:15
In progress
deco-hosting
Bot
requested a deployment
to
preview/pr-568/google-big-query
October 29, 2026 03:16
In progress
deco-hosting
Bot
requested a deployment
to
preview/pr-568/google-calendar
October 29, 2026 03:16
In progress
deco-hosting
Bot
requested a deployment
to
preview/pr-568/google-calendar-sa
October 29, 2026 03:16
In progress
deco-hosting
Bot
requested a deployment
to
preview/pr-568/google-drive
October 29, 2026 03:16
In progress
deco-hosting
Bot
requested a deployment
to
preview/pr-568/google-meet
October 29, 2026 03:16
In progress
deco-hosting
Bot
requested a deployment
to
preview/pr-568/google-search-console
October 29, 2026 03:16
In progress
deco-hosting
Bot
requested a deployment
to
preview/pr-568/google-sheets
October 29, 2026 03:16
In progress
deco-hosting
Bot
requested a deployment
to
preview/pr-568/google-slides
October 29, 2026 03:16
In progress
deco-hosting
Bot
requested a deployment
to
preview/pr-568/google-tag-manager
October 29, 2026 03:16
In progress
deco-hosting
Bot
requested a deployment
to
preview/pr-568/google-workspace
October 29, 2026 03:16
In progress
deco-hosting
Bot
requested a deployment
to
preview/pr-568/grafana
October 29, 2026 03:16
In progress
deco-hosting
Bot
requested a deployment
to
preview/pr-568/hyperdx
October 29, 2026 03:16
In progress
deco-hosting
Bot
requested a deployment
to
preview/pr-568/magento
October 29, 2026 03:16
In progress
deco-hosting
Bot
requested a deployment
to
preview/pr-568/meta-ads
October 29, 2026 03:16
In progress
deco-hosting
Bot
requested a deployment
to
preview/pr-568/nanobanana
October 29, 2026 03:17
In progress
deco-hosting
Bot
requested a deployment
to
preview/pr-568/object-storage
October 29, 2026 03:17
In progress
deco-hosting
Bot
requested a deployment
to
preview/pr-568/pandadoc
October 29, 2026 03:17
In progress
deco-hosting
Bot
requested a deployment
to
preview/pr-568/perplexity
October 29, 2026 03:17
In progress
deco-hosting
Bot
requested a deployment
to
preview/pr-568/registry
October 29, 2026 03:17
In progress
deco-hosting
Bot
requested a deployment
to
preview/pr-568/shopify
October 29, 2026 03:17
In progress
deco-hosting
Bot
requested a deployment
to
preview/pr-568/slack-mcp
October 29, 2026 03:17
In progress
deco-hosting
Bot
requested a deployment
to
preview/pr-568/vtex-docs
October 29, 2026 03:17
In progress
deco-hosting
Bot
requested a deployment
to
preview/pr-568/whatsappagent
October 29, 2026 03:17
In progress
deco-hosting
Bot
requested a deployment
to
preview/pr-568/youtube-channel-admin
October 29, 2026 03:17
In progress
deco-hosting
Bot
requested a deployment
to
preview/pr-568/youtube-search
October 29, 2026 03:17
In progress
This branch is being deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The GTM API's
PUTreplaces the whole entity.update_tag,update_triggerandupdate_variableforwarded only a few fields, so every update silently deleted the rest. Lost fields included:consentSettings, which holds the Consent Mode/LGPD check of tags that need consent;parentFolderId;setupTag/teardownTag;priorityand the schedule.get_tagalso hidconsentSettings, so callers could not notice.Found while preparing the Grupo Dass containers (GTM-TL4DML26, GTM-P8Q5HMS, GTM-M6QJTLF). Tags lost their folder on update, and tags that need consent could not be edited safely.
Fix
GTMClient.mergedPut: reads the current entity, overlays only the fields the caller set (undefinedis skipped), then sends thePUT. Used by all three update methods.get/list/updatereturnconsentSettings.update_tagacceptsconsentSettingsandparentFolderId.formatValue: typed as the options object GTM returns. The oldParameterschema madelist_variables/get_variablefail output validation.create_versiontool:workspaces/{id}:create_version. It never publishes.Validation
bun test: newgtm-client.test.tschecks that an update keepsconsentSettings,parentFolderIdandsetupTag, and dropsundefinedkeys.bun run check: no new errors. The existing@decocms/bindingsEventBusBindingClienterror also happens onmain.🤖 Generated with Claude Code
Summary by cubic
Fixes GTM tag, trigger, and variable updates silently deleting fields the tool didn't forward. The GTM API's
PUTreplaces the whole entity, so every update dropped the consent settings, folder, setup/teardown tags, priority, and schedule.consentSettings;update_tagacceptsconsentSettingsandparentFolderId.formatValueis now the options object GTM returns, fixinglist_variables/get_variableoutput validation.create_versiontool that creates a container version without publishing.Written for commit 6ed2851. Summary will update on new commits.