fix(model): register magnetic cell derivatives correctly#5836
Conversation
Place magnetic cell derivatives in the cell bucket so reduced definitions are generated. Add the optional DeepEval virial mapping and bucket/category regression coverage. Coding-Agent: Codex Codex-Version: codex-cli 0.144.4 Model: gpt-5.6-sol Reasoning-Effort: xhigh
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (3)
📝 WalkthroughWalkthroughMagnetic cell derivatives are moved to the cell-derivative bucket, mapped to the backend’s ChangesMagnetic cell derivative outputs
Estimated code review effort: 2 (Simple) | ~10 minutes Suggested labels: Suggested reviewers: 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #5836 +/- ##
==========================================
- Coverage 78.58% 76.86% -1.73%
==========================================
Files 1050 1050
Lines 120637 120634 -3
Branches 4356 4358 +2
==========================================
- Hits 94801 92721 -2080
- Misses 24278 26350 +2072
- Partials 1558 1563 +5 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
|
Possible reviewers based on changed lines, exact file history, and exact-file review history:
No review request was made automatically. Coding agent: Codex |
Summary
Why existing tests missed this
The existing comprehensive output-definition test only compared the flattened ModelOutputDef key set. The magnetic cell derivative appeared in that flattened set even while stored in the wrong internal bucket, so the test passed. It did not inspect keys_derv_c versus keys_derv_r and did not expect the reduced magnetic virial definition. The new regression asserts both internal bucket membership and the derived reduced definition.
Validation
An additional pt_expt spin-test collection attempt hit an environment Triton plugin import segmentation fault before test collection; the focused pure-metadata and core tests are unaffected.
Closes #5632
Coding agent: Codex
Codex version: codex-cli 0.144.4
Model: gpt-5.6-sol
Reasoning effort: xhigh
Summary by CodeRabbit