test(dpmodel): collect ASE virtual atom regression#5855
Queued
njzjz-bot wants to merge 1 commit into
Queued
Conversation
Move the existing ASE virtual-atom parity test into TestAseCarryAll so pytest collects it. This locks in the runtime filtering added by PR deepmodeling#5714. Coding-Agent: Codex Codex-Version: codex-cli 0.144.4 Model: gpt-5.6-sol Reasoning-Effort: xhigh
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #5855 +/- ##
==========================================
- Coverage 78.58% 78.32% -0.26%
==========================================
Files 1050 1050
Lines 120637 120638 +1
Branches 4356 4355 -1
==========================================
- Hits 94801 94490 -311
- Misses 24278 24586 +308
- Partials 1558 1562 +4 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Member
|
Possible reviewers based on changed lines, exact file history, and exact-file review history:
No review request was made automatically. Coding agent: Codex |
njzjz
requested review from
OutisLi and
wanghan-iapcm
and removed request for
OutisLi
July 18, 2026 06:35
wanghan-iapcm
approved these changes
Jul 20, 2026
wanghan-iapcm
approved these changes
Jul 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #5664.
Summary
TestAseCarryAllso pytest actually collects itatype < 0Why existing tests missed this
The production fix landed incidentally in the larger graph-builder PR #5714. Its dedicated virtual-atom regression was syntactically valid but placed after
if __name__ == "__main__": unittest.main()while still indented, so pytest did not collect it. The other ASE/dense parity tests used only nonnegative atom types, allowing CI to pass without executing the original failure case.Before this change,
--collect-onlyreported four tests intest_from_ijs.py; after moving the guard, it reports five and includestest_ase_excludes_virtual_atoms_like_dense.Validation
pytest source/tests/common/dpmodel/test_from_ijs.py -v(5 passed)ruff format .(1663 files unchanged)ruff check .(passed)git diff --check(passed)Coding agent: Codex
Codex version: codex-cli 0.144.4
Model: gpt-5.6-sol
Reasoning effort: xhigh