Skip to content

test(dpmodel): collect ASE virtual atom regression#5855

Queued
njzjz-bot wants to merge 1 commit into
deepmodeling:masterfrom
njzjz-bot:fix/ase-neighbor-graph-virtual-atoms-5664
Queued

test(dpmodel): collect ASE virtual atom regression#5855
njzjz-bot wants to merge 1 commit into
deepmodeling:masterfrom
njzjz-bot:fix/ase-neighbor-graph-virtual-atoms-5664

Conversation

@njzjz-bot

Copy link
Copy Markdown
Contributor

Closes #5664.

Summary

Why existing tests missed this

The production fix landed incidentally in the larger graph-builder PR #5714. Its dedicated virtual-atom regression was syntactically valid but placed after if __name__ == "__main__": unittest.main() while still indented, so pytest did not collect it. The other ASE/dense parity tests used only nonnegative atom types, allowing CI to pass without executing the original failure case.

Before this change, --collect-only reported four tests in test_from_ijs.py; after moving the guard, it reports five and includes test_ase_excludes_virtual_atoms_like_dense.

Validation

  • pytest source/tests/common/dpmodel/test_from_ijs.py -v (5 passed)
  • ruff format . (1663 files unchanged)
  • ruff check . (passed)
  • git diff --check (passed)

Coding agent: Codex
Codex version: codex-cli 0.144.4
Model: gpt-5.6-sol
Reasoning effort: xhigh

Move the existing ASE virtual-atom parity test into TestAseCarryAll so pytest
collects it. This locks in the runtime filtering added by PR deepmodeling#5714.

Coding-Agent: Codex
Codex-Version: codex-cli 0.144.4
Model: gpt-5.6-sol
Reasoning-Effort: xhigh
@codecov

codecov Bot commented Jul 17, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 78.32%. Comparing base (6c3b985) to head (2da720d).

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #5855      +/-   ##
==========================================
- Coverage   78.58%   78.32%   -0.26%     
==========================================
  Files        1050     1050              
  Lines      120637   120638       +1     
  Branches     4356     4355       -1     
==========================================
- Hits        94801    94490     -311     
- Misses      24278    24586     +308     
- Partials     1558     1562       +4     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@njzjz

njzjz commented Jul 18, 2026

Copy link
Copy Markdown
Member

Possible reviewers based on changed lines, exact file history, and exact-file review history:

  • @wanghan-iapcm — 2 commits on changed files; 11 reviews on exact changed files (source/tests/common/dpmodel/test_from_ijs.py).
  • @OutisLi — 8 reviews on exact changed files (source/tests/common/dpmodel/test_from_ijs.py).

No review request was made automatically.

Coding agent: Codex
Codex version: codex-cli 0.144.4
Model: gpt-5.6-sol
Reasoning effort: xhigh

@njzjz
njzjz requested review from OutisLi and wanghan-iapcm and removed request for OutisLi July 18, 2026 06:35
@wanghan-iapcm
wanghan-iapcm added this pull request to the merge queue Jul 20, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Code scan] Filter virtual atoms in ASE neighbor-graph construction

3 participants