Screenshots from the launch film - #7
kiro-agent[bot] wants to merge 1 commit into
Conversation
There was a problem hiding this comment.
📋 Review Summary — Ready to merge
Only minor nits — nothing blocking a merge.
Findings
The README gallery omits the export screenshot added by this PR ▶
Fix with agent prompt
These are the findings from a code review of this pull request.
## 1. The README gallery omits the export screenshot added by this PR
Path: README.md
Line: 29
Issue: The new screenshots section embeds only images 1–4, while the PR also adds `store/film/5-copy-text-markdown-json-1280x800.png`. Readers of the README never see the export/copy-as-JSON screenshot that the release assets introduce, so the gallery no longer represents the full set of launch-film store screenshots.
Suggested fix:
- Add the fifth `store/film/5-copy-text-markdown-json-1280x800.png` image to the Screenshots table, either as a final single-cell row or by adding a sixth companion cell if another image is intended.
---
For each finding above, determine whether it is valid and should be fixed. If so, fix it directly. Where a finding offers several remedies, pick one and say why. Leave the pull request's own changed files alone unless a fix requires touching them.Summary
The change adds launch-film screenshot assets to the README and store listing, and updates the visible repository status to 1.8.1. The assets referenced by the changed files exist at the advertised dimensions, but the README screenshots section omits the fifth export screenshot introduced by this PR, so the repository-facing gallery is incomplete.
Commands
Re-review the latest changes:
@xhawk-ai review again
Resolve all review threads and post a summary:
@xhawk-ai resolve all
| |---|---| | ||
| |  |  | | ||
| | **Confidence, not guesses** | **See why it matched** | | ||
| |  |  | |
There was a problem hiding this comment.
The README gallery omits the export screenshot added by this PR
The new screenshots section embeds only images 1–4, while the PR also adds store/film/5-copy-text-markdown-json-1280x800.png. Readers of the README never see the export/copy-as-JSON screenshot that the release assets introduce, so the gallery no longer represents the full set of launch-film store screenshots.
Suggestions
Add the fifth store/film/5-copy-text-markdown-json-1280x800.png image to the Screenshots table, either as a final single-cell row or by adding a sixth companion cell if another image is intended.
Brings the WhatStack README and store assets in line with EkSaath: store screenshots cut from the launch film.
store/film/: 5 screenshots at 1280×800, cut from real frames of the film:store/film/promo-marquee-1400x560.png: the film's end card. The listing had no marquee before.README.md: new Screenshots table under the film. The Status line now says 1.8.1 (it still said 1.8.0).store/LISTING.md: lists the new assets.The existing
store/screenshots/*files andnpm run assetsare unchanged, so the store-readiness tests still pass. The new images are optional: upload them in the dashboard if you prefer them.